Re: [Mesa-dev] [PATCH] mesa: minor simplification in test_attachment_completeness()

2017-10-13 Thread Timothy Arceri 

Reviewed-by: Timothy Arceri 

On 14/10/17 09:17, Brian Paul wrote:

We already have a pointer to the texture object.  Use it here.
---
  src/mesa/main/fbobject.c | 3 +--
  1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/src/mesa/main/fbobject.c b/src/mesa/main/fbobject.c
index db8c207..71e91f9 100644
--- a/src/mesa/main/fbobject.c
+++ b/src/mesa/main/fbobject.c
@@ -855,8 +855,7 @@ test_attachment_completeness(const struct gl_context *ctx, 
GLenum format,
* these textures to be used as a render target, this is done via
* GL_EXT_color_buffer(_half)_float with set of new sized types.
*/
- if (_mesa_is_gles(ctx) && (texImage->TexObject->_IsFloat ||
-texImage->TexObject->_IsHalfFloat)) {
+ if (_mesa_is_gles(ctx) && (texObj->_IsFloat || texObj->_IsHalfFloat)) 
{
  att_incomplete("bad internal format");
  att->Complete = GL_FALSE;
  return;


___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [PATCH] mesa: minor simplification in test_attachment_completeness()

2017-10-13 Thread Brian Paul 
We already have a pointer to the texture object.  Use it here.
---
 src/mesa/main/fbobject.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/src/mesa/main/fbobject.c b/src/mesa/main/fbobject.c
index db8c207..71e91f9 100644
--- a/src/mesa/main/fbobject.c
+++ b/src/mesa/main/fbobject.c
@@ -855,8 +855,7 @@ test_attachment_completeness(const struct gl_context *ctx, 
GLenum format,
   * these textures to be used as a render target, this is done via
   * GL_EXT_color_buffer(_half)_float with set of new sized types.
   */
- if (_mesa_is_gles(ctx) && (texImage->TexObject->_IsFloat ||
-texImage->TexObject->_IsHalfFloat)) {
+ if (_mesa_is_gles(ctx) && (texObj->_IsFloat || texObj->_IsHalfFloat)) 
{
 att_incomplete("bad internal format");
 att->Complete = GL_FALSE;
 return;
-- 
1.9.1

___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev