Re: [Mesa-dev] [PATCH] meson: don't build gallium dri target if gallium is disabled

2017-10-19 Thread Lyude Paul 
Reviewed-by: Lyude Paul 

On Thu, 2017-10-19 at 10:32 -0700, Dylan Baker wrote:
> Otherwise -Dgallium-drivers= will cause libmesa_gallium to be built and
> the megadriver install script to attempt to install drivers without any
> actual drivers being built.
> 
> fixes: 66f97f6640f5316b36177fd1053f0027eb6ec6cc ("meson: build radeonsi")
> Reported-by: Rafael Antognolli 
> Signed-off-by: Dylan Baker 
> ---
>  src/gallium/meson.build | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/gallium/meson.build b/src/gallium/meson.build
> index a65b32c658e..97347819d60 100644
> --- a/src/gallium/meson.build
> +++ b/src/gallium/meson.build
> @@ -67,7 +67,7 @@ subdir('state_trackers/dri')
>  # TODO: virgl
>  # TODO: winsys/sw/xlib
>  # TODO: clover
> -if with_dri
> +if with_dri and with_gallium
>subdir('targets/dri')
>  endif
>  # TODO: xlib-glx
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH] meson: don't build gallium dri target if gallium is disabled

2017-10-19 Thread Rafael Antognolli 
On Thu, Oct 19, 2017 at 10:32:46AM -0700, Dylan Baker wrote:
> Otherwise -Dgallium-drivers= will cause libmesa_gallium to be built and
> the megadriver install script to attempt to install drivers without any
> actual drivers being built.

Tested-by: Rafael Antognolli 

> fixes: 66f97f6640f5316b36177fd1053f0027eb6ec6cc ("meson: build radeonsi")
> Reported-by: Rafael Antognolli 
> Signed-off-by: Dylan Baker 
> ---
>  src/gallium/meson.build | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/gallium/meson.build b/src/gallium/meson.build
> index a65b32c658e..97347819d60 100644
> --- a/src/gallium/meson.build
> +++ b/src/gallium/meson.build
> @@ -67,7 +67,7 @@ subdir('state_trackers/dri')
>  # TODO: virgl
>  # TODO: winsys/sw/xlib
>  # TODO: clover
> -if with_dri
> +if with_dri and with_gallium
>subdir('targets/dri')
>  endif
>  # TODO: xlib-glx
> -- 
> 2.14.2
> 
> ___
> mesa-dev mailing list
> mesa-dev@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [PATCH] meson: don't build gallium dri target if gallium is disabled

2017-10-19 Thread Dylan Baker 
Otherwise -Dgallium-drivers= will cause libmesa_gallium to be built and
the megadriver install script to attempt to install drivers without any
actual drivers being built.

fixes: 66f97f6640f5316b36177fd1053f0027eb6ec6cc ("meson: build radeonsi")
Reported-by: Rafael Antognolli 
Signed-off-by: Dylan Baker 
---
 src/gallium/meson.build | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/gallium/meson.build b/src/gallium/meson.build
index a65b32c658e..97347819d60 100644
--- a/src/gallium/meson.build
+++ b/src/gallium/meson.build
@@ -67,7 +67,7 @@ subdir('state_trackers/dri')
 # TODO: virgl
 # TODO: winsys/sw/xlib
 # TODO: clover
-if with_dri
+if with_dri and with_gallium
   subdir('targets/dri')
 endif
 # TODO: xlib-glx
-- 
2.14.2

___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev