Re: [Mesa-dev] [PATCH] nir: Remove outdated comment

[Alejandro Piñeiro]

On 28/08/18 03:18, Jason Ekstrand wrote:
> Reviewed-by: Jason Ekstrand  >
>
> On Mon, Aug 27, 2018 at 5:20 PM Caio Marcelo de Oliveira Filho
> mailto:caio.olive...@intel.com>> wrote:
>
> ---
>
> The move of comapre functions landed before the suggestion to remove
>

typo: comapre => compare

> the comment, so removing it now.
>
>  src/compiler/nir/nir_deref.c | 3 ---
>  1 file changed, 3 deletions(-)
>
> diff --git a/src/compiler/nir/nir_deref.c
> b/src/compiler/nir/nir_deref.c
> index c8851688f9d..097ea8f1046 100644
> --- a/src/compiler/nir/nir_deref.c
> +++ b/src/compiler/nir/nir_deref.c
> @@ -271,9 +271,6 @@ nir_fixup_deref_modes(nir_shader *shader)
>     }
>  }
>
> -/** Returns true if the storage referrenced to by deref
> completely contains
> - * the storage referenced by sub.
> - */
>  nir_deref_compare_result
>  nir_compare_deref_paths(nir_deref_path *a_path,
>                          nir_deref_path *b_path)
> -- 
> 2.18.0
>
>
>
> ___
> mesa-dev mailing list
> mesa-dev@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev

___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH] nir: Remove outdated comment

[Jason Ekstrand]

Reviewed-by: Jason Ekstrand 

On Mon, Aug 27, 2018 at 5:20 PM Caio Marcelo de Oliveira Filho <
caio.olive...@intel.com> wrote:

> ---
>
> The move of comapre functions landed before the suggestion to remove
> the comment, so removing it now.
>
>  src/compiler/nir/nir_deref.c | 3 ---
>  1 file changed, 3 deletions(-)
>
> diff --git a/src/compiler/nir/nir_deref.c b/src/compiler/nir/nir_deref.c
> index c8851688f9d..097ea8f1046 100644
> --- a/src/compiler/nir/nir_deref.c
> +++ b/src/compiler/nir/nir_deref.c
> @@ -271,9 +271,6 @@ nir_fixup_deref_modes(nir_shader *shader)
> }
>  }
>
> -/** Returns true if the storage referrenced to by deref completely
> contains
> - * the storage referenced by sub.
> - */
>  nir_deref_compare_result
>  nir_compare_deref_paths(nir_deref_path *a_path,
>  nir_deref_path *b_path)
> --
> 2.18.0
>
>
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [PATCH] nir: Remove outdated comment

[Caio Marcelo de Oliveira Filho]

---

The move of comapre functions landed before the suggestion to remove
the comment, so removing it now.

 src/compiler/nir/nir_deref.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/src/compiler/nir/nir_deref.c b/src/compiler/nir/nir_deref.c
index c8851688f9d..097ea8f1046 100644
--- a/src/compiler/nir/nir_deref.c
+++ b/src/compiler/nir/nir_deref.c
@@ -271,9 +271,6 @@ nir_fixup_deref_modes(nir_shader *shader)
}
 }
 
-/** Returns true if the storage referrenced to by deref completely contains
- * the storage referenced by sub.
- */
 nir_deref_compare_result
 nir_compare_deref_paths(nir_deref_path *a_path,
 nir_deref_path *b_path)
-- 
2.18.0

___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev