Re: [Mesa-dev] [PATCH] r600: don't emit atomic save if we have no atomic counters.

2017-11-13 Thread Gert Wollny
Obviously, you can now disregard my other email about the performance
regression, this fixes it. 

Tested-By: Gert Wollny 

Best wishes, 


Am Freitag, den 10.11.2017, 13:47 +1000 schrieb Dave Airlie:
> From: Dave Airlie 
> 
> Otherwise we end up emitting the fence.
> 
> Signed-off-by: Dave Airlie 
> ---
>  src/gallium/drivers/r600/evergreen_state.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/src/gallium/drivers/r600/evergreen_state.c
> b/src/gallium/drivers/r600/evergreen_state.c
> index c1d13fd..30819ae 100644
> --- a/src/gallium/drivers/r600/evergreen_state.c
> +++ b/src/gallium/drivers/r600/evergreen_state.c
> @@ -4634,6 +4634,9 @@ void evergreen_emit_atomic_buffer_save(struct
> r600_context *rctx,
>   unsigned reloc;
>  
>   mask = *atomic_used_mask_p;
> + if (!mask)
> + return;
> +
>   while (mask) {
>   unsigned atomic_index = u_bit_scan(&mask);
>   struct r600_shader_atomic *atomic =
> &combined_atomics[atomic_index];
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev


[Mesa-dev] [PATCH] r600: don't emit atomic save if we have no atomic counters.

2017-11-09 Thread Dave Airlie
From: Dave Airlie 

Otherwise we end up emitting the fence.

Signed-off-by: Dave Airlie 
---
 src/gallium/drivers/r600/evergreen_state.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/src/gallium/drivers/r600/evergreen_state.c 
b/src/gallium/drivers/r600/evergreen_state.c
index c1d13fd..30819ae 100644
--- a/src/gallium/drivers/r600/evergreen_state.c
+++ b/src/gallium/drivers/r600/evergreen_state.c
@@ -4634,6 +4634,9 @@ void evergreen_emit_atomic_buffer_save(struct 
r600_context *rctx,
unsigned reloc;
 
mask = *atomic_used_mask_p;
+   if (!mask)
+   return;
+
while (mask) {
unsigned atomic_index = u_bit_scan(&mask);
struct r600_shader_atomic *atomic = 
&combined_atomics[atomic_index];
-- 
2.9.5

___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev