Re: [Mesa-dev] [PATCH] r600g: Removed unnecessary positivity check for unsigned int variable.

2014-01-29 Thread Marek Olšák
Reviewed-by: Marek Olšák marek.ol...@amd.com

Marek

On Thu, Dec 12, 2013 at 3:58 PM, Siavash Eliasi siavashser...@gmail.com wrote:
 ---
  src/gallium/drivers/r600/r600_asm.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

 diff --git a/src/gallium/drivers/r600/r600_asm.c 
 b/src/gallium/drivers/r600/r600_asm.c
 index 86f79e2..c5922a8 100644
 --- a/src/gallium/drivers/r600/r600_asm.c
 +++ b/src/gallium/drivers/r600/r600_asm.c
 @@ -387,7 +387,7 @@ static int reserve_cfile(struct r600_bytecode *bc, struct 
 alu_bank_swizzle *bs,

  static int is_gpr(unsigned sel)
  {
 -   return (sel = 0  sel = 127);
 +   return (sel = 127);
  }

  /* CB constants start at 512, and get translated to a kcache index when ALU
 --
 1.8.4.2

 ___
 mesa-dev mailing list
 mesa-dev@lists.freedesktop.org
 http://lists.freedesktop.org/mailman/listinfo/mesa-dev
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev


[Mesa-dev] [PATCH] r600g: Removed unnecessary positivity check for unsigned int variable.

2013-12-12 Thread Siavash Eliasi
---
 src/gallium/drivers/r600/r600_asm.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/gallium/drivers/r600/r600_asm.c 
b/src/gallium/drivers/r600/r600_asm.c
index 86f79e2..c5922a8 100644
--- a/src/gallium/drivers/r600/r600_asm.c
+++ b/src/gallium/drivers/r600/r600_asm.c
@@ -387,7 +387,7 @@ static int reserve_cfile(struct r600_bytecode *bc, struct 
alu_bank_swizzle *bs,
 
 static int is_gpr(unsigned sel)
 {
-   return (sel = 0  sel = 127);
+   return (sel = 127);
 }
 
 /* CB constants start at 512, and get translated to a kcache index when ALU
-- 
1.8.4.2

___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev