Re: [Mesa-dev] [PATCH] radv: fix CLEAR_STATE packet length.

2017-10-19 Thread Samuel Pitoiset 

Reviewed-by: Samuel Pitoiset 

On 10/19/2017 05:54 AM, Dave Airlie wrote:

From: Dave Airlie 

Looking at shader traces I noticed some registers were missing,
one of them was being eaten by the wrong clear state length.

Fixes: 4f42ea4dc (radv: use CLEAR_STATE for initializing some registers)
Signed-off-by: Dave Airlie 
---
  src/amd/vulkan/si_cmd_buffer.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/amd/vulkan/si_cmd_buffer.c b/src/amd/vulkan/si_cmd_buffer.c
index 1e8b43d4fa8..690f30b6abc 100644
--- a/src/amd/vulkan/si_cmd_buffer.c
+++ b/src/amd/vulkan/si_cmd_buffer.c
@@ -341,7 +341,7 @@ si_emit_config(struct radv_physical_device *physical_device,
radeon_emit(cs, CONTEXT_CONTROL_SHADOW_ENABLE(1));
  
  	if (physical_device->has_clear_state) {

-   radeon_emit(cs, PKT3(PKT3_CLEAR_STATE, 1, 0));
+   radeon_emit(cs, PKT3(PKT3_CLEAR_STATE, 0, 0));
radeon_emit(cs, 0);
}
  


___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH] radv: fix CLEAR_STATE packet length.

2017-10-19 Thread Bas Nieuwenhuizen 
Reviewed-by: Bas Nieuwenhuizen 

On Thu, Oct 19, 2017 at 5:54 AM, Dave Airlie  wrote:
> From: Dave Airlie 
>
> Looking at shader traces I noticed some registers were missing,
> one of them was being eaten by the wrong clear state length.
>
> Fixes: 4f42ea4dc (radv: use CLEAR_STATE for initializing some registers)
> Signed-off-by: Dave Airlie 
> ---
>  src/amd/vulkan/si_cmd_buffer.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/amd/vulkan/si_cmd_buffer.c b/src/amd/vulkan/si_cmd_buffer.c
> index 1e8b43d4fa8..690f30b6abc 100644
> --- a/src/amd/vulkan/si_cmd_buffer.c
> +++ b/src/amd/vulkan/si_cmd_buffer.c
> @@ -341,7 +341,7 @@ si_emit_config(struct radv_physical_device 
> *physical_device,
> radeon_emit(cs, CONTEXT_CONTROL_SHADOW_ENABLE(1));
>
> if (physical_device->has_clear_state) {
> -   radeon_emit(cs, PKT3(PKT3_CLEAR_STATE, 1, 0));
> +   radeon_emit(cs, PKT3(PKT3_CLEAR_STATE, 0, 0));
> radeon_emit(cs, 0);
> }
>
> --
> 2.14.2
>
> ___
> mesa-dev mailing list
> mesa-dev@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [PATCH] radv: fix CLEAR_STATE packet length.

2017-10-18 Thread Dave Airlie 
From: Dave Airlie 

Looking at shader traces I noticed some registers were missing,
one of them was being eaten by the wrong clear state length.

Fixes: 4f42ea4dc (radv: use CLEAR_STATE for initializing some registers)
Signed-off-by: Dave Airlie 
---
 src/amd/vulkan/si_cmd_buffer.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/amd/vulkan/si_cmd_buffer.c b/src/amd/vulkan/si_cmd_buffer.c
index 1e8b43d4fa8..690f30b6abc 100644
--- a/src/amd/vulkan/si_cmd_buffer.c
+++ b/src/amd/vulkan/si_cmd_buffer.c
@@ -341,7 +341,7 @@ si_emit_config(struct radv_physical_device *physical_device,
radeon_emit(cs, CONTEXT_CONTROL_SHADOW_ENABLE(1));
 
if (physical_device->has_clear_state) {
-   radeon_emit(cs, PKT3(PKT3_CLEAR_STATE, 1, 0));
+   radeon_emit(cs, PKT3(PKT3_CLEAR_STATE, 0, 0));
radeon_emit(cs, 0);
}
 
-- 
2.14.2

___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev