Re: [Mesa-dev] [PATCH] radv: fix order of the guardband register emission.

[Bas Nieuwenhuizen]

Reviewed-by: Bas Nieuwenhuizen 


On Sun, Apr 2, 2017 at 6:47 AM, Dave Airlie  wrote:
> From: Dave Airlie 
>
> y is vert, x is horiz.
>
> Noticed in visual inspection compared to radeonsi.
>
> Signed-off-by: Dave Airlie 
> ---
>  src/amd/vulkan/si_cmd_buffer.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/src/amd/vulkan/si_cmd_buffer.c b/src/amd/vulkan/si_cmd_buffer.c
> index e847dcf..e176abe 100644
> --- a/src/amd/vulkan/si_cmd_buffer.c
> +++ b/src/amd/vulkan/si_cmd_buffer.c
> @@ -627,10 +627,10 @@ si_write_scissors(struct radeon_winsys_cs *cs, int 
> first,
> }
>
> radeon_set_context_reg_seq(cs, R_028BE8_PA_CL_GB_VERT_CLIP_ADJ, 4);
> -   radeon_emit(cs, fui(guardband_x));
> -   radeon_emit(cs, fui(1.0));
> radeon_emit(cs, fui(guardband_y));
> radeon_emit(cs, fui(1.0));
> +   radeon_emit(cs, fui(guardband_x));
> +   radeon_emit(cs, fui(1.0));
>  }
>
>  static inline unsigned
> --
> 2.9.3
>
> ___
> mesa-dev mailing list
> mesa-dev@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [PATCH] radv: fix order of the guardband register emission.

[Dave Airlie]

From: Dave Airlie 

y is vert, x is horiz.

Noticed in visual inspection compared to radeonsi.

Signed-off-by: Dave Airlie 
---
 src/amd/vulkan/si_cmd_buffer.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/amd/vulkan/si_cmd_buffer.c b/src/amd/vulkan/si_cmd_buffer.c
index e847dcf..e176abe 100644
--- a/src/amd/vulkan/si_cmd_buffer.c
+++ b/src/amd/vulkan/si_cmd_buffer.c
@@ -627,10 +627,10 @@ si_write_scissors(struct radeon_winsys_cs *cs, int first,
}
 
radeon_set_context_reg_seq(cs, R_028BE8_PA_CL_GB_VERT_CLIP_ADJ, 4);
-   radeon_emit(cs, fui(guardband_x));
-   radeon_emit(cs, fui(1.0));
radeon_emit(cs, fui(guardband_y));
radeon_emit(cs, fui(1.0));
+   radeon_emit(cs, fui(guardband_x));
+   radeon_emit(cs, fui(1.0));
 }
 
 static inline unsigned
-- 
2.9.3

___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev