Re: [Mesa-dev] [PATCH] removed report to vendor message when dri3 is not detected

[Emil Velikov]

Hi Jacob,

On 11 February 2017 at 01:44, Jacob Lifshay  wrote:
> fixes bug 99715
>
While topic is [somewhat] ongoing, I'd suggest skimming through git
log for future patches.
Namely: use he correct prefix for the patch, explain why in the commit
message and use Bugzilla: http... tag.

Thanks !
Emil
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH] removed report to vendor message when dri3 is not detected

[Jason Ekstrand]

On Fri, Feb 10, 2017 at 5:44 PM, Jacob Lifshay 
wrote:

> fixes bug 99715
>

Not really... It fixes what the subject of the bug says but doesn't fully
solve the problem.  We need some way of detecting that we're on an X server
that *could* support us but can't because of a lack of DRI3.


> Signed-off-by: Jacob Lifshay 
> ---
>  src/vulkan/wsi/wsi_common_x11.c | 2 --
>  1 file changed, 2 deletions(-)
>
> diff --git a/src/vulkan/wsi/wsi_common_x11.c b/src/vulkan/wsi/wsi_common_
> x11.c
> index 64ba921..e092066 100644
> --- a/src/vulkan/wsi/wsi_common_x11.c
> +++ b/src/vulkan/wsi/wsi_common_x11.c
> @@ -266,7 +266,6 @@ VkBool32 wsi_get_physical_device_xcb_
> presentation_support(
>
> if (!wsi_conn->has_dri3) {
>fprintf(stderr, "vulkan: No DRI3 support detected - required for
> presentation\n");
> -  fprintf(stderr, "Note: Buggy applications may crash, if they do
> please report to vendor\n");
>return false;
> }
>
> @@ -315,7 +314,6 @@ x11_surface_get_support(VkIcdSurfaceBase *icd_surface,
>
> if (!wsi_conn->has_dri3) {
>fprintf(stderr, "vulkan: No DRI3 support detected - required for
> presentation\n");
> -  fprintf(stderr, "Note: Buggy applications may crash, if they do
> please report to vendor\n");
>*pSupported = false;
>return VK_SUCCESS;
> }
> --
> 2.7.4
>
> ___
> mesa-dev mailing list
> mesa-dev@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev
>
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [PATCH] removed report to vendor message when dri3 is not detected

[Jacob Lifshay]

fixes bug 99715

Signed-off-by: Jacob Lifshay 
---
 src/vulkan/wsi/wsi_common_x11.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/src/vulkan/wsi/wsi_common_x11.c b/src/vulkan/wsi/wsi_common_x11.c
index 64ba921..e092066 100644
--- a/src/vulkan/wsi/wsi_common_x11.c
+++ b/src/vulkan/wsi/wsi_common_x11.c
@@ -266,7 +266,6 @@ VkBool32 wsi_get_physical_device_xcb_presentation_support(
 
if (!wsi_conn->has_dri3) {
   fprintf(stderr, "vulkan: No DRI3 support detected - required for 
presentation\n");
-  fprintf(stderr, "Note: Buggy applications may crash, if they do please 
report to vendor\n");
   return false;
}
 
@@ -315,7 +314,6 @@ x11_surface_get_support(VkIcdSurfaceBase *icd_surface,
 
if (!wsi_conn->has_dri3) {
   fprintf(stderr, "vulkan: No DRI3 support detected - required for 
presentation\n");
-  fprintf(stderr, "Note: Buggy applications may crash, if they do please 
report to vendor\n");
   *pSupported = false;
   return VK_SUCCESS;
}
-- 
2.7.4

___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev