Re: [Mesa-dev] [PATCH] st/nine: enable csmt per default on iris
On 20/03/2019 23:47, Axel Davy wrote: On 20/03/2019 21:38, Andre Heider wrote: iris is thread safe, enable csmt for a ~5% performace boost. Signed-off-by: Andre Heider --- src/gallium/state_trackers/nine/device9.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/src/gallium/state_trackers/nine/device9.c b/src/gallium/state_trackers/nine/device9.c index 24c8ce062b3..db1c3a1d23d 100644 --- a/src/gallium/state_trackers/nine/device9.c +++ b/src/gallium/state_trackers/nine/device9.c @@ -266,13 +266,15 @@ NineDevice9_ctor( struct NineDevice9 *This, } /* Initialize CSMT */ + /* r600, radeonsi and iris are thread safe. */ if (pCTX->csmt_force == 1) This->csmt_active = true; else if (pCTX->csmt_force == 0) This->csmt_active = false; - else - /* r600 and radeonsi are thread safe. */ - This->csmt_active = strstr(pScreen->get_name(pScreen), "AMD") != NULL; + else if (strstr(pScreen->get_name(pScreen), "AMD") != NULL) + This->csmt_active = true; + else if (strstr(pScreen->get_name(pScreen), "Intel") != NULL) + This->csmt_active = true; /* We rely on u_upload_mgr using persistent coherent buffers (which don't * require flush to work in multi-pipe_context scenario) for vertex and Could have been an || inside the same if, but maybe it is easier to read that way. Yeah, I chose this way just for cosmetically reasons ;) Reviewed-by: Axel Davy Thanks! ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
Re: [Mesa-dev] [PATCH] st/nine: enable csmt per default on iris
On 20/03/2019 21:38, Andre Heider wrote: iris is thread safe, enable csmt for a ~5% performace boost. Signed-off-by: Andre Heider --- src/gallium/state_trackers/nine/device9.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/src/gallium/state_trackers/nine/device9.c b/src/gallium/state_trackers/nine/device9.c index 24c8ce062b3..db1c3a1d23d 100644 --- a/src/gallium/state_trackers/nine/device9.c +++ b/src/gallium/state_trackers/nine/device9.c @@ -266,13 +266,15 @@ NineDevice9_ctor( struct NineDevice9 *This, } /* Initialize CSMT */ +/* r600, radeonsi and iris are thread safe. */ if (pCTX->csmt_force == 1) This->csmt_active = true; else if (pCTX->csmt_force == 0) This->csmt_active = false; -else -/* r600 and radeonsi are thread safe. */ -This->csmt_active = strstr(pScreen->get_name(pScreen), "AMD") != NULL; +else if (strstr(pScreen->get_name(pScreen), "AMD") != NULL) +This->csmt_active = true; +else if (strstr(pScreen->get_name(pScreen), "Intel") != NULL) +This->csmt_active = true; /* We rely on u_upload_mgr using persistent coherent buffers (which don't * require flush to work in multi-pipe_context scenario) for vertex and Could have been an || inside the same if, but maybe it is easier to read that way. Reviewed-by: Axel Davy Axel ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
Re: [Mesa-dev] [PATCH] st/nine: enable csmt per default on iris
On Wednesday, March 20, 2019 1:38:40 PM PDT Andre Heider wrote: > iris is thread safe, enable csmt for a ~5% performace boost. > > Signed-off-by: Andre Heider > --- > src/gallium/state_trackers/nine/device9.c | 8 +--- > 1 file changed, 5 insertions(+), 3 deletions(-) > > diff --git a/src/gallium/state_trackers/nine/device9.c > b/src/gallium/state_trackers/nine/device9.c > index 24c8ce062b3..db1c3a1d23d 100644 > --- a/src/gallium/state_trackers/nine/device9.c > +++ b/src/gallium/state_trackers/nine/device9.c > @@ -266,13 +266,15 @@ NineDevice9_ctor( struct NineDevice9 *This, > } > > /* Initialize CSMT */ > +/* r600, radeonsi and iris are thread safe. */ > if (pCTX->csmt_force == 1) > This->csmt_active = true; > else if (pCTX->csmt_force == 0) > This->csmt_active = false; > -else > -/* r600 and radeonsi are thread safe. */ > -This->csmt_active = strstr(pScreen->get_name(pScreen), "AMD") != > NULL; > +else if (strstr(pScreen->get_name(pScreen), "AMD") != NULL) > +This->csmt_active = true; > +else if (strstr(pScreen->get_name(pScreen), "Intel") != NULL) > +This->csmt_active = true; > > /* We rely on u_upload_mgr using persistent coherent buffers (which don't > * require flush to work in multi-pipe_context scenario) for vertex and > Thanks Andre! Reviewed-by: Kenneth Graunke signature.asc Description: This is a digitally signed message part. ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
[Mesa-dev] [PATCH] st/nine: enable csmt per default on iris
iris is thread safe, enable csmt for a ~5% performace boost. Signed-off-by: Andre Heider --- src/gallium/state_trackers/nine/device9.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/src/gallium/state_trackers/nine/device9.c b/src/gallium/state_trackers/nine/device9.c index 24c8ce062b3..db1c3a1d23d 100644 --- a/src/gallium/state_trackers/nine/device9.c +++ b/src/gallium/state_trackers/nine/device9.c @@ -266,13 +266,15 @@ NineDevice9_ctor( struct NineDevice9 *This, } /* Initialize CSMT */ +/* r600, radeonsi and iris are thread safe. */ if (pCTX->csmt_force == 1) This->csmt_active = true; else if (pCTX->csmt_force == 0) This->csmt_active = false; -else -/* r600 and radeonsi are thread safe. */ -This->csmt_active = strstr(pScreen->get_name(pScreen), "AMD") != NULL; +else if (strstr(pScreen->get_name(pScreen), "AMD") != NULL) +This->csmt_active = true; +else if (strstr(pScreen->get_name(pScreen), "Intel") != NULL) +This->csmt_active = true; /* We rely on u_upload_mgr using persistent coherent buffers (which don't * require flush to work in multi-pipe_context scenario) for vertex and -- 2.20.1 ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
