Re: [Mesa-dev] [PATCH] st/omx/dec: Properly undefine DEBUG macro

2017-04-03 Thread Shaleen 
Yes, that is correct. I wasn't thinking clearly.

On Mon, Apr 3, 2017 at 1:57 PM Christian König 
wrote:

> Am 03.04.2017 um 06:35 schrieb Shaleen Jain:
> > ---
> >   src/gallium/state_trackers/omx/vid_dec.c | 2 +-
> >   1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/src/gallium/state_trackers/omx/vid_dec.c
> b/src/gallium/state_trackers/omx/vid_dec.c
> > index 9a6efb8e28..94664eba04 100644
> > --- a/src/gallium/state_trackers/omx/vid_dec.c
> > +++ b/src/gallium/state_trackers/omx/vid_dec.c
> > @@ -37,7 +37,7 @@
> >   #include 
> >
> >   /* bellagio defines a DEBUG macro that we don't want */
> > -#ifndef DEBUG
> > +#ifdef DEBUG
>
> NAK, the logic locked correct as it was before.
>
> Why do you want to invert it?
>
> Regards,
> Christian.
>
> >   #include 
> >   #undef DEBUG
> >   #else
>
>
>
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH] st/omx/dec: Properly undefine DEBUG macro

2017-04-03 Thread Christian König 

Am 03.04.2017 um 06:35 schrieb Shaleen Jain:

---
  src/gallium/state_trackers/omx/vid_dec.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/gallium/state_trackers/omx/vid_dec.c 
b/src/gallium/state_trackers/omx/vid_dec.c
index 9a6efb8e28..94664eba04 100644
--- a/src/gallium/state_trackers/omx/vid_dec.c
+++ b/src/gallium/state_trackers/omx/vid_dec.c
@@ -37,7 +37,7 @@
  #include 
  
  /* bellagio defines a DEBUG macro that we don't want */

-#ifndef DEBUG
+#ifdef DEBUG


NAK, the logic locked correct as it was before.

Why do you want to invert it?

Regards,
Christian.


  #include 
  #undef DEBUG
  #else



___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [PATCH] st/omx/dec: Properly undefine DEBUG macro

2017-04-02 Thread Shaleen Jain 
---
 src/gallium/state_trackers/omx/vid_dec.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/gallium/state_trackers/omx/vid_dec.c 
b/src/gallium/state_trackers/omx/vid_dec.c
index 9a6efb8e28..94664eba04 100644
--- a/src/gallium/state_trackers/omx/vid_dec.c
+++ b/src/gallium/state_trackers/omx/vid_dec.c
@@ -37,7 +37,7 @@
 #include 
 
 /* bellagio defines a DEBUG macro that we don't want */
-#ifndef DEBUG
+#ifdef DEBUG
 #include 
 #undef DEBUG
 #else
-- 
2.12.1

___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev