Re: [Mesa-dev] [PATCH] st/st_glsl_to_nir: call nir_lower_64bit_pack

2017-12-26 Thread Marek Olšák 
Reviewed-by: Marek Olšák 

Marek

On Thu, Dec 14, 2017 at 6:02 AM, Timothy Arceri  wrote:
> Fixes 56 crashes in radeonsi.
> ---
>  src/mesa/state_tracker/st_glsl_to_nir.cpp | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/src/mesa/state_tracker/st_glsl_to_nir.cpp 
> b/src/mesa/state_tracker/st_glsl_to_nir.cpp
> index 7c9e76a2dce..5683dfe 100644
> --- a/src/mesa/state_tracker/st_glsl_to_nir.cpp
> +++ b/src/mesa/state_tracker/st_glsl_to_nir.cpp
> @@ -267,20 +267,21 @@ st_nir_assign_uniform_locations(struct gl_program *prog,
> *size = max;
>  }
>
>  static void
>  st_nir_opts(nir_shader *nir)
>  {
> bool progress;
> do {
>progress = false;
>
> +  NIR_PASS_V(nir, nir_lower_64bit_pack);
>NIR_PASS(progress, nir, nir_copy_prop);
>NIR_PASS(progress, nir, nir_opt_remove_phis);
>NIR_PASS(progress, nir, nir_opt_dce);
>if (nir_opt_trivial_continues(nir)) {
>   progress = true;
>   NIR_PASS(progress, nir, nir_copy_prop);
>   NIR_PASS(progress, nir, nir_opt_dce);
>}
>NIR_PASS(progress, nir, nir_opt_if);
>NIR_PASS(progress, nir, nir_opt_dead_cf);
> --
> 2.14.3
>
> ___
> mesa-dev mailing list
> mesa-dev@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH] st/st_glsl_to_nir: call nir_lower_64bit_pack

2017-12-16 Thread Timothy Arceri 

On 17/12/17 09:07, Erik Faye-Lund wrote:

On Thu, Dec 14, 2017 at 6:02 AM, Timothy Arceri  wrote:

Fixes 56 crashes in radeonsi.


56 crashes with what? Piglit?



Yes fixes 56 piglit crashes
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH] st/st_glsl_to_nir: call nir_lower_64bit_pack

2017-12-16 Thread Erik Faye-Lund 
On Thu, Dec 14, 2017 at 6:02 AM, Timothy Arceri  wrote:
> Fixes 56 crashes in radeonsi.

56 crashes with what? Piglit?
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH] st/st_glsl_to_nir: call nir_lower_64bit_pack

2017-12-14 Thread Dieter Nützel 

Tested-by: Dieter Nützel 

Dieter

Am 14.12.2017 06:02, schrieb Timothy Arceri:

Fixes 56 crashes in radeonsi.
---
 src/mesa/state_tracker/st_glsl_to_nir.cpp | 1 +
 1 file changed, 1 insertion(+)

diff --git a/src/mesa/state_tracker/st_glsl_to_nir.cpp
b/src/mesa/state_tracker/st_glsl_to_nir.cpp
index 7c9e76a2dce..5683dfe 100644
--- a/src/mesa/state_tracker/st_glsl_to_nir.cpp
+++ b/src/mesa/state_tracker/st_glsl_to_nir.cpp
@@ -267,20 +267,21 @@ st_nir_assign_uniform_locations(struct gl_program 
*prog,

*size = max;
 }

 static void
 st_nir_opts(nir_shader *nir)
 {
bool progress;
do {
   progress = false;

+  NIR_PASS_V(nir, nir_lower_64bit_pack);
   NIR_PASS(progress, nir, nir_copy_prop);
   NIR_PASS(progress, nir, nir_opt_remove_phis);
   NIR_PASS(progress, nir, nir_opt_dce);
   if (nir_opt_trivial_continues(nir)) {
  progress = true;
  NIR_PASS(progress, nir, nir_copy_prop);
  NIR_PASS(progress, nir, nir_opt_dce);
   }
   NIR_PASS(progress, nir, nir_opt_if);
   NIR_PASS(progress, nir, nir_opt_dead_cf);

___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [PATCH] st/st_glsl_to_nir: call nir_lower_64bit_pack

2017-12-13 Thread Timothy Arceri 
Fixes 56 crashes in radeonsi.
---
 src/mesa/state_tracker/st_glsl_to_nir.cpp | 1 +
 1 file changed, 1 insertion(+)

diff --git a/src/mesa/state_tracker/st_glsl_to_nir.cpp 
b/src/mesa/state_tracker/st_glsl_to_nir.cpp
index 7c9e76a2dce..5683dfe 100644
--- a/src/mesa/state_tracker/st_glsl_to_nir.cpp
+++ b/src/mesa/state_tracker/st_glsl_to_nir.cpp
@@ -267,20 +267,21 @@ st_nir_assign_uniform_locations(struct gl_program *prog,
*size = max;
 }
 
 static void
 st_nir_opts(nir_shader *nir)
 {
bool progress;
do {
   progress = false;
 
+  NIR_PASS_V(nir, nir_lower_64bit_pack);
   NIR_PASS(progress, nir, nir_copy_prop);
   NIR_PASS(progress, nir, nir_opt_remove_phis);
   NIR_PASS(progress, nir, nir_opt_dce);
   if (nir_opt_trivial_continues(nir)) {
  progress = true;
  NIR_PASS(progress, nir, nir_copy_prop);
  NIR_PASS(progress, nir, nir_opt_dce);
   }
   NIR_PASS(progress, nir, nir_opt_if);
   NIR_PASS(progress, nir, nir_opt_dead_cf);
-- 
2.14.3

___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev