Re: [Mesa-dev] [PATCH] st/xvmc/tests: Fix build failure, v2
Pushed as http://cgit.freedesktop.org/mesa/mesa/commit/?id=5ff81cfd8640d02dc78d736cad5020d54ef7a0dc 2013/5/3 Matt Turner > On Fri, May 3, 2013 at 1:48 AM, Lauri Kasanen wrote: > > v2: Removed extra libs as requested by Matt Turner. > > > > Signed-off-by: Lauri Kasanen > > --- > > src/gallium/state_trackers/xvmc/Makefile.am |2 +- > > 1 files changed, 1 insertions(+), 1 deletions(-) > > > > diff --git a/src/gallium/state_trackers/xvmc/Makefile.am > > b/src/gallium/state_trackers/xvmc/Makefile.am index 8ac7406..184432e > > 100644 > > --- a/src/gallium/state_trackers/xvmc/Makefile.am > > +++ b/src/gallium/state_trackers/xvmc/Makefile.am > > @@ -44,7 +44,7 @@ check_PROGRAMS = \ > > TESTS = $(check_PROGRAMS) > > noinst_PROGRAMS = tests/xvmc_bench > > > > -TEST_LIBS = -lXvMCW -lXvMC -lXv -lX11 > > +TEST_LIBS = $(XVMC_LIBS) -lXvMCW > > tests_test_context_SOURCES = tests/test_context.c tests/testlib.c > > tests_test_context_LDADD = $(TEST_LIBS) > > tests_test_surface_SOURCES = tests/test_surface.c tests/testlib.c > > -- > > 1.7.2.1 > > > > Reviewed-by: Matt Turner > ___ > mesa-dev mailing list > mesa-dev@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/mesa-dev > ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
Re: [Mesa-dev] [PATCH] st/xvmc/tests: Fix build failure, v2
On Fri, May 3, 2013 at 1:48 AM, Lauri Kasanen wrote: > v2: Removed extra libs as requested by Matt Turner. > > Signed-off-by: Lauri Kasanen > --- > src/gallium/state_trackers/xvmc/Makefile.am |2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/src/gallium/state_trackers/xvmc/Makefile.am > b/src/gallium/state_trackers/xvmc/Makefile.am index 8ac7406..184432e > 100644 > --- a/src/gallium/state_trackers/xvmc/Makefile.am > +++ b/src/gallium/state_trackers/xvmc/Makefile.am > @@ -44,7 +44,7 @@ check_PROGRAMS = \ > TESTS = $(check_PROGRAMS) > noinst_PROGRAMS = tests/xvmc_bench > > -TEST_LIBS = -lXvMCW -lXvMC -lXv -lX11 > +TEST_LIBS = $(XVMC_LIBS) -lXvMCW > tests_test_context_SOURCES = tests/test_context.c tests/testlib.c > tests_test_context_LDADD = $(TEST_LIBS) > tests_test_surface_SOURCES = tests/test_surface.c tests/testlib.c > -- > 1.7.2.1 > Reviewed-by: Matt Turner ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
Re: [Mesa-dev] [PATCH] st/xvmc/tests: Fix build failure, v2
Am 03.05.2013 10:48, schrieb Lauri Kasanen: v2: Removed extra libs as requested by Matt Turner. Signed-off-by: Lauri Kasanen Reviewed-by: Christian König --- src/gallium/state_trackers/xvmc/Makefile.am |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/gallium/state_trackers/xvmc/Makefile.am b/src/gallium/state_trackers/xvmc/Makefile.am index 8ac7406..184432e 100644 --- a/src/gallium/state_trackers/xvmc/Makefile.am +++ b/src/gallium/state_trackers/xvmc/Makefile.am @@ -44,7 +44,7 @@ check_PROGRAMS = \ TESTS = $(check_PROGRAMS) noinst_PROGRAMS = tests/xvmc_bench -TEST_LIBS = -lXvMCW -lXvMC -lXv -lX11 +TEST_LIBS = $(XVMC_LIBS) -lXvMCW tests_test_context_SOURCES = tests/test_context.c tests/testlib.c tests_test_context_LDADD = $(TEST_LIBS) tests_test_surface_SOURCES = tests/test_surface.c tests/testlib.c ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
[Mesa-dev] [PATCH] st/xvmc/tests: Fix build failure, v2
v2: Removed extra libs as requested by Matt Turner. Signed-off-by: Lauri Kasanen --- src/gallium/state_trackers/xvmc/Makefile.am |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/gallium/state_trackers/xvmc/Makefile.am b/src/gallium/state_trackers/xvmc/Makefile.am index 8ac7406..184432e 100644 --- a/src/gallium/state_trackers/xvmc/Makefile.am +++ b/src/gallium/state_trackers/xvmc/Makefile.am @@ -44,7 +44,7 @@ check_PROGRAMS = \ TESTS = $(check_PROGRAMS) noinst_PROGRAMS = tests/xvmc_bench -TEST_LIBS = -lXvMCW -lXvMC -lXv -lX11 +TEST_LIBS = $(XVMC_LIBS) -lXvMCW tests_test_context_SOURCES = tests/test_context.c tests/testlib.c tests_test_context_LDADD = $(TEST_LIBS) tests_test_surface_SOURCES = tests/test_surface.c tests/testlib.c -- 1.7.2.1 ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
Re: [Mesa-dev] [PATCH] st/xvmc/tests: Fix build failure
On Thu, May 2, 2013 at 11:52 AM, Lauri Kasanen wrote: > On Thu, 2 May 2013 07:58:30 -0700 > Matt Turner wrote: > >> > -TEST_LIBS = -lXvMCW -lXvMC -lXv -lX11 >> > +TEST_LIBS = $(XVMC_LIBS) -lXvMCW -lXvMC -lXv -lX11 >> >> Doesn't XVMC_LIBS include all of those other libraries? I think >> they're now redundant and should be removed. > > It doesn't here: > XVMC_LIBS = -L/usr/X11R7/lib -lXvMC -lXv -lX11-xcb -lX11 -lxcb-dri2 > -lxcb > > libXvMCW is not there. Okay, so you should remove at all but -lXvMCW. ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
Re: [Mesa-dev] [PATCH] st/xvmc/tests: Fix build failure
On Thu, 2 May 2013 07:58:30 -0700 Matt Turner wrote: > > -TEST_LIBS = -lXvMCW -lXvMC -lXv -lX11 > > +TEST_LIBS = $(XVMC_LIBS) -lXvMCW -lXvMC -lXv -lX11 > > Doesn't XVMC_LIBS include all of those other libraries? I think > they're now redundant and should be removed. It doesn't here: XVMC_LIBS = -L/usr/X11R7/lib -lXvMC -lXv -lX11-xcb -lX11 -lxcb-dri2 -lxcb libXvMCW is not there. - Lauri ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
Re: [Mesa-dev] [PATCH] st/xvmc/tests: Fix build failure
On Wed, May 1, 2013 at 12:17 PM, Lauri Kasanen wrote: > Without this, the X lib path was not properly passed for tests/: > /usr/bin/ld: cannot find -lXvMCW > /usr/bin/ld: cannot find -lXvMC > /usr/bin/ld: cannot find -lXv > /usr/bin/ld: cannot find -lX11 > collect2: ld returned 1 exit status > > Signed-off-by: Lauri Kasanen > --- > src/gallium/state_trackers/xvmc/Makefile.am |2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/src/gallium/state_trackers/xvmc/Makefile.am > b/src/gallium/state_trackers/xvmc/Makefile.am index 8ac7406..83a568b > 100644 > --- a/src/gallium/state_trackers/xvmc/Makefile.am > +++ b/src/gallium/state_trackers/xvmc/Makefile.am > @@ -44,7 +44,7 @@ check_PROGRAMS = \ > TESTS = $(check_PROGRAMS) > noinst_PROGRAMS = tests/xvmc_bench > > -TEST_LIBS = -lXvMCW -lXvMC -lXv -lX11 > +TEST_LIBS = $(XVMC_LIBS) -lXvMCW -lXvMC -lXv -lX11 Doesn't XVMC_LIBS include all of those other libraries? I think they're now redundant and should be removed. ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
Re: [Mesa-dev] [PATCH] st/xvmc/tests: Fix build failure
Am 01.05.2013 21:17, schrieb Lauri Kasanen: Without this, the X lib path was not properly passed for tests/: /usr/bin/ld: cannot find -lXvMCW /usr/bin/ld: cannot find -lXvMC /usr/bin/ld: cannot find -lXv /usr/bin/ld: cannot find -lX11 collect2: ld returned 1 exit status Signed-off-by: Lauri Kasanen Looks good to me, patch is: Reviewed-by: Christian König --- src/gallium/state_trackers/xvmc/Makefile.am |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/gallium/state_trackers/xvmc/Makefile.am b/src/gallium/state_trackers/xvmc/Makefile.am index 8ac7406..83a568b 100644 --- a/src/gallium/state_trackers/xvmc/Makefile.am +++ b/src/gallium/state_trackers/xvmc/Makefile.am @@ -44,7 +44,7 @@ check_PROGRAMS = \ TESTS = $(check_PROGRAMS) noinst_PROGRAMS = tests/xvmc_bench -TEST_LIBS = -lXvMCW -lXvMC -lXv -lX11 +TEST_LIBS = $(XVMC_LIBS) -lXvMCW -lXvMC -lXv -lX11 tests_test_context_SOURCES = tests/test_context.c tests/testlib.c tests_test_context_LDADD = $(TEST_LIBS) tests_test_surface_SOURCES = tests/test_surface.c tests/testlib.c ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
[Mesa-dev] [PATCH] st/xvmc/tests: Fix build failure
Without this, the X lib path was not properly passed for tests/: /usr/bin/ld: cannot find -lXvMCW /usr/bin/ld: cannot find -lXvMC /usr/bin/ld: cannot find -lXv /usr/bin/ld: cannot find -lX11 collect2: ld returned 1 exit status Signed-off-by: Lauri Kasanen --- src/gallium/state_trackers/xvmc/Makefile.am |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/gallium/state_trackers/xvmc/Makefile.am b/src/gallium/state_trackers/xvmc/Makefile.am index 8ac7406..83a568b 100644 --- a/src/gallium/state_trackers/xvmc/Makefile.am +++ b/src/gallium/state_trackers/xvmc/Makefile.am @@ -44,7 +44,7 @@ check_PROGRAMS = \ TESTS = $(check_PROGRAMS) noinst_PROGRAMS = tests/xvmc_bench -TEST_LIBS = -lXvMCW -lXvMC -lXv -lX11 +TEST_LIBS = $(XVMC_LIBS) -lXvMCW -lXvMC -lXv -lX11 tests_test_context_SOURCES = tests/test_context.c tests/testlib.c tests_test_context_LDADD = $(TEST_LIBS) tests_test_surface_SOURCES = tests/test_surface.c tests/testlib.c -- 1.7.2.1 ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
