Re: [Mesa-dev] [PATCH] svga: fix dma.pending > 0 test

2019-02-26 Thread Neha Bhende 
Looks good.
Reviewed-by: Neha Bhende 


Regards,

Neha


From: Brian Paul 
Sent: Monday, February 25, 2019 7:13 PM
To: mesa-dev@lists.freedesktop.org
Cc: Neha Bhende
Subject: [PATCH] svga: fix dma.pending > 0 test

The dma.pending field is boolean, so testing for > 0 isn't right.
---
 src/gallium/drivers/svga/svga_resource_buffer.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/gallium/drivers/svga/svga_resource_buffer.c 
b/src/gallium/drivers/svga/svga_resource_buffer.c
index e4d12f0..a3e11ad 100644
--- a/src/gallium/drivers/svga/svga_resource_buffer.c
+++ b/src/gallium/drivers/svga/svga_resource_buffer.c
@@ -117,7 +117,7 @@ svga_buffer_transfer_map(struct pipe_context *pipe,
  (void) svga_buffer_handle(svga, resource, sbuf->bind_flags);
   }

-  if (sbuf->dma.pending > 0) {
+  if (sbuf->dma.pending) {
  svga_buffer_upload_flush(svga, sbuf);
  svga_context_finish(svga);
   }
--
1.8.5.6

___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [PATCH] svga: fix dma.pending > 0 test

2019-02-25 Thread Brian Paul 
The dma.pending field is boolean, so testing for > 0 isn't right.
---
 src/gallium/drivers/svga/svga_resource_buffer.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/gallium/drivers/svga/svga_resource_buffer.c 
b/src/gallium/drivers/svga/svga_resource_buffer.c
index e4d12f0..a3e11ad 100644
--- a/src/gallium/drivers/svga/svga_resource_buffer.c
+++ b/src/gallium/drivers/svga/svga_resource_buffer.c
@@ -117,7 +117,7 @@ svga_buffer_transfer_map(struct pipe_context *pipe,
  (void) svga_buffer_handle(svga, resource, sbuf->bind_flags);
   }
 
-  if (sbuf->dma.pending > 0) {
+  if (sbuf->dma.pending) {
  svga_buffer_upload_flush(svga, sbuf);
  svga_context_finish(svga);
   }
-- 
1.8.5.6

___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev