[Mesa-dev] [PATCH] svga: scons: remove unused HAVE_SYS_TYPES_H define
Cc: Jose Fonseca Cc: Brian Paul Signed-off-by: Emil Velikov --- src/gallium/drivers/svga/SConscript| 1 - src/gallium/winsys/svga/drm/SConscript | 1 - 2 files changed, 2 deletions(-) diff --git a/src/gallium/drivers/svga/SConscript b/src/gallium/drivers/svga/SConscript index bb4d034..0ee6246 100644 --- a/src/gallium/drivers/svga/SConscript +++ b/src/gallium/drivers/svga/SConscript @@ -11,7 +11,6 @@ if env['suncc']: if env['gcc'] or env['clang']: env.Append(CPPDEFINES = [ 'HAVE_STDINT_H', - 'HAVE_SYS_TYPES_H', ]) env.Prepend(CPPPATH = [ diff --git a/src/gallium/winsys/svga/drm/SConscript b/src/gallium/winsys/svga/drm/SConscript index 099acda..2585053 100644 --- a/src/gallium/winsys/svga/drm/SConscript +++ b/src/gallium/winsys/svga/drm/SConscript @@ -8,7 +8,6 @@ if env['gcc'] or env['clang'] or env['icc']: env.Append(CCFLAGS = ['-fvisibility=hidden']) env.Append(CPPDEFINES = [ 'HAVE_STDINT_H', -'HAVE_SYS_TYPES_H', '-D_FILE_OFFSET_BITS=64', ]) -- 2.4.5 ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
Re: [Mesa-dev] [PATCH] svga: scons: remove unused HAVE_SYS_TYPES_H define
Can you elaborate in the commit message why this is being done or why the HAVE_SYS_TYPES_H definition is not needed? That saves me time having to research the issue myself. -Brian On 07/17/2015 11:18 AM, Emil Velikov wrote: Cc: Jose Fonseca Cc: Brian Paul Signed-off-by: Emil Velikov --- src/gallium/drivers/svga/SConscript| 1 - src/gallium/winsys/svga/drm/SConscript | 1 - 2 files changed, 2 deletions(-) diff --git a/src/gallium/drivers/svga/SConscript b/src/gallium/drivers/svga/SConscript index bb4d034..0ee6246 100644 --- a/src/gallium/drivers/svga/SConscript +++ b/src/gallium/drivers/svga/SConscript @@ -11,7 +11,6 @@ if env['suncc']: if env['gcc'] or env['clang']: env.Append(CPPDEFINES = [ 'HAVE_STDINT_H', - 'HAVE_SYS_TYPES_H', ]) env.Prepend(CPPPATH = [ diff --git a/src/gallium/winsys/svga/drm/SConscript b/src/gallium/winsys/svga/drm/SConscript index 099acda..2585053 100644 --- a/src/gallium/winsys/svga/drm/SConscript +++ b/src/gallium/winsys/svga/drm/SConscript @@ -8,7 +8,6 @@ if env['gcc'] or env['clang'] or env['icc']: env.Append(CCFLAGS = ['-fvisibility=hidden']) env.Append(CPPDEFINES = [ 'HAVE_STDINT_H', -'HAVE_SYS_TYPES_H', '-D_FILE_OFFSET_BITS=64', ]) ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
Re: [Mesa-dev] [PATCH] svga: scons: remove unused HAVE_SYS_TYPES_H define
On 17 July 2015 at 20:22, Brian Paul wrote: > Can you elaborate in the commit message why this is being done or why the > HAVE_SYS_TYPES_H definition is not needed? That saves me time having to > research the issue myself. > I'm not sure I can elaborate more than "it's unused" without sounding too repetitive. I can add "There isn't a single instance in mesa that mentions HAVE_SYS_TYPES_H, other than this file." if it makes it better. Thanks Emil ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
Re: [Mesa-dev] [PATCH] svga: scons: remove unused HAVE_SYS_TYPES_H define
On 07/17/2015 02:14 PM, Emil Velikov wrote: On 17 July 2015 at 20:22, Brian Paul wrote: Can you elaborate in the commit message why this is being done or why the HAVE_SYS_TYPES_H definition is not needed? That saves me time having to research the issue myself. I'm not sure I can elaborate more than "it's unused" without sounding too repetitive. I can add "There isn't a single instance in mesa that mentions HAVE_SYS_TYPES_H, other than this file." if it makes it better. Ugh, I read it as "remove HAVE_SYS_TYPES_H define". Thanks. -Brian ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
Re: [Mesa-dev] [PATCH] svga: scons: remove unused HAVE_SYS_TYPES_H define
On 20 July 2015 at 17:12, Brian Paul wrote: > On 07/17/2015 02:14 PM, Emil Velikov wrote: >> >> On 17 July 2015 at 20:22, Brian Paul wrote: >>> >>> Can you elaborate in the commit message why this is being done or why the >>> HAVE_SYS_TYPES_H definition is not needed? That saves me time having to >>> research the issue myself. >>> >> I'm not sure I can elaborate more than "it's unused" without sounding >> too repetitive. I can add "There isn't a single instance in mesa that >> mentions HAVE_SYS_TYPES_H, other than this file." if it makes it >> better. > > > Ugh, I read it as "remove HAVE_SYS_TYPES_H define". Thanks. > Can I consider this acked-by with the above commit message ? Would you like me to resend ? Thanks Emil ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
Re: [Mesa-dev] [PATCH] svga: scons: remove unused HAVE_SYS_TYPES_H define
On 07/28/2015 07:33 AM, Emil Velikov wrote: On 20 July 2015 at 17:12, Brian Paul wrote: On 07/17/2015 02:14 PM, Emil Velikov wrote: On 17 July 2015 at 20:22, Brian Paul wrote: Can you elaborate in the commit message why this is being done or why the HAVE_SYS_TYPES_H definition is not needed? That saves me time having to research the issue myself. I'm not sure I can elaborate more than "it's unused" without sounding too repetitive. I can add "There isn't a single instance in mesa that mentions HAVE_SYS_TYPES_H, other than this file." if it makes it better. Ugh, I read it as "remove HAVE_SYS_TYPES_H define". Thanks. Can I consider this acked-by with the above commit message ? Would you like me to resend ? Sure, Acked-by. Sorry for not being clear. -Brian ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
Re: [Mesa-dev] [PATCH] svga: scons: remove unused HAVE_SYS_TYPES_H define
On 28 July 2015 at 14:37, Brian Paul wrote: > On 07/28/2015 07:33 AM, Emil Velikov wrote: >> >> On 20 July 2015 at 17:12, Brian Paul wrote: >>> >>> On 07/17/2015 02:14 PM, Emil Velikov wrote: On 17 July 2015 at 20:22, Brian Paul wrote: > > > Can you elaborate in the commit message why this is being done or why > the > HAVE_SYS_TYPES_H definition is not needed? That saves me time having > to > research the issue myself. > I'm not sure I can elaborate more than "it's unused" without sounding too repetitive. I can add "There isn't a single instance in mesa that mentions HAVE_SYS_TYPES_H, other than this file." if it makes it better. >>> >>> >>> >>> Ugh, I read it as "remove HAVE_SYS_TYPES_H define". Thanks. >>> >> Can I consider this acked-by with the above commit message ? Would you >> like me to resend ? > > > Sure, Acked-by. Sorry for not being clear. > Sweet, thanks ! -Emil ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
