[Mesa-dev] [PATCH] swr/rast: fix invalid sign masks in avx512 simdlib code

2018-01-04 Thread Tim Rowley
Should be 0x8000 instead of 0x800.

Cc: mesa-sta...@lists.freedesktop.org
---
 src/gallium/drivers/swr/rasterizer/common/simdlib_128_avx512.inl | 2 +-
 src/gallium/drivers/swr/rasterizer/common/simdlib_256_avx512.inl | 2 +-
 src/gallium/drivers/swr/rasterizer/common/simdlib_512_avx512.inl | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/src/gallium/drivers/swr/rasterizer/common/simdlib_128_avx512.inl 
b/src/gallium/drivers/swr/rasterizer/common/simdlib_128_avx512.inl
index 66e8309610..b70a7691e2 100644
--- a/src/gallium/drivers/swr/rasterizer/common/simdlib_128_avx512.inl
+++ b/src/gallium/drivers/swr/rasterizer/common/simdlib_128_avx512.inl
@@ -270,7 +270,7 @@ static SIMDINLINE Float SIMDCALL mask_i32gather_ps(Float 
old, float const* p, In
 {
 __mmask16 m = 0xf;
 m = _mm512_mask_test_epi32_mask(m, _mm512_castps_si512(__conv(mask)),
-_mm512_set1_epi32(0x800));
+_mm512_set1_epi32(0x8000));
 return __conv(_mm512_mask_i32gather_ps(
 __conv(old),
 m,
diff --git a/src/gallium/drivers/swr/rasterizer/common/simdlib_256_avx512.inl 
b/src/gallium/drivers/swr/rasterizer/common/simdlib_256_avx512.inl
index 3f93cfbd7f..3fcfd250f9 100644
--- a/src/gallium/drivers/swr/rasterizer/common/simdlib_256_avx512.inl
+++ b/src/gallium/drivers/swr/rasterizer/common/simdlib_256_avx512.inl
@@ -271,7 +271,7 @@ static SIMDINLINE Float SIMDCALL mask_i32gather_ps(Float 
old, float const* p, In
 {
 __mmask16 m = 0xff;
 m = _mm512_mask_test_epi32_mask(m, _mm512_castps_si512(__conv(mask)),
-_mm512_set1_epi32(0x800));
+_mm512_set1_epi32(0x8000));
 return __conv(_mm512_mask_i32gather_ps(
 __conv(old),
 m,
diff --git a/src/gallium/drivers/swr/rasterizer/common/simdlib_512_avx512.inl 
b/src/gallium/drivers/swr/rasterizer/common/simdlib_512_avx512.inl
index c13b9f616a..8de62f2a7e 100644
--- a/src/gallium/drivers/swr/rasterizer/common/simdlib_512_avx512.inl
+++ b/src/gallium/drivers/swr/rasterizer/common/simdlib_512_avx512.inl
@@ -540,7 +540,7 @@ static SIMDINLINE uint32_t SIMDCALL movemask_pd(Double a)
 }
 static SIMDINLINE uint32_t SIMDCALL movemask_ps(Float a)
 {
-__mmask16 m = _mm512_test_epi32_mask(castps_si(a), set1_epi32(0x800));
+__mmask16 m = _mm512_test_epi32_mask(castps_si(a), set1_epi32(0x8000));
 return static_cast(m);
 }
 
-- 
2.14.1

___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev


Re: [Mesa-dev] [PATCH] swr/rast: fix invalid sign masks in avx512 simdlib code

2018-01-04 Thread Cherniak, Bruce
Reviewed-by: Bruce Cherniak 

> On Jan 4, 2018, at 10:33 AM, Tim Rowley  wrote:
> 
> Should be 0x8000 instead of 0x800.
> 
> Cc: mesa-sta...@lists.freedesktop.org
> ---
> src/gallium/drivers/swr/rasterizer/common/simdlib_128_avx512.inl | 2 +-
> src/gallium/drivers/swr/rasterizer/common/simdlib_256_avx512.inl | 2 +-
> src/gallium/drivers/swr/rasterizer/common/simdlib_512_avx512.inl | 2 +-
> 3 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/src/gallium/drivers/swr/rasterizer/common/simdlib_128_avx512.inl 
> b/src/gallium/drivers/swr/rasterizer/common/simdlib_128_avx512.inl
> index 66e8309610..b70a7691e2 100644
> --- a/src/gallium/drivers/swr/rasterizer/common/simdlib_128_avx512.inl
> +++ b/src/gallium/drivers/swr/rasterizer/common/simdlib_128_avx512.inl
> @@ -270,7 +270,7 @@ static SIMDINLINE Float SIMDCALL mask_i32gather_ps(Float 
> old, float const* p, In
> {
> __mmask16 m = 0xf;
> m = _mm512_mask_test_epi32_mask(m, _mm512_castps_si512(__conv(mask)),
> -_mm512_set1_epi32(0x800));
> +_mm512_set1_epi32(0x8000));
> return __conv(_mm512_mask_i32gather_ps(
> __conv(old),
> m,
> diff --git a/src/gallium/drivers/swr/rasterizer/common/simdlib_256_avx512.inl 
> b/src/gallium/drivers/swr/rasterizer/common/simdlib_256_avx512.inl
> index 3f93cfbd7f..3fcfd250f9 100644
> --- a/src/gallium/drivers/swr/rasterizer/common/simdlib_256_avx512.inl
> +++ b/src/gallium/drivers/swr/rasterizer/common/simdlib_256_avx512.inl
> @@ -271,7 +271,7 @@ static SIMDINLINE Float SIMDCALL mask_i32gather_ps(Float 
> old, float const* p, In
> {
> __mmask16 m = 0xff;
> m = _mm512_mask_test_epi32_mask(m, _mm512_castps_si512(__conv(mask)),
> -_mm512_set1_epi32(0x800));
> +_mm512_set1_epi32(0x8000));
> return __conv(_mm512_mask_i32gather_ps(
> __conv(old),
> m,
> diff --git a/src/gallium/drivers/swr/rasterizer/common/simdlib_512_avx512.inl 
> b/src/gallium/drivers/swr/rasterizer/common/simdlib_512_avx512.inl
> index c13b9f616a..8de62f2a7e 100644
> --- a/src/gallium/drivers/swr/rasterizer/common/simdlib_512_avx512.inl
> +++ b/src/gallium/drivers/swr/rasterizer/common/simdlib_512_avx512.inl
> @@ -540,7 +540,7 @@ static SIMDINLINE uint32_t SIMDCALL movemask_pd(Double a)
> }
> static SIMDINLINE uint32_t SIMDCALL movemask_ps(Float a)
> {
> -__mmask16 m = _mm512_test_epi32_mask(castps_si(a), 
> set1_epi32(0x800));
> +__mmask16 m = _mm512_test_epi32_mask(castps_si(a), 
> set1_epi32(0x8000));
> return static_cast(m);
> }
> 
> -- 
> 2.14.1
> 
> ___
> mesa-dev mailing list
> mesa-dev@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev

___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev