Re: [Mesa-dev] [PATCH] vulkan/wsi/wayland: fix leaks

2018-04-03 Thread Daniel Stone
Hi James,

On 30 March 2018 at 16:45, James Legg  wrote:
> Fixes: bfa22266cd vulkan/wsi/wayland: Add support for zwp_dmabuf
> CC: Daniel Stone 
> CC: Jason Ekstrand 

Wow, the cleanup hunk must have been lost in a rebase somewhere. :( At
least, I think I remember writing it.

Thanks a lot for the patch! I've merged it to master now, and it
should hopefully appear in stable releases too.

Cheers,
Daniel
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev


[Mesa-dev] [PATCH] vulkan/wsi/wayland: fix leaks

2018-03-30 Thread James Legg
Fixes: bfa22266cd vulkan/wsi/wayland: Add support for zwp_dmabuf
CC: Daniel Stone 
CC: Jason Ekstrand 
---
 src/vulkan/wsi/wsi_common_wayland.c | 4 
 1 file changed, 4 insertions(+)

diff --git a/src/vulkan/wsi/wsi_common_wayland.c 
b/src/vulkan/wsi/wsi_common_wayland.c
index d36947bc29..ec38a4e578 100644
--- a/src/vulkan/wsi/wsi_common_wayland.c
+++ b/src/vulkan/wsi/wsi_common_wayland.c
@@ -317,8 +317,12 @@ wsi_wl_display_finish(struct wsi_wl_display *display)
assert(display->refcount == 0);
 
u_vector_finish(>formats);
+   u_vector_finish(>modifiers.argb);
+   u_vector_finish(>modifiers.xrgb);
if (display->drm)
   wl_drm_destroy(display->drm);
+   if (display->dmabuf)
+  zwp_linux_dmabuf_v1_destroy(display->dmabuf);
if (display->wl_display_wrapper)
   wl_proxy_wrapper_destroy(display->wl_display_wrapper);
if (display->queue)
-- 
2.14.3

___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev