Re: [Mesa-dev] [PATCH 0/2] GL_ARB_program_interface_query
On 02/17/2015 10:23 AM, Matt Turner wrote: > On Tue, Feb 17, 2015 at 3:27 AM, Tapani Pälli wrote: >> Here is a skeleton for the GL_ARB_program_interface_query API functions. >> Adding the enum values makes it possible to start introducing changes in >> the current shader query functions using these values. >> >> Plan is to build a resource list during program linking which contains >> pointers to the required data. First refactor matching existing query >> functions to use resource list and then introduce new api functionality. > > We usually only commit "vertical slices" of functionality -- i.e., > whole implementations of a single feature. > > Should we commit these two patches as is? Is this feature different > than most others? It's probably okay to update GL3.txt. :) We should wait to land the other patch until there's at least some meat behind it. GL_ARB_program_interface_query is one of those extensions that is going to be "a lot of typing." It will be much like DSA in that respect. To save rebase woes, I think it will be okay to land some parts of it before other parts are ready. > ___ > mesa-dev mailing list > mesa-dev@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/mesa-dev ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
Re: [Mesa-dev] [PATCH 0/2] GL_ARB_program_interface_query
On 02/17/2015 08:23 PM, Matt Turner wrote: On Tue, Feb 17, 2015 at 3:27 AM, Tapani Pälli wrote: Here is a skeleton for the GL_ARB_program_interface_query API functions. Adding the enum values makes it possible to start introducing changes in the current shader query functions using these values. Plan is to build a resource list during program linking which contains pointers to the required data. First refactor matching existing query functions to use resource list and then introduce new api functionality. We usually only commit "vertical slices" of functionality -- i.e., whole implementations of a single feature. Should we commit these two patches as is? Is this feature different than most others? Not really that different. I'm hoping to introduce most of the implementation as set of new functionality under existing query functions before implementing the actual extension though so this patch will stay as it is. But it's fine for me, I can send this patch later when I have ready patches that take the new enum values in to use which will justify its existence. // Tapani ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
Re: [Mesa-dev] [PATCH 0/2] GL_ARB_program_interface_query
On Tue, Feb 17, 2015 at 3:27 AM, Tapani Pälli wrote: > Here is a skeleton for the GL_ARB_program_interface_query API functions. > Adding the enum values makes it possible to start introducing changes in > the current shader query functions using these values. > > Plan is to build a resource list during program linking which contains > pointers to the required data. First refactor matching existing query > functions to use resource list and then introduce new api functionality. We usually only commit "vertical slices" of functionality -- i.e., whole implementations of a single feature. Should we commit these two patches as is? Is this feature different than most others? ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
[Mesa-dev] [PATCH 0/2] GL_ARB_program_interface_query
Hi; Here is a skeleton for the GL_ARB_program_interface_query API functions. Adding the enum values makes it possible to start introducing changes in the current shader query functions using these values. Plan is to build a resource list during program linking which contains pointers to the required data. First refactor matching existing query functions to use resource list and then introduce new api functionality. Tapani Pälli (2): glapi: add GL_ARB_program_interface_query skeleton docs: update GL3.txt GL_ARB_program_interface_query state docs/GL3.txt | 4 +- src/mapi/glapi/gen/ARB_program_interface_query.xml | 109 + src/mapi/glapi/gen/gl_API.xml | 2 + src/mapi/glapi/gen/gl_genexec.py | 1 + src/mesa/Makefile.sources | 2 + src/mesa/main/program_resource.c | 70 + src/mesa/main/program_resource.h | 59 +++ 7 files changed, 245 insertions(+), 2 deletions(-) create mode 100644 src/mapi/glapi/gen/ARB_program_interface_query.xml create mode 100644 src/mesa/main/program_resource.c create mode 100644 src/mesa/main/program_resource.h -- 2.1.0 ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
