Re: [Mesa-dev] [PATCH 0/2] fix load of unpacked double vector input varyings

2016-06-01 Thread Samuel Iglesias Gonsálvez 


On 02/06/16 07:43, Timothy Arceri wrote:
> On Thu, 2016-06-02 at 07:22 +0200, Samuel Iglesias Gonsálvez wrote:
>> On 26/05/16 07:56, Samuel Iglesias Gonsálvez wrote:
>>>
>>> Hello,
>>>
>>> Timothy found that tests with unpacked double vector input varyings
>>> were failing in i965 driver. For example, this is happening when
>>> using explicit locations because Mesa disables varying packing for
>>> that case.
>>>
>>> These patches fix the following piglit test:
>>>
>>> spec/arb_gpu_shader_fp64/execution/vs-fs-explicit-locations
>>>
>>> Samuel Iglesias Gonsálvez (2):
>>>   i965/fs: fix offset when loading double vector input varyings
>>>   i965/fs: fix FS_OPCODE_CINTERP for unpacked double input varyings
>>>
>> These patches have a Tested-by (Thanks Timothy!) but they are still
>> unreviewed. Can someone take a look at them?
>>
>> Also, this patch [0] is still unreviewed.
> 
> If no one else takes a look at them over the next few days feel free to
> add my r-b to all three for what its worth they look ok to me.
> 
> Also don't forget to add tags for 12.0 stable before pushing.
> 

Sure :)

Thanks a lot!

Sam

> 
>>
>> Thanks,
>>
>> Sam
>>
>> [0] https://lists.freedesktop.org/archives/mesa-dev/2016-May/118759.h
>> tml
>>
>>
>>>
>>>  src/mesa/drivers/dri/i965/brw_fs.cpp | 13 -
>>>  src/mesa/drivers/dri/i965/brw_fs_nir.cpp | 22
>>> +-
>>>  2 files changed, 33 insertions(+), 2 deletions(-)
>>>
>> ___
>> mesa-dev mailing list
>> mesa-dev@lists.freedesktop.org
>> https://lists.freedesktop.org/mailman/listinfo/mesa-dev
> 



signature.asc
Description: OpenPGP digital signature
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 0/2] fix load of unpacked double vector input varyings

2016-06-01 Thread Timothy Arceri 
On Thu, 2016-06-02 at 07:22 +0200, Samuel Iglesias Gonsálvez wrote:
> On 26/05/16 07:56, Samuel Iglesias Gonsálvez wrote:
> > 
> > Hello,
> > 
> > Timothy found that tests with unpacked double vector input varyings
> > were failing in i965 driver. For example, this is happening when
> > using explicit locations because Mesa disables varying packing for
> > that case.
> > 
> > These patches fix the following piglit test:
> > 
> > spec/arb_gpu_shader_fp64/execution/vs-fs-explicit-locations
> > 
> > Samuel Iglesias Gonsálvez (2):
> >   i965/fs: fix offset when loading double vector input varyings
> >   i965/fs: fix FS_OPCODE_CINTERP for unpacked double input varyings
> > 
> These patches have a Tested-by (Thanks Timothy!) but they are still
> unreviewed. Can someone take a look at them?
> 
> Also, this patch [0] is still unreviewed.

If no one else takes a look at them over the next few days feel free to
add my r-b to all three for what its worth they look ok to me.

Also don't forget to add tags for 12.0 stable before pushing.


> 
> Thanks,
> 
> Sam
> 
> [0] https://lists.freedesktop.org/archives/mesa-dev/2016-May/118759.h
> tml
> 
> 
> > 
> >  src/mesa/drivers/dri/i965/brw_fs.cpp | 13 -
> >  src/mesa/drivers/dri/i965/brw_fs_nir.cpp | 22
> > +-
> >  2 files changed, 33 insertions(+), 2 deletions(-)
> > 
> ___
> mesa-dev mailing list
> mesa-dev@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 0/2] fix load of unpacked double vector input varyings

2016-06-01 Thread Samuel Iglesias Gonsálvez 
On 26/05/16 07:56, Samuel Iglesias Gonsálvez wrote:
> Hello,
> 
> Timothy found that tests with unpacked double vector input varyings
> were failing in i965 driver. For example, this is happening when
> using explicit locations because Mesa disables varying packing for
> that case.
> 
> These patches fix the following piglit test:
> 
> spec/arb_gpu_shader_fp64/execution/vs-fs-explicit-locations
> 
> Samuel Iglesias Gonsálvez (2):
>   i965/fs: fix offset when loading double vector input varyings
>   i965/fs: fix FS_OPCODE_CINTERP for unpacked double input varyings
> 

These patches have a Tested-by (Thanks Timothy!) but they are still
unreviewed. Can someone take a look at them?

Also, this patch [0] is still unreviewed.

Thanks,

Sam

[0] https://lists.freedesktop.org/archives/mesa-dev/2016-May/118759.html


>  src/mesa/drivers/dri/i965/brw_fs.cpp | 13 -
>  src/mesa/drivers/dri/i965/brw_fs_nir.cpp | 22 +-
>  2 files changed, 33 insertions(+), 2 deletions(-)
> 



signature.asc
Description: OpenPGP digital signature
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 0/2] fix load of unpacked double vector input varyings

2016-05-31 Thread Samuel Iglesias Gonsálvez 


On 31/05/16 02:26, Timothy Arceri wrote:
> On Mon, 2016-05-30 at 15:46 +0200, Samuel Iglesias Gonsálvez wrote:
>>
>> On 27/05/16 08:39, Samuel Iglesias Gonsálvez wrote:
>>>
>>>
>>>
>>> On 26/05/16 09:46, Timothy Arceri wrote:

 On Thu, 2016-05-26 at 17:44 +1000, Timothy Arceri wrote:
>
> On Thu, 2016-05-26 at 07:56 +0200, Samuel Iglesias Gonsálvez
> wrote:
>>
>>
>> Hello,
>>
>> Timothy found that tests with unpacked double vector input
>> varyings
>> were failing in i965 driver. For example, this is happening
>> when
>> using explicit locations because Mesa disables varying
>> packing for
>> that case.
>>
>> These patches fix the following piglit test:
>>
>> spec/arb_gpu_shader_fp64/execution/vs-fs-explicit-locations
>>
>> Samuel Iglesias Gonsálvez (2):
>>   i965/fs: fix offset when loading double vector input
>> varyings
>>   i965/fs: fix FS_OPCODE_CINTERP for unpacked double input
>> varyings
>>
>>  src/mesa/drivers/dri/i965/brw_fs.cpp | 13 -
>>  src/mesa/drivers/dri/i965/brw_fs_nir.cpp | 22
>> +-
>>  2 files changed, 33 insertions(+), 2 deletions(-)
>>
> These are both:
>
> Tested-by: Timothy Arceri 
>
> The logic looks ok to me also, but you probably want someone
> more familiar with the backend to take a quick look also.
 Forgot to ask. Did you also check the other stages work as
 expected
 with explicit locations?

>>> I did not check them. I am going to do it know and send patches if
>>> needed.
>>>
>> I needed to fix Geometry shaders too. I have sent a patch for it.
>>
>> Sam
> 
> Thanks Sam. Can you also send a piglit test since there are no test
> suites that seem to currently test this.
> 

Done:

https://lists.freedesktop.org/archives/piglit/2016-May/019888.html

Sam

> Thanks,
> Tim
> 
>>
>>>
>>> Thanks,
>>>
>>> Sam
>>>
>> ___
>> mesa-dev mailing list
>> mesa-dev@lists.freedesktop.org
>> https://lists.freedesktop.org/mailman/listinfo/mesa-dev
> 



signature.asc
Description: OpenPGP digital signature
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 0/2] fix load of unpacked double vector input varyings

2016-05-30 Thread Timothy Arceri 
On Mon, 2016-05-30 at 15:46 +0200, Samuel Iglesias Gonsálvez wrote:
> 
> On 27/05/16 08:39, Samuel Iglesias Gonsálvez wrote:
> > 
> > 
> > 
> > On 26/05/16 09:46, Timothy Arceri wrote:
> > > 
> > > On Thu, 2016-05-26 at 17:44 +1000, Timothy Arceri wrote:
> > > > 
> > > > On Thu, 2016-05-26 at 07:56 +0200, Samuel Iglesias Gonsálvez
> > > > wrote:
> > > > > 
> > > > > 
> > > > > Hello,
> > > > > 
> > > > > Timothy found that tests with unpacked double vector input
> > > > > varyings
> > > > > were failing in i965 driver. For example, this is happening
> > > > > when
> > > > > using explicit locations because Mesa disables varying
> > > > > packing for
> > > > > that case.
> > > > > 
> > > > > These patches fix the following piglit test:
> > > > > 
> > > > > spec/arb_gpu_shader_fp64/execution/vs-fs-explicit-locations
> > > > > 
> > > > > Samuel Iglesias Gonsálvez (2):
> > > > >   i965/fs: fix offset when loading double vector input
> > > > > varyings
> > > > >   i965/fs: fix FS_OPCODE_CINTERP for unpacked double input
> > > > > varyings
> > > > > 
> > > > >  src/mesa/drivers/dri/i965/brw_fs.cpp | 13 -
> > > > >  src/mesa/drivers/dri/i965/brw_fs_nir.cpp | 22
> > > > > +-
> > > > >  2 files changed, 33 insertions(+), 2 deletions(-)
> > > > > 
> > > > These are both:
> > > > 
> > > > Tested-by: Timothy Arceri 
> > > > 
> > > > The logic looks ok to me also, but you probably want someone
> > > > more familiar with the backend to take a quick look also.
> > > Forgot to ask. Did you also check the other stages work as
> > > expected
> > > with explicit locations?
> > > 
> > I did not check them. I am going to do it know and send patches if
> > needed.
> > 
> I needed to fix Geometry shaders too. I have sent a patch for it.
> 
> Sam

Thanks Sam. Can you also send a piglit test since there are no test
suites that seem to currently test this.

Thanks,
Tim

> 
> > 
> > Thanks,
> > 
> > Sam
> > 
> ___
> mesa-dev mailing list
> mesa-dev@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 0/2] fix load of unpacked double vector input varyings

2016-05-30 Thread Samuel Iglesias Gonsálvez 


On 27/05/16 08:39, Samuel Iglesias Gonsálvez wrote:
> 
> 
> On 26/05/16 09:46, Timothy Arceri wrote:
>> On Thu, 2016-05-26 at 17:44 +1000, Timothy Arceri wrote:
>>> On Thu, 2016-05-26 at 07:56 +0200, Samuel Iglesias Gonsálvez wrote:

 Hello,

 Timothy found that tests with unpacked double vector input varyings
 were failing in i965 driver. For example, this is happening when
 using explicit locations because Mesa disables varying packing for
 that case.

 These patches fix the following piglit test:

 spec/arb_gpu_shader_fp64/execution/vs-fs-explicit-locations

 Samuel Iglesias Gonsálvez (2):
   i965/fs: fix offset when loading double vector input varyings
   i965/fs: fix FS_OPCODE_CINTERP for unpacked double input varyings

  src/mesa/drivers/dri/i965/brw_fs.cpp | 13 -
  src/mesa/drivers/dri/i965/brw_fs_nir.cpp | 22
 +-
  2 files changed, 33 insertions(+), 2 deletions(-)

>>> These are both:
>>>
>>> Tested-by: Timothy Arceri 
>>>
>>> The logic looks ok to me also, but you probably want someone
>>> more familiar with the backend to take a quick look also.
>>
>> Forgot to ask. Did you also check the other stages work as expected
>> with explicit locations?
>>
> 
> I did not check them. I am going to do it know and send patches if needed.
> 

I needed to fix Geometry shaders too. I have sent a patch for it.

Sam

> Thanks,
> 
> Sam
> 



signature.asc
Description: OpenPGP digital signature
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 0/2] fix load of unpacked double vector input varyings

2016-05-27 Thread Samuel Iglesias Gonsálvez 


On 26/05/16 09:46, Timothy Arceri wrote:
> On Thu, 2016-05-26 at 17:44 +1000, Timothy Arceri wrote:
>> On Thu, 2016-05-26 at 07:56 +0200, Samuel Iglesias Gonsálvez wrote:
>>>
>>> Hello,
>>>
>>> Timothy found that tests with unpacked double vector input varyings
>>> were failing in i965 driver. For example, this is happening when
>>> using explicit locations because Mesa disables varying packing for
>>> that case.
>>>
>>> These patches fix the following piglit test:
>>>
>>> spec/arb_gpu_shader_fp64/execution/vs-fs-explicit-locations
>>>
>>> Samuel Iglesias Gonsálvez (2):
>>>   i965/fs: fix offset when loading double vector input varyings
>>>   i965/fs: fix FS_OPCODE_CINTERP for unpacked double input varyings
>>>
>>>  src/mesa/drivers/dri/i965/brw_fs.cpp | 13 -
>>>  src/mesa/drivers/dri/i965/brw_fs_nir.cpp | 22
>>> +-
>>>  2 files changed, 33 insertions(+), 2 deletions(-)
>>>
>> These are both:
>>
>> Tested-by: Timothy Arceri 
>>
>> The logic looks ok to me also, but you probably want someone
>> more familiar with the backend to take a quick look also.
> 
> Forgot to ask. Did you also check the other stages work as expected
> with explicit locations?
> 

I did not check them. I am going to do it know and send patches if needed.

Thanks,

Sam



signature.asc
Description: OpenPGP digital signature
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 0/2] fix load of unpacked double vector input varyings

2016-05-26 Thread Timothy Arceri 
On Thu, 2016-05-26 at 17:44 +1000, Timothy Arceri wrote:
> On Thu, 2016-05-26 at 07:56 +0200, Samuel Iglesias Gonsálvez wrote:
> > 
> > Hello,
> > 
> > Timothy found that tests with unpacked double vector input varyings
> > were failing in i965 driver. For example, this is happening when
> > using explicit locations because Mesa disables varying packing for
> > that case.
> > 
> > These patches fix the following piglit test:
> > 
> > spec/arb_gpu_shader_fp64/execution/vs-fs-explicit-locations
> > 
> > Samuel Iglesias Gonsálvez (2):
> >   i965/fs: fix offset when loading double vector input varyings
> >   i965/fs: fix FS_OPCODE_CINTERP for unpacked double input varyings
> > 
> >  src/mesa/drivers/dri/i965/brw_fs.cpp | 13 -
> >  src/mesa/drivers/dri/i965/brw_fs_nir.cpp | 22
> > +-
> >  2 files changed, 33 insertions(+), 2 deletions(-)
> > 
> These are both:
> 
> Tested-by: Timothy Arceri 
> 
> The logic looks ok to me also, but you probably want someone
> more familiar with the backend to take a quick look also.

Forgot to ask. Did you also check the other stages work as expected
with explicit locations?
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 0/2] fix load of unpacked double vector input varyings

2016-05-26 Thread Timothy Arceri 
On Thu, 2016-05-26 at 07:56 +0200, Samuel Iglesias Gonsálvez wrote:
> Hello,
> 
> Timothy found that tests with unpacked double vector input varyings
> were failing in i965 driver. For example, this is happening when
> using explicit locations because Mesa disables varying packing for
> that case.
> 
> These patches fix the following piglit test:
> 
> spec/arb_gpu_shader_fp64/execution/vs-fs-explicit-locations
> 
> Samuel Iglesias Gonsálvez (2):
>   i965/fs: fix offset when loading double vector input varyings
>   i965/fs: fix FS_OPCODE_CINTERP for unpacked double input varyings
> 
>  src/mesa/drivers/dri/i965/brw_fs.cpp | 13 -
>  src/mesa/drivers/dri/i965/brw_fs_nir.cpp | 22 +-
>  2 files changed, 33 insertions(+), 2 deletions(-)
> 

These are both:

Tested-by: Timothy Arceri 

The logic looks ok to me also, but you probably want someone
more familiar with the backend to take a quick look also.
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [PATCH 0/2] fix load of unpacked double vector input varyings

2016-05-25 Thread Samuel Iglesias Gonsálvez 
Hello,

Timothy found that tests with unpacked double vector input varyings
were failing in i965 driver. For example, this is happening when
using explicit locations because Mesa disables varying packing for
that case.

These patches fix the following piglit test:

spec/arb_gpu_shader_fp64/execution/vs-fs-explicit-locations

Samuel Iglesias Gonsálvez (2):
  i965/fs: fix offset when loading double vector input varyings
  i965/fs: fix FS_OPCODE_CINTERP for unpacked double input varyings

 src/mesa/drivers/dri/i965/brw_fs.cpp | 13 -
 src/mesa/drivers/dri/i965/brw_fs_nir.cpp | 22 +-
 2 files changed, 33 insertions(+), 2 deletions(-)

-- 
2.8.1

___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev