[Mesa-dev] [PATCH 0/2] v5: Fix array overrun with too many uniforms

2014-02-27 Thread Petri Latvala
Fixing https://bugs.freedesktop.org/show_bug.cgi?id=71254 once again.

Rebased for current master, plumbing-class changes to patch 1/2. Fixed
one of the asserts in patch 2/2.

Full piglit run shows no regressions.

Petri Latvala (2):
  i965: Allocate vec4_visitor's uniform_size and uniform_vector_size
arrays dynamically.
  i965: Assert array index on access to vec4_visitor's arrays.

 src/mesa/drivers/dri/i965/brw_vec4.cpp |  2 ++
 src/mesa/drivers/dri/i965/brw_vec4.h   |  5 +++--
 src/mesa/drivers/dri/i965/brw_vec4_gs.c|  5 +
 src/mesa/drivers/dri/i965/brw_vec4_visitor.cpp | 17 +
 src/mesa/drivers/dri/i965/brw_vs.c |  8 
 5 files changed, 35 insertions(+), 2 deletions(-)

-- 
1.8.4.rc3

___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev


Re: [Mesa-dev] [PATCH 0/2] v5: Fix array overrun with too many uniforms

2014-02-28 Thread Ian Romanick

On 02/27/2014 06:15 AM, Petri Latvala wrote:

Fixing https://bugs.freedesktop.org/show_bug.cgi?id=71254 once again.

Rebased for current master, plumbing-class changes to patch 1/2. Fixed
one of the asserts in patch 2/2.

Full piglit run shows no regressions.

Petri Latvala (2):
   i965: Allocate vec4_visitor's uniform_size and uniform_vector_size
 arrays dynamically.
   i965: Assert array index on access to vec4_visitor's arrays.

  src/mesa/drivers/dri/i965/brw_vec4.cpp |  2 ++
  src/mesa/drivers/dri/i965/brw_vec4.h   |  5 +++--
  src/mesa/drivers/dri/i965/brw_vec4_gs.c|  5 +
  src/mesa/drivers/dri/i965/brw_vec4_visitor.cpp | 17 +
  src/mesa/drivers/dri/i965/brw_vs.c |  8 
  5 files changed, 35 insertions(+), 2 deletions(-)



Series is

Reviewed-by: Ian Romanick 

I've marked the first patch for the 10.1 branch.  I also made a trivial 
whitespace change in brw_vs.c.


I know Ken and Eric had comments about the earlier versions, so I'll 
give them a bit to respond to this one before I push.


___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev