Re: [Mesa-dev] [PATCH 0/3] various exec_list things
On Tue, Jul 8, 2014 at 12:20 PM, Connor Abbott wrote: > This series adds a couple things I need to exec_list for my work, and > does some cleanups made possible. Only compile tested on i965. > > Connor Abbott (3): > exec_list: add a prepend function > exec_list: add a function to count the size of a list > exec_list: make various places use the new get_size() method I fixed up a few small things and renamed get_size -> length and pushed these. Thanks! ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
Re: [Mesa-dev] [PATCH 0/3] various exec_list things
Well, if that's how things work then, for the series, : Reviewed-by: Thomas Helland 2014-07-08 23:07 GMT+02:00 Matt Turner : > On Tue, Jul 8, 2014 at 2:04 PM, Thomas Helland > wrote: > > I don't feel comfortable reviewing things > > on here quite yet, so you should > > probably get a reviewed-by by someone else. > > > > That being said this series LGTM. > > Feel free to give a Reviewed-by tag if the code looks correct to you. > It's up to other people to decide how much that tag means. :) > ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
Re: [Mesa-dev] [PATCH 0/3] various exec_list things
On Tue, Jul 8, 2014 at 2:04 PM, Thomas Helland wrote: > I don't feel comfortable reviewing things > on here quite yet, so you should > probably get a reviewed-by by someone else. > > That being said this series LGTM. Feel free to give a Reviewed-by tag if the code looks correct to you. It's up to other people to decide how much that tag means. :) ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
[Mesa-dev] [PATCH 0/3] various exec_list things
I don't feel comfortable reviewing things on here quite yet, so you should probably get a reviewed-by by someone else. That being said this series LGTM. ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
[Mesa-dev] [PATCH 0/3] various exec_list things
This series adds a couple things I need to exec_list for my work, and does some cleanups made possible. Only compile tested on i965. Connor Abbott (3): exec_list: add a prepend function exec_list: add a function to count the size of a list exec_list: make various places use the new get_size() method src/glsl/ast_to_hir.cpp| 4 +-- src/glsl/ir_reader.cpp | 7 ++-- src/glsl/list.h| 40 +- src/glsl/opt_function_inlining.cpp | 7 ++-- src/mesa/drivers/dri/i965/brw_fs.cpp | 5 +-- .../drivers/dri/i965/brw_fs_copy_propagation.cpp | 4 +-- src/mesa/program/ir_to_mesa.cpp| 5 +-- 7 files changed, 48 insertions(+), 24 deletions(-) -- 1.9.3 ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
