Re: [Mesa-dev] [PATCH 0/6] meson: fix gallium media target linkage
On 18 January 2018 at 19:36, Dylan Baker wrote: > Quoting Emil Velikov (2018-01-18 11:12:30) >> On 17 January 2018 at 18:34, Dylan Baker wrote: >> > The linkage of all of the gallium media targets is broken in various >> > ways in the meson build. This series should correct that by doing more >> > what the autotools build does. >> > >> Above all and slightly unrelated, can I ask you about the rather >> unusual gallium- prefix for vdpau and friends? >> Can we drop it, please? > > Since vdpau, nine, va, etc depend on gallium it makes sense to me to give them > gallium based names. *shrug* > If anything I'd keep gallium only where absolutely needed aka the classic/gallium DRI separation. We dropped it from --enable-gallium-llvm, --enable-glx does dri|xlib|gallium-xlib, and in reality we should have done so with osmesa. It also makes things odd, wrt the respective *-libs-path parts. Let's drop the prefix? Thanks Emil ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
Re: [Mesa-dev] [PATCH 0/6] meson: fix gallium media target linkage
Quoting Emil Velikov (2018-01-18 11:12:30) > On 17 January 2018 at 18:34, Dylan Baker wrote: > > The linkage of all of the gallium media targets is broken in various > > ways in the meson build. This series should correct that by doing more > > what the autotools build does. > > > Above all and slightly unrelated, can I ask you about the rather > unusual gallium- prefix for vdpau and friends? > Can we drop it, please? Since vdpau, nine, va, etc depend on gallium it makes sense to me to give them gallium based names. *shrug* > > AFAICT there are a few corner cases, plus patches tends to do a few > somewhat unrelated things. > Can you please wait up until tomorrow (have to run for the final bus > home in 5 mins) I'll share some tips making the build scripts shorter > and more robust. > > Obviously, the patches are suitable material after the branch point, > so please don't rush to get everything merged by tomorrow. > > Thanks > Emil signature.asc Description: signature ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
Re: [Mesa-dev] [PATCH 0/6] meson: fix gallium media target linkage
On 17 January 2018 at 18:34, Dylan Baker wrote: > The linkage of all of the gallium media targets is broken in various > ways in the meson build. This series should correct that by doing more > what the autotools build does. > Above all and slightly unrelated, can I ask you about the rather unusual gallium- prefix for vdpau and friends? Can we drop it, please? AFAICT there are a few corner cases, plus patches tends to do a few somewhat unrelated things. Can you please wait up until tomorrow (have to run for the final bus home in 5 mins) I'll share some tips making the build scripts shorter and more robust. Obviously, the patches are suitable material after the branch point, so please don't rush to get everything merged by tomorrow. Thanks Emil ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
[Mesa-dev] [PATCH 0/6] meson: fix gallium media target linkage
The linkage of all of the gallium media targets is broken in various ways in the meson build. This series should correct that by doing more what the autotools build does. Dylan Baker (6): meson: link dri3 xcb libs into vlwinsys instead of into each target meson: fix vdpau target linkage meson: fix va-api target linkage meson: Fix omx-bellagio target linkage meson: fix xa target linkage meson: fix xvmc target linkage meson.build | 10 -- src/gallium/auxiliary/meson.build| 7 ++- src/gallium/targets/omx-bellagio/meson.build | 18 -- src/gallium/targets/va/meson.build | 14 ++ src/gallium/targets/vdpau/meson.build| 16 src/gallium/targets/xa/meson.build | 16 src/gallium/targets/xvmc/meson.build | 18 -- 7 files changed, 64 insertions(+), 35 deletions(-) base-commit: d1833b8cd894a7682c53a7bd6ca2dcfb97c7776e -- git-series 0.9.1 ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
