Re: [Mesa-dev] [PATCH 0/7] [RFC] meson: build src/glx/windows

2017-11-28 Thread Eric Engestrom
On Monday, 2017-11-27 13:58:27 +, Jon Turney wrote:
> This series lets me build a mesa for Cygwin configured with:
> 
>  -Ddri-drivers=swrast -Dgallium-drivers= -Dplatforms=x11,surfaceless 
> -Dglx=dri -Dvulkan-drivers= 
> 
> I'm really not sure about (2/8), the autotools build does something totally 
> different...
> 
> Dylan Baker (2):
>   meson: fix generated source inclusion on macOS and Windows
>   meson: Don't build egl on macOS or Windows
> 
> Jon Turney (5):
>   meson: set windows glx defines
>   meson: set _GNU_SOURCE on cygwin
>   meson: don't require dri2proto for darwin or windows
>   meson: fix deps and underlinkage of libGL

all the above, ie. 1-4 & 6-7, are:
Reviewed-by: Eric Engestrom 

>   meson: build src/glx/windows

this one, ie. 5/7, with dylan's comments, is:
Acked-by: Eric Engestrom 

> 
>  meson.build | 19 +-
>  src/glx/meson.build | 26 ++--
>  src/glx/windows/meson.build | 48 
> +
>  src/mapi/glapi/meson.build  |  2 +-
>  4 files changed, 79 insertions(+), 16 deletions(-)
>  create mode 100644 src/glx/windows/meson.build
> 
> -- 
> 2.15.0
> 
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev


Re: [Mesa-dev] [PATCH 0/7] [RFC] meson: build src/glx/windows

2017-11-27 Thread Dylan Baker
I had a few comments on the "build src/glx/windows" patch, but the rest of the
patches are:
Reviewed-by: Dylan Baker 

Quoting Jon Turney (2017-11-27 05:58:27)
> This series lets me build a mesa for Cygwin configured with:
> 
>  -Ddri-drivers=swrast -Dgallium-drivers= -Dplatforms=x11,surfaceless 
> -Dglx=dri -Dvulkan-drivers= 
> 
> I'm really not sure about (2/8), the autotools build does something totally 
> different...
> 
> Dylan Baker (2):
>   meson: fix generated source inclusion on macOS and Windows
>   meson: Don't build egl on macOS or Windows
> 
> Jon Turney (5):
>   meson: set windows glx defines
>   meson: set _GNU_SOURCE on cygwin
>   meson: build src/glx/windows
>   meson: don't require dri2proto for darwin or windows
>   meson: fix deps and underlinkage of libGL
> 
>  meson.build | 19 +-
>  src/glx/meson.build | 26 ++--
>  src/glx/windows/meson.build | 48 
> +
>  src/mapi/glapi/meson.build  |  2 +-
>  4 files changed, 79 insertions(+), 16 deletions(-)
>  create mode 100644 src/glx/windows/meson.build
> 
> -- 
> 2.15.0
> 


signature.asc
Description: signature
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev


[Mesa-dev] [PATCH 0/7] [RFC] meson: build src/glx/windows

2017-11-27 Thread Jon Turney
This series lets me build a mesa for Cygwin configured with:

 -Ddri-drivers=swrast -Dgallium-drivers= -Dplatforms=x11,surfaceless -Dglx=dri 
-Dvulkan-drivers= 

I'm really not sure about (2/8), the autotools build does something totally 
different...

Dylan Baker (2):
  meson: fix generated source inclusion on macOS and Windows
  meson: Don't build egl on macOS or Windows

Jon Turney (5):
  meson: set windows glx defines
  meson: set _GNU_SOURCE on cygwin
  meson: build src/glx/windows
  meson: don't require dri2proto for darwin or windows
  meson: fix deps and underlinkage of libGL

 meson.build | 19 +-
 src/glx/meson.build | 26 ++--
 src/glx/windows/meson.build | 48 +
 src/mapi/glapi/meson.build  |  2 +-
 4 files changed, 79 insertions(+), 16 deletions(-)
 create mode 100644 src/glx/windows/meson.build

-- 
2.15.0

___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev