[Mesa-dev] [PATCH 0/9] i915: Gen2 texturing fixes and a few random patches
From: Ville Syrjälä I had a few rainy days during my summer vacation so I decided to fix a chromnium-bsu texturing problem that was nagging me for a while now. I ended up fixing a few other things too that I spotted mostly from reading the code. The aniso vs. mip filter thing probably comes down to personal preference, but at least to me aniso+mip nearest looks better than trilinear. At least when playing the old classic glaxium :) I have no idea if the scissor patch makes any difference anywhere. I just caught the note in the spec and noticed we're doing it in the opposite order. The rest should be pretty clear. Ville Syrjälä (9): i915: Only use TEXCOORDTYPE_VECTOR with cube maps on gen2 i915: Fix GL_DOT3_RGBA a bit i915: Use L8A8 instead of I8 to simulate A8 on gen2 i915: Override mip filter to nearest with aniso i915: Accept GL_DEPTH_STENCIL GL_DEPTH_COMPONENT formats for renderbuffers i915: Kill intel_context::hw_stencil i915: Protect macro argument for TEXTURE_SET() i915: Don't call _mesa_meta_glsl_Clear() on gen2 i915: Emit 3DSTATE_SCISSOR_RECTANGLE_0 before 3DSTATE_SCISSOR_ENABLE src/mesa/drivers/dri/i915/i830_context.h| 8 +++--- src/mesa/drivers/dri/i915/i830_reg.h| 2 +- src/mesa/drivers/dri/i915/i830_state.c | 4 +-- src/mesa/drivers/dri/i915/i830_texblend.c | 5 ++-- src/mesa/drivers/dri/i915/i830_texstate.c | 4 +-- src/mesa/drivers/dri/i915/i830_vtbl.c | 39 +++-- src/mesa/drivers/dri/i915/i915_context.c| 3 ++- src/mesa/drivers/dri/i915/i915_context.h| 8 +++--- src/mesa/drivers/dri/i915/i915_state.c | 4 +-- src/mesa/drivers/dri/i915/i915_vtbl.c | 8 +++--- src/mesa/drivers/dri/i915/intel_clear.c | 2 +- src/mesa/drivers/dri/i915/intel_context.c | 1 - src/mesa/drivers/dri/i915/intel_context.h | 1 - src/mesa/drivers/dri/i915/intel_fbo.c | 9 +++ src/mesa/drivers/dri/i915/intel_tex_image.c | 22 15 files changed, 76 insertions(+), 44 deletions(-) -- 1.8.5.5 ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
Re: [Mesa-dev] [PATCH 0/9] i915: Gen2 texturing fixes and a few random patches
On Wed, Aug 06, 2014 at 09:56:30PM +0300, ville.syrj...@linux.intel.com wrote: > From: Ville Syrjälä > > I had a few rainy days during my summer vacation so I decided to fix a > chromnium-bsu texturing problem that was nagging me for a while now. I > ended up fixing a few other things too that I spotted mostly from reading > the code. > > The aniso vs. mip filter thing probably comes down to personal preference, > but at least to me aniso+mip nearest looks better than trilinear. At least > when playing the old classic glaxium :) > > I have no idea if the scissor patch makes any difference anywhere. I just > caught the note in the spec and noticed we're doing it in the opposite order. > > The rest should be pretty clear. > > Ville Syrjälä (9): > i915: Fix GL_DOT3_RGBA a bit > i915: Use L8A8 instead of I8 to simulate A8 on gen2 > i915: Override mip filter to nearest with aniso > i915: Accept GL_DEPTH_STENCIL GL_DEPTH_COMPONENT formats for > renderbuffers > i915: Kill intel_context::hw_stencil > i915: Protect macro argument for TEXTURE_SET() > i915: Don't call _mesa_meta_glsl_Clear() on gen2 > i915: Emit 3DSTATE_SCISSOR_RECTANGLE_0 before 3DSTATE_SCISSOR_ENABLE I finally got around to pushing the reviewed patches from this series. Thanks for the reviews. > i915: Only use TEXCOORDTYPE_VECTOR with cube maps on gen2 This one is still lacking a review though, and it's actually for the original bug I set out to fix. So I'd appreaciate if someone can take a look at the patch. There's also this gen3 specific patch I did that would like to get reviewed: http://patchwork.freedesktop.org/patch/31661/ I also have to confess to having a decent pile of more vertex related i915 patches sitting in a branch, one which actually makes glxgears render correctly on gen2 ;) I'd like to post those too but I wanted to get the old stuff out of the way first... -- Ville Syrjälä rntel OTC ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
