Re: [Mesa-dev] [PATCH 00/10] Rework of pb_cache_manager for removal of radeon_winsys_cs_handle

[Nicolai Hähnle]

On 06.12.2015 19:00, Marek Olšák wrote:

This series addresses the weirdness in radeon drivers that every buffer has 2 
handles:
- pb_buffer (== pb_cache_buffer)
- radeon_winsys_cs_handle (winsys-specific pb_buffer)

The inefficiency of converting pb_cache_buffer into the winsys-specific buffer 
made me introduce radeon_winsys_cs_handle a few years ago, which has been used 
for almost everything (map/unmap/command submission/etc.) and pb_buffer has 
only held the reference keeping the buffer alive.

Now it's time to do this right.

This series moves the pb_cache_manager logic into an independent module 
"pb_cache". Next, all dependencies on pb_manager are removed from both winsyses 
and the new module is used instead. The result is that pb_buffer is equal to 
radeon_winsys_cs_handle, and the latter can be removed.


Very nice! I only have some comments on #1 and an identical remark about 
#3 & #9 (those two patches are also a bit awkward because they combine 
several seemingly unrelated changes, though I don't mind *that* much).


Modulo the comments mentioned above, the series is

Reviewed-by: Nicolai Hähnle 

Cheers,
Nicolai

Please review.


Marek
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev


___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 00/10] Rework of pb_cache_manager for removal of radeon_winsys_cs_handle

[eocallaghan]

On 2015-12-07 11:00, Marek Olšák wrote:

Hi,

This series addresses the weirdness in radeon drivers that every
buffer has 2 handles:
- pb_buffer (== pb_cache_buffer)
- radeon_winsys_cs_handle (winsys-specific pb_buffer)

The inefficiency of converting pb_cache_buffer into the
winsys-specific buffer made me introduce radeon_winsys_cs_handle a few
years ago, which has been used for almost everything
(map/unmap/command submission/etc.) and pb_buffer has only held the
reference keeping the buffer alive.

Now it's time to do this right.

This series moves the pb_cache_manager logic into an independent
module "pb_cache". Next, all dependencies on pb_manager are removed
from both winsyses and the new module is used instead. The result is
that pb_buffer is equal to radeon_winsys_cs_handle, and the latter can
be removed.

Please review.

Marek
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev


Nice cleanup.

This series is,

Reviewed-by: Edward O'Callaghan 
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 00/10] Rework of pb_cache_manager for removal of radeon_winsys_cs_handle

[Michel Dänzer]

On 07.12.2015 09:00, Marek Olšák wrote:
> Hi,
> 
> This series addresses the weirdness in radeon drivers that every buffer has 2 
> handles:
> - pb_buffer (== pb_cache_buffer)
> - radeon_winsys_cs_handle (winsys-specific pb_buffer)
> 
> The inefficiency of converting pb_cache_buffer into the winsys-specific 
> buffer made me introduce radeon_winsys_cs_handle a few years ago, which has 
> been used for almost everything (map/unmap/command submission/etc.) and 
> pb_buffer has only held the reference keeping the buffer alive.
> 
> Now it's time to do this right.
> 
> This series moves the pb_cache_manager logic into an independent module 
> "pb_cache". Next, all dependencies on pb_manager are removed from both 
> winsyses and the new module is used instead. The result is that pb_buffer is 
> equal to radeon_winsys_cs_handle, and the latter can be removed.
> 
> Please review.

Patches 1 & 2 are

Acked-by: Michel Dänzer 

(José or somebody should probably take a look at these)


Patches 3-10 are

Reviewed-by: Michel Dänzer 


-- 
Earthling Michel Dänzer   |   http://www.amd.com
Libre software enthusiast | Mesa and X developer
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [PATCH 00/10] Rework of pb_cache_manager for removal of radeon_winsys_cs_handle

[Marek Olšák]

Hi,

This series addresses the weirdness in radeon drivers that every buffer has 2 
handles:
- pb_buffer (== pb_cache_buffer)
- radeon_winsys_cs_handle (winsys-specific pb_buffer)

The inefficiency of converting pb_cache_buffer into the winsys-specific buffer 
made me introduce radeon_winsys_cs_handle a few years ago, which has been used 
for almost everything (map/unmap/command submission/etc.) and pb_buffer has 
only held the reference keeping the buffer alive.

Now it's time to do this right.

This series moves the pb_cache_manager logic into an independent module 
"pb_cache". Next, all dependencies on pb_manager are removed from both winsyses 
and the new module is used instead. The result is that pb_buffer is equal to 
radeon_winsys_cs_handle, and the latter can be removed.

Please review.

Marek
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev