Re: [Mesa-dev] [PATCH 00/11] Make more use of state already tracked in the VAO.

2016-07-26 Thread Mathias Fröhlich
Hi,

This should have been some preparing cleanup for some patches doing less work in
the fast draw path.

I have updated the comment as requested and now resent with the new comment.
And I believe that _mesa_all_varyings_in_vbos is equivalent
to vbo_all_varyings_in_vbos but working on a VAO. Else we would get a
change in behavior.

So: Ping.

Thanks

Mathias

On Friday, June 17, 2016 20:03:52 mathias.froehl...@gmx.net wrote:
> From: Mathias Fröhlich 
> 
> Hi,
> 
> The first two patches fix a bug in tracking the VAO internal
> state. The majority of the changeset makes more use of the
> state currently tracked in the VAO and transitions to use
> more of the first order information found in the VAO instead
> of relying on the gl_client_array members that mirror the
> VAO fields. The last two patches rip out members from
> gl_client_array that are set but no longer used.
> 
> Please review,
> 
> Thanks
> 
> Mathias
> 
> 
> Mathias Fröhlich (11):
>   mesa: Add flush_vertices argument to _mesa_bind_vertex_buffer.
>   mesa: Unbind deleted vbo using _mesa_bind_vertex_buffer.
>   mesa: Implement _mesa_all_varyings_in_vbos.
>   vbo: Walk the VAO to see if all varyings are in vbos.
>   vbo: Walk the VAO to check for mapped buffers.
>   mesa: Walk the VAO in _mesa_print_arrays.
>   vbo: Walk the VAO in print_draw_arrays.
>   vbo: Walk the VAO in check_array_data.
>   vbo: Use the VAO array enabled flags in vbo_exec_array.
>   mesa: Remove set but not used gl_client_array::Enabled.
>   mesa: Remove set but not used gl_client_array::Stride.
> 
>  src/mesa/drivers/common/meta.c   |  16 ++--
>  src/mesa/main/arrayobj.c |  35 
>  src/mesa/main/arrayobj.h |   4 +
>  src/mesa/main/bufferobj.c|  11 ++-
>  src/mesa/main/mtypes.h   |   2 -
>  src/mesa/main/varray.c   |  70 +++
>  src/mesa/main/varray.h   |   4 +-
>  src/mesa/state_tracker/st_cb_rasterpos.c |   2 -
>  src/mesa/vbo/vbo_context.c   |   2 -
>  src/mesa/vbo/vbo_exec_array.c| 141 
> ++-
>  src/mesa/vbo/vbo_exec_draw.c |   2 -
>  src/mesa/vbo/vbo_save_draw.c |   2 -
>  src/mesa/vbo/vbo_split_copy.c|   8 +-
>  13 files changed, 171 insertions(+), 128 deletions(-)
> 
> 

___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev


[Mesa-dev] [PATCH 00/11] Make more use of state already tracked in the VAO.

2016-06-17 Thread Mathias . Froehlich
From: Mathias Fröhlich 

Hi,

The first two patches fix a bug in tracking the VAO internal
state. The majority of the changeset makes more use of the
state currently tracked in the VAO and transitions to use
more of the first order information found in the VAO instead
of relying on the gl_client_array members that mirror the
VAO fields. The last two patches rip out members from
gl_client_array that are set but no longer used.

Please review,

Thanks

Mathias


Mathias Fröhlich (11):
  mesa: Add flush_vertices argument to _mesa_bind_vertex_buffer.
  mesa: Unbind deleted vbo using _mesa_bind_vertex_buffer.
  mesa: Implement _mesa_all_varyings_in_vbos.
  vbo: Walk the VAO to see if all varyings are in vbos.
  vbo: Walk the VAO to check for mapped buffers.
  mesa: Walk the VAO in _mesa_print_arrays.
  vbo: Walk the VAO in print_draw_arrays.
  vbo: Walk the VAO in check_array_data.
  vbo: Use the VAO array enabled flags in vbo_exec_array.
  mesa: Remove set but not used gl_client_array::Enabled.
  mesa: Remove set but not used gl_client_array::Stride.

 src/mesa/drivers/common/meta.c   |  16 ++--
 src/mesa/main/arrayobj.c |  35 
 src/mesa/main/arrayobj.h |   4 +
 src/mesa/main/bufferobj.c|  11 ++-
 src/mesa/main/mtypes.h   |   2 -
 src/mesa/main/varray.c   |  70 +++
 src/mesa/main/varray.h   |   4 +-
 src/mesa/state_tracker/st_cb_rasterpos.c |   2 -
 src/mesa/vbo/vbo_context.c   |   2 -
 src/mesa/vbo/vbo_exec_array.c| 141 ++-
 src/mesa/vbo/vbo_exec_draw.c |   2 -
 src/mesa/vbo/vbo_save_draw.c |   2 -
 src/mesa/vbo/vbo_split_copy.c|   8 +-
 13 files changed, 171 insertions(+), 128 deletions(-)

-- 
2.5.5

___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev