Re: [Mesa-dev] [PATCH 00/12] Android build cleanup/fixes

2017-05-01 Thread Emil Velikov 
On 27 April 2017 at 20:43, Rob Herring  wrote:
> This is a series of clean-ups and fixes to the Android build files.
> Overall, it removes a lot of the if conditions that aren't necessary for
> normal builds and also enables "mmma external/mesa3d" to build
> everything for easier build testing.
>
> This fixes LLVM enabled builds on master though that requires changes
> to LLVM as well. In the process, LLVM builds with Lollipop are dropped
> as L doesn't have the minimum LLVM version for several drivers. Also,
> android-x86 L support is using mesa 11.0.
>
> I've only tested against AOSP master so far.
>
Hats off for the cleanups and fixes Rob - great work.

Hope my "please add a comment" suggestions did not come a bit much.
Just trying to avoid another confusion like the one in 12/12 :-)

-Emil
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 00/12] Android build cleanup/fixes

2017-05-01 Thread Mauro Rossi 
2017-05-01 3:03 GMT+02:00 Mauro Rossi :

>
>
> 2017-04-28 4:55 GMT+02:00 Chih-Wei Huang :
>
>> 2017-04-28 3:43 GMT+08:00 Rob Herring :
>> > This is a series of clean-ups and fixes to the Android build files.
>> > Overall, it removes a lot of the if conditions that aren't necessary for
>> > normal builds and also enables "mmma external/mesa3d" to build
>> > everything for easier build testing.
>> >
>> > This fixes LLVM enabled builds on master though that requires changes
>> > to LLVM as well. In the process, LLVM builds with Lollipop are dropped
>> > as L doesn't have the minimum LLVM version for several drivers. Also,
>> > android-x86 L support is using mesa 11.0.
>> >
>> > I've only tested against AOSP master so far.
>> >
>> > Rob
>> >
>> > Mauro Rossi (2):
>> >   android: drop static linking of R600 LLVM libraries
>> >   android: define required __STDC* macros as cflags
>> >
>> > Rob Herring (10):
>> >   Android: amd: use exported include dirs instead of explicit includes
>> >   Android: amd/common: fix dependency on libmesa_nir
>> >   Android: drop LLVM support on Lollipop
>> >   Android: rework libelf dependencies
>> >   Android: remove needless conditional including of child makefiles
>> >   Android: Fix swrast only build
>> >   Android: push driver build details to driver makefiles
>> >   Android: default to building all drivers
>> >   Android: Add LLVM support for Android O
>> >   Android: Drop linking libgcc
>> >
>> >  Android.common.mk| 15 ++
>> >  Android.mk   | 57
>> ++-
>> >  src/amd/Android.addrlib.mk   |  6 +++
>> >  src/amd/Android.common.mk| 16 +--
>> >  src/compiler/Android.nir.gen.mk  |  1 +
>> >  src/egl/Android.mk   | 14 ++
>> >  src/gallium/Android.common.mk|  3 +-
>> >  src/gallium/Android.mk   | 58
>> +++-
>> >  src/gallium/auxiliary/Android.mk | 12 +++--
>> >  src/gallium/auxiliary/pipe-loader/Android.mk |  7 ++-
>> >  src/gallium/drivers/freedreno/Android.mk |  5 ++
>> >  src/gallium/drivers/i915/Android.mk  |  4 ++
>> >  src/gallium/drivers/nouveau/Android.mk   |  5 ++
>> >  src/gallium/drivers/r300/Android.mk  |  4 ++
>> >  src/gallium/drivers/r600/Android.mk  | 10 ++--
>> >  src/gallium/drivers/radeon/Android.mk|  7 ++-
>> >  src/gallium/drivers/radeonsi/Android.mk  | 12 -
>> >  src/gallium/drivers/softpipe/Android.mk  |  4 ++
>> >  src/gallium/drivers/svga/Android.mk  |  4 ++
>> >  src/gallium/drivers/vc4/Android.mk   |  4 ++
>> >  src/gallium/drivers/virgl/Android.mk |  4 ++
>> >  src/gallium/state_trackers/dri/Android.mk| 10 ++--
>> >  src/gallium/targets/dri/Android.mk   | 68
>> ++--
>> >  src/gallium/winsys/amdgpu/drm/Android.mk | 12 ++---
>> >  src/gallium/winsys/i915/drm/Android.mk   |  4 ++
>> >  src/mesa/Android.libmesa_dricore.mk  |  4 --
>> >  src/mesa/Android.libmesa_st_mesa.mk  |  4 --
>> >  src/mesa/drivers/dri/Android.mk  | 11 +
>> >  28 files changed, 149 insertions(+), 216 deletions(-)
>> >
>> > --
>>
>> First of all, thank you for these patches.
>>
>> Patches 1, 2, 3, 4, 5, 6, 7, 8, and 12 are
>>
>> Reviewed-by: Chih-Wei Huang 
>>
>> For others I hope to make a test
>> (at least on N) before commenting.
>>
>> Minor suggestion: unify the uppercase or lowercase
>> in the subject of the series.
>>
>>
>> --
>> Chih-Wei
>> Android-x86 project
>> http://www.android-x86.org
>>
>
> nougat-x86 is building with the series
>


marshmallow-x86 is building with the series,
except for an unrelated this series building error in i965 OA performance
query,
for which I send a separate patch to mesa-dev.

One thing to mention is that llvm 3.7.0 is just ok when building radeonsi
for SI parts,
maybe the llvm 3.8.0 constraint applies to newer amdgpu chipsets VI and
Polaris,
marshmallow-x86 seem to be building ok with llvm 3.7.0
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 00/12] Android build cleanup/fixes

2017-04-30 Thread Mauro Rossi 
2017-04-28 4:55 GMT+02:00 Chih-Wei Huang :

> 2017-04-28 3:43 GMT+08:00 Rob Herring :
> > This is a series of clean-ups and fixes to the Android build files.
> > Overall, it removes a lot of the if conditions that aren't necessary for
> > normal builds and also enables "mmma external/mesa3d" to build
> > everything for easier build testing.
> >
> > This fixes LLVM enabled builds on master though that requires changes
> > to LLVM as well. In the process, LLVM builds with Lollipop are dropped
> > as L doesn't have the minimum LLVM version for several drivers. Also,
> > android-x86 L support is using mesa 11.0.
> >
> > I've only tested against AOSP master so far.
> >
> > Rob
> >
> > Mauro Rossi (2):
> >   android: drop static linking of R600 LLVM libraries
> >   android: define required __STDC* macros as cflags
> >
> > Rob Herring (10):
> >   Android: amd: use exported include dirs instead of explicit includes
> >   Android: amd/common: fix dependency on libmesa_nir
> >   Android: drop LLVM support on Lollipop
> >   Android: rework libelf dependencies
> >   Android: remove needless conditional including of child makefiles
> >   Android: Fix swrast only build
> >   Android: push driver build details to driver makefiles
> >   Android: default to building all drivers
> >   Android: Add LLVM support for Android O
> >   Android: Drop linking libgcc
> >
> >  Android.common.mk| 15 ++
> >  Android.mk   | 57
> ++-
> >  src/amd/Android.addrlib.mk   |  6 +++
> >  src/amd/Android.common.mk| 16 +--
> >  src/compiler/Android.nir.gen.mk  |  1 +
> >  src/egl/Android.mk   | 14 ++
> >  src/gallium/Android.common.mk|  3 +-
> >  src/gallium/Android.mk   | 58
> +++-
> >  src/gallium/auxiliary/Android.mk | 12 +++--
> >  src/gallium/auxiliary/pipe-loader/Android.mk |  7 ++-
> >  src/gallium/drivers/freedreno/Android.mk |  5 ++
> >  src/gallium/drivers/i915/Android.mk  |  4 ++
> >  src/gallium/drivers/nouveau/Android.mk   |  5 ++
> >  src/gallium/drivers/r300/Android.mk  |  4 ++
> >  src/gallium/drivers/r600/Android.mk  | 10 ++--
> >  src/gallium/drivers/radeon/Android.mk|  7 ++-
> >  src/gallium/drivers/radeonsi/Android.mk  | 12 -
> >  src/gallium/drivers/softpipe/Android.mk  |  4 ++
> >  src/gallium/drivers/svga/Android.mk  |  4 ++
> >  src/gallium/drivers/vc4/Android.mk   |  4 ++
> >  src/gallium/drivers/virgl/Android.mk |  4 ++
> >  src/gallium/state_trackers/dri/Android.mk| 10 ++--
> >  src/gallium/targets/dri/Android.mk   | 68
> ++--
> >  src/gallium/winsys/amdgpu/drm/Android.mk | 12 ++---
> >  src/gallium/winsys/i915/drm/Android.mk   |  4 ++
> >  src/mesa/Android.libmesa_dricore.mk  |  4 --
> >  src/mesa/Android.libmesa_st_mesa.mk  |  4 --
> >  src/mesa/drivers/dri/Android.mk  | 11 +
> >  28 files changed, 149 insertions(+), 216 deletions(-)
> >
> > --
>
> First of all, thank you for these patches.
>
> Patches 1, 2, 3, 4, 5, 6, 7, 8, and 12 are
>
> Reviewed-by: Chih-Wei Huang 
>
> For others I hope to make a test
> (at least on N) before commenting.
>
> Minor suggestion: unify the uppercase or lowercase
> in the subject of the series.
>
>
> --
> Chih-Wei
> Android-x86 project
> http://www.android-x86.org
>

nougat-x86 is building with the series
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 00/12] Android build cleanup/fixes

2017-04-27 Thread Chih-Wei Huang 
2017-04-28 3:43 GMT+08:00 Rob Herring :
> This is a series of clean-ups and fixes to the Android build files.
> Overall, it removes a lot of the if conditions that aren't necessary for
> normal builds and also enables "mmma external/mesa3d" to build
> everything for easier build testing.
>
> This fixes LLVM enabled builds on master though that requires changes
> to LLVM as well. In the process, LLVM builds with Lollipop are dropped
> as L doesn't have the minimum LLVM version for several drivers. Also,
> android-x86 L support is using mesa 11.0.
>
> I've only tested against AOSP master so far.
>
> Rob
>
> Mauro Rossi (2):
>   android: drop static linking of R600 LLVM libraries
>   android: define required __STDC* macros as cflags
>
> Rob Herring (10):
>   Android: amd: use exported include dirs instead of explicit includes
>   Android: amd/common: fix dependency on libmesa_nir
>   Android: drop LLVM support on Lollipop
>   Android: rework libelf dependencies
>   Android: remove needless conditional including of child makefiles
>   Android: Fix swrast only build
>   Android: push driver build details to driver makefiles
>   Android: default to building all drivers
>   Android: Add LLVM support for Android O
>   Android: Drop linking libgcc
>
>  Android.common.mk| 15 ++
>  Android.mk   | 57 ++-
>  src/amd/Android.addrlib.mk   |  6 +++
>  src/amd/Android.common.mk| 16 +--
>  src/compiler/Android.nir.gen.mk  |  1 +
>  src/egl/Android.mk   | 14 ++
>  src/gallium/Android.common.mk|  3 +-
>  src/gallium/Android.mk   | 58 +++-
>  src/gallium/auxiliary/Android.mk | 12 +++--
>  src/gallium/auxiliary/pipe-loader/Android.mk |  7 ++-
>  src/gallium/drivers/freedreno/Android.mk |  5 ++
>  src/gallium/drivers/i915/Android.mk  |  4 ++
>  src/gallium/drivers/nouveau/Android.mk   |  5 ++
>  src/gallium/drivers/r300/Android.mk  |  4 ++
>  src/gallium/drivers/r600/Android.mk  | 10 ++--
>  src/gallium/drivers/radeon/Android.mk|  7 ++-
>  src/gallium/drivers/radeonsi/Android.mk  | 12 -
>  src/gallium/drivers/softpipe/Android.mk  |  4 ++
>  src/gallium/drivers/svga/Android.mk  |  4 ++
>  src/gallium/drivers/vc4/Android.mk   |  4 ++
>  src/gallium/drivers/virgl/Android.mk |  4 ++
>  src/gallium/state_trackers/dri/Android.mk| 10 ++--
>  src/gallium/targets/dri/Android.mk   | 68 
> ++--
>  src/gallium/winsys/amdgpu/drm/Android.mk | 12 ++---
>  src/gallium/winsys/i915/drm/Android.mk   |  4 ++
>  src/mesa/Android.libmesa_dricore.mk  |  4 --
>  src/mesa/Android.libmesa_st_mesa.mk  |  4 --
>  src/mesa/drivers/dri/Android.mk  | 11 +
>  28 files changed, 149 insertions(+), 216 deletions(-)
>
> --

First of all, thank you for these patches.

Patches 1, 2, 3, 4, 5, 6, 7, 8, and 12 are

Reviewed-by: Chih-Wei Huang 

For others I hope to make a test
(at least on N) before commenting.

Minor suggestion: unify the uppercase or lowercase
in the subject of the series.


-- 
Chih-Wei
Android-x86 project
http://www.android-x86.org
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [PATCH 00/12] Android build cleanup/fixes

2017-04-27 Thread Rob Herring 
This is a series of clean-ups and fixes to the Android build files. 
Overall, it removes a lot of the if conditions that aren't necessary for 
normal builds and also enables "mmma external/mesa3d" to build 
everything for easier build testing.

This fixes LLVM enabled builds on master though that requires changes 
to LLVM as well. In the process, LLVM builds with Lollipop are dropped 
as L doesn't have the minimum LLVM version for several drivers. Also, 
android-x86 L support is using mesa 11.0.

I've only tested against AOSP master so far.

Rob

Mauro Rossi (2):
  android: drop static linking of R600 LLVM libraries
  android: define required __STDC* macros as cflags

Rob Herring (10):
  Android: amd: use exported include dirs instead of explicit includes
  Android: amd/common: fix dependency on libmesa_nir
  Android: drop LLVM support on Lollipop
  Android: rework libelf dependencies
  Android: remove needless conditional including of child makefiles
  Android: Fix swrast only build
  Android: push driver build details to driver makefiles
  Android: default to building all drivers
  Android: Add LLVM support for Android O
  Android: Drop linking libgcc

 Android.common.mk| 15 ++
 Android.mk   | 57 ++-
 src/amd/Android.addrlib.mk   |  6 +++
 src/amd/Android.common.mk| 16 +--
 src/compiler/Android.nir.gen.mk  |  1 +
 src/egl/Android.mk   | 14 ++
 src/gallium/Android.common.mk|  3 +-
 src/gallium/Android.mk   | 58 +++-
 src/gallium/auxiliary/Android.mk | 12 +++--
 src/gallium/auxiliary/pipe-loader/Android.mk |  7 ++-
 src/gallium/drivers/freedreno/Android.mk |  5 ++
 src/gallium/drivers/i915/Android.mk  |  4 ++
 src/gallium/drivers/nouveau/Android.mk   |  5 ++
 src/gallium/drivers/r300/Android.mk  |  4 ++
 src/gallium/drivers/r600/Android.mk  | 10 ++--
 src/gallium/drivers/radeon/Android.mk|  7 ++-
 src/gallium/drivers/radeonsi/Android.mk  | 12 -
 src/gallium/drivers/softpipe/Android.mk  |  4 ++
 src/gallium/drivers/svga/Android.mk  |  4 ++
 src/gallium/drivers/vc4/Android.mk   |  4 ++
 src/gallium/drivers/virgl/Android.mk |  4 ++
 src/gallium/state_trackers/dri/Android.mk| 10 ++--
 src/gallium/targets/dri/Android.mk   | 68 ++--
 src/gallium/winsys/amdgpu/drm/Android.mk | 12 ++---
 src/gallium/winsys/i915/drm/Android.mk   |  4 ++
 src/mesa/Android.libmesa_dricore.mk  |  4 --
 src/mesa/Android.libmesa_st_mesa.mk  |  4 --
 src/mesa/drivers/dri/Android.mk  | 11 +
 28 files changed, 149 insertions(+), 216 deletions(-)

-- 
2.11.0

___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev