[Mesa-dev] [PATCH 00/20] i915: Pile of fixes and cleanups
From: Ville Syrjälä I've had some of these i915 patches lying around for half a year or more, so I figured it's time to post them. This series fixes rendering problems in glxgears and supertuxkart. It also fixes a few piglit tests (provoking vertex, and a few crashers). No piglit regressions on 855. Summary of the changes: * provoking vertex fixes * gen2 user fbo culling fix * some buffer handling fixes ported over from i965 * gen3 fragment shader texcoord vs. varying fix (already posted before) * random point/line rendering stuff * a bit of polish here and there Ville Syrjälä (20): t_dd_dmatmp: Kill the paths rendering quads/quad strips via indexed vertices t_dd_dmatmp: Allow flat shaded polygons with tri fans t_dd_dmatmp: Disallow flat shading when rendering quad strips via tri strips t_dd_dmatmp: Check provoking vertex convention when rendering quads t_dd_dmatmp: Call render_tri_fan_elts from render_poly_elts t_dd_dmatmp: Fix render_quad_strip_elts t_dd_dmatmp: Make the render_tab[]s const i915: Fix collision between I830_UPLOAD_RASTER_RULES and I830_UPLOAD_TEX(0) i915: Handle provoking vertex in intelFastRenderClippedPoly() i915: Fix t_vb_rendertmp.h's provoking vertex handywork i915: Use _tnl_RenderClippedPolygon and _tnl_RenderClippedLine i915: Make hw_prim[] const i915: Use c99 initializers for primitive arrays i915: Use COPY_DWORDS for points i915: Enable intel_render path for points i915: Adjust line size limits i915: Remember to call intel_prepare_render() before blitting i915: Drop broken front_buffer_reading/drawing optimization i915: Fix culling with user fbos on gen2 i915: Fix texcoord vs. varying collision in fragment programs src/mesa/drivers/dri/i915/i830_context.h | 8 +- src/mesa/drivers/dri/i915/i830_state.c| 2 + src/mesa/drivers/dri/i915/i915_context.h | 14 +-- src/mesa/drivers/dri/i915/i915_fragprog.c | 86 ++--- src/mesa/drivers/dri/i915/intel_buffers.c | 47 --- src/mesa/drivers/dri/i915/intel_buffers.h | 3 + src/mesa/drivers/dri/i915/intel_context.c | 16 +-- src/mesa/drivers/dri/i915/intel_context.h | 16 --- src/mesa/drivers/dri/i915/intel_fbo.c | 5 + src/mesa/drivers/dri/i915/intel_render.c | 66 +- src/mesa/drivers/dri/i915/intel_tris.c| 114 ++--- src/mesa/tnl_dd/t_dd_dmatmp.h | 196 +++--- 12 files changed, 266 insertions(+), 307 deletions(-) -- 2.0.5 ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
Re: [Mesa-dev] [PATCH 00/20] i915: Pile of fixes and cleanups
On Mon, Mar 23, 2015 at 02:47:16PM +0200, ville.syrj...@linux.intel.com wrote: > From: Ville Syrjälä > > I've had some of these i915 patches lying around for half a year or more, > so I figured it's time to post them. > > This series fixes rendering problems in glxgears and supertuxkart. It > also fixes a few piglit tests (provoking vertex, and a few crashers). > No piglit regressions on 855. > > Summary of the changes: > * provoking vertex fixes > * gen2 user fbo culling fix > * some buffer handling fixes ported over from i965 > * gen3 fragment shader texcoord vs. varying fix (already posted before) > * random point/line rendering stuff > * a bit of polish here and there Doesn't look like many people are interested in reading through these. Let me put it the other way: Anyone opposed to me just pushing these? > > Ville Syrjälä (20): > t_dd_dmatmp: Kill the paths rendering quads/quad strips via indexed > vertices > t_dd_dmatmp: Allow flat shaded polygons with tri fans > t_dd_dmatmp: Disallow flat shading when rendering quad strips via tri > strips > t_dd_dmatmp: Check provoking vertex convention when rendering quads > t_dd_dmatmp: Call render_tri_fan_elts from render_poly_elts > t_dd_dmatmp: Fix render_quad_strip_elts > t_dd_dmatmp: Make the render_tab[]s const > i915: Fix collision between I830_UPLOAD_RASTER_RULES and > I830_UPLOAD_TEX(0) > i915: Handle provoking vertex in intelFastRenderClippedPoly() > i915: Fix t_vb_rendertmp.h's provoking vertex handywork > i915: Use _tnl_RenderClippedPolygon and _tnl_RenderClippedLine > i915: Make hw_prim[] const > i915: Use c99 initializers for primitive arrays > i915: Use COPY_DWORDS for points > i915: Enable intel_render path for points > i915: Adjust line size limits > i915: Remember to call intel_prepare_render() before blitting > i915: Drop broken front_buffer_reading/drawing optimization > i915: Fix culling with user fbos on gen2 > i915: Fix texcoord vs. varying collision in fragment programs > > src/mesa/drivers/dri/i915/i830_context.h | 8 +- > src/mesa/drivers/dri/i915/i830_state.c| 2 + > src/mesa/drivers/dri/i915/i915_context.h | 14 +-- > src/mesa/drivers/dri/i915/i915_fragprog.c | 86 ++--- > src/mesa/drivers/dri/i915/intel_buffers.c | 47 --- > src/mesa/drivers/dri/i915/intel_buffers.h | 3 + > src/mesa/drivers/dri/i915/intel_context.c | 16 +-- > src/mesa/drivers/dri/i915/intel_context.h | 16 --- > src/mesa/drivers/dri/i915/intel_fbo.c | 5 + > src/mesa/drivers/dri/i915/intel_render.c | 66 +- > src/mesa/drivers/dri/i915/intel_tris.c| 114 ++--- > src/mesa/tnl_dd/t_dd_dmatmp.h | 196 > +++--- > 12 files changed, 266 insertions(+), 307 deletions(-) > > -- > 2.0.5 -- Ville Syrjälä Intel OTC ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
Re: [Mesa-dev] [PATCH 00/20] i915: Pile of fixes and cleanups
Hi Ville, On 13/04/15 11:00, Ville Syrjälä wrote: > On Mon, Mar 23, 2015 at 02:47:16PM +0200, ville.syrj...@linux.intel.com wrote: >> From: Ville Syrjälä >> >> I've had some of these i915 patches lying around for half a year or more, >> so I figured it's time to post them. >> >> This series fixes rendering problems in glxgears and supertuxkart. It >> also fixes a few piglit tests (provoking vertex, and a few crashers). >> No piglit regressions on 855. >> >> Summary of the changes: >> * provoking vertex fixes >> * gen2 user fbo culling fix >> * some buffer handling fixes ported over from i965 >> * gen3 fragment shader texcoord vs. varying fix (already posted before) >> * random point/line rendering stuff >> * a bit of polish here and there > > Doesn't look like many people are interested in reading through these. > > Let me put it the other way: Anyone opposed to me just pushing these? > While I do not have the hardware to use these, I think that it's great that you made these. It's a bit unfortunate that no one with the knowledge in the driver has the time/interest to check these over. If you go ahead with these, can you change the prefix form t_dd_dmatmp to mesa/tnl_dd, tnl_dd or even tnl. Cheers, Emil ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
Re: [Mesa-dev] [PATCH 00/20] i915: Pile of fixes and cleanups
On Sat, Oct 03, 2015 at 02:55:57AM +0800, Chih-Wei Huang wrote: > 2015-05-22 1:21 GMT+08:00 Ville Syrjälä : > > On Sat, May 16, 2015 at 01:36:44AM +0800, Chih-Wei Huang wrote: > >> 2015-04-13 19:00 GMT+08:00 Ville Syrjälä : > >> > >> Glad to see the patches to improve i915 driver. > >> I thought Intel has given it up. > >> Thank you! > >> > >> I'm happy to test them on my Atom N450 tablet > >> once they are merged. > > > > Available at > > git://github.com/vsyrjala/mesa.git i915_fixes_7 > > if you can't wait :P > > Hello, how about these i915 patches? > Seems they are not merged. > Are they still needed? > > I've tried to apply to mesa 11.0.2 > but there are conflicts I can't resolve. I've not managed to push them. I was planning to push them but then my summer vacation was coming up, and I figured it's a bit rude to push and disappear in case there are any issues. After coming back I naturally forgot all about it, and when I did eventually rememer 11.0 was just about to be released, so I thought it's better to push after the release, and then I've just been too busy with other crap to do anything with these. But I think Ian recently picked up at least some of them (thanks for that BTW). I've not found the time to really good look at what patches he had taken and which were still missing. Ian? -- Ville Syrjälä Intel OTC ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
Re: [Mesa-dev] [PATCH 00/20] i915: Pile of fixes and cleanups
On 10/02/2015 01:30 PM, Ville Syrjälä wrote: > On Sat, Oct 03, 2015 at 02:55:57AM +0800, Chih-Wei Huang wrote: >> 2015-05-22 1:21 GMT+08:00 Ville Syrjälä : >>> On Sat, May 16, 2015 at 01:36:44AM +0800, Chih-Wei Huang wrote: 2015-04-13 19:00 GMT+08:00 Ville Syrjälä : Glad to see the patches to improve i915 driver. I thought Intel has given it up. Thank you! I'm happy to test them on my Atom N450 tablet once they are merged. >>> >>> Available at >>> git://github.com/vsyrjala/mesa.git i915_fixes_7 >>> if you can't wait :P >> >> Hello, how about these i915 patches? >> Seems they are not merged. >> Are they still needed? >> >> I've tried to apply to mesa 11.0.2 >> but there are conflicts I can't resolve. > > I've not managed to push them. I was planning to push them but then my summer > vacation was coming up, and I figured it's a bit rude to push and disappear > in case there are any issues. After coming back I naturally forgot all about > it, and when I did eventually rememer 11.0 was just about to be released, > so I thought it's better to push after the release, and then I've just been > too busy with other crap to do anything with these. > > But I think Ian recently picked up at least some of them (thanks for that > BTW). I've not found the time to really good look at what patches he had > taken and which were still missing. Ian? All except patch 10 have either already been pushed, have been re-sent to the list, or are irrelevant (because they change code that I deleted). ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
