Re: [Mesa-dev] [PATCH 01/12] nir/builder: include nir.h

2015-08-21 Thread Emil Velikov 
On 14/08/15 23:30, Connor Abbott wrote:
 This makes intelligent autocomplete plugins much happier.
 
Include nir.h as we're using the structs and others defined within -
sounds a tad better, than blaiming it on the tool :P

Normally you want headers in such a form that they can be used
irrespectively of any other headers that your source includes and the
order in which that they are included.

-Emil

___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 01/12] nir/builder: include nir.h

2015-08-16 Thread Edward O'Callaghan 
Reviewed-by: Edward O'Callaghan eocallag...@alterapraxis.com


-- 
  Edward O'Callaghan
  edward.ocallag...@koparo.com

On Sat, Aug 15, 2015, at 08:30 AM, Connor Abbott wrote:
 This makes intelligent autocomplete plugins much happier.
 
 Signed-off-by: Connor Abbott connor.w.abb...@intel.com
 ---
  src/glsl/nir/nir_builder.h | 2 ++
  1 file changed, 2 insertions(+)
 
 diff --git a/src/glsl/nir/nir_builder.h b/src/glsl/nir/nir_builder.h
 index 9223e83..1745453 100644
 --- a/src/glsl/nir/nir_builder.h
 +++ b/src/glsl/nir/nir_builder.h
 @@ -24,6 +24,8 @@
  #ifndef NIR_BUILDER_H
  #define NIR_BUILDER_H
  
 +#include nir.h
 +
  struct exec_list;
  
  typedef struct nir_builder {
 -- 
 2.4.3
 
 ___
 mesa-dev mailing list
 mesa-dev@lists.freedesktop.org
 http://lists.freedesktop.org/mailman/listinfo/mesa-dev
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [PATCH 01/12] nir/builder: include nir.h

2015-08-14 Thread Connor Abbott 
This makes intelligent autocomplete plugins much happier.

Signed-off-by: Connor Abbott connor.w.abb...@intel.com
---
 src/glsl/nir/nir_builder.h | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/src/glsl/nir/nir_builder.h b/src/glsl/nir/nir_builder.h
index 9223e83..1745453 100644
--- a/src/glsl/nir/nir_builder.h
+++ b/src/glsl/nir/nir_builder.h
@@ -24,6 +24,8 @@
 #ifndef NIR_BUILDER_H
 #define NIR_BUILDER_H
 
+#include nir.h
+
 struct exec_list;
 
 typedef struct nir_builder {
-- 
2.4.3

___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev