Re: [Mesa-dev] [PATCH 01/13] util: Include assert.h in macros.h.

[Emil Velikov]

Hi Matt,

Did you go through all the header requirements by hand ?
Include-what-you-use looks appealing, despite that sometimes it sorts
includes in reverse order (and adds indirect dependencies).

-Emil
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 01/13] util: Include assert.h in macros.h.

[Matt Turner]

On Tue, Nov 24, 2015 at 11:19 AM, Emil Velikov  wrote:
> Hi Matt,
>
> Did you go through all the header requirements by hand ?
> Include-what-you-use looks appealing, despite that sometimes it sorts
> includes in reverse order (and adds indirect dependencies).

No, I used include-what-you-use but then manually removed headers it
suggested removing instead of replacing #include lists with its
recommendations.

FWIW, I noticed that it thinks a header us unused if a file only needs
a macro from it.
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [PATCH 01/13] util: Include assert.h in macros.h.

[Matt Turner]

---
 src/util/macros.h | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/src/util/macros.h b/src/util/macros.h
index 84e4f18..5014b91 100644
--- a/src/util/macros.h
+++ b/src/util/macros.h
@@ -24,6 +24,8 @@
 #ifndef UTIL_MACROS_H
 #define UTIL_MACROS_H
 
+#include 
+
 /* Compute the size of an array */
 #ifndef ARRAY_SIZE
 #  define ARRAY_SIZE(x) (sizeof(x) / sizeof(*(x)))
-- 
2.4.9

___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev