Re: [Mesa-dev] [PATCH 03/36] isl/state: Use a valid alignment for 1-D textures

2016-07-21 Thread Nanley Chery
On Wed, Jun 29, 2016 at 05:37:22PM -0700, Jason Ekstrand wrote:
> The alignment we use doesn't matter (see the comment) but it should at
> least be an alignment we can represent with the enums.

This patch is,
Reviewed-by: Nanley Chery 

> ---
>  src/intel/isl/isl_surface_state.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/intel/isl/isl_surface_state.c 
> b/src/intel/isl/isl_surface_state.c
> index bfd4b65..1d354f3 100644
> --- a/src/intel/isl/isl_surface_state.c
> +++ b/src/intel/isl/isl_surface_state.c
> @@ -142,7 +142,7 @@ get_image_alignment(const struct isl_surf *surf)
>* true alignment is likely outside the enum range of HALIGN* and
>* VALIGN*.
>*/
> - return isl_extent3d(0, 0, 0);
> + return isl_extent3d(4, 4, 1);
>} else {
>   /* In Skylake, RENDER_SUFFACE_STATE.SurfaceVerticalAlignment is in 
> units
>* of surface elements (not pixels nor samples). For compressed 
> formats,
> -- 
> 2.5.0.400.gff86faf
> 
> ___
> mesa-dev mailing list
> mesa-dev@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev


[Mesa-dev] [PATCH 03/36] isl/state: Use a valid alignment for 1-D textures

2016-06-29 Thread Jason Ekstrand
The alignment we use doesn't matter (see the comment) but it should at
least be an alignment we can represent with the enums.
---
 src/intel/isl/isl_surface_state.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/intel/isl/isl_surface_state.c 
b/src/intel/isl/isl_surface_state.c
index bfd4b65..1d354f3 100644
--- a/src/intel/isl/isl_surface_state.c
+++ b/src/intel/isl/isl_surface_state.c
@@ -142,7 +142,7 @@ get_image_alignment(const struct isl_surf *surf)
   * true alignment is likely outside the enum range of HALIGN* and
   * VALIGN*.
   */
- return isl_extent3d(0, 0, 0);
+ return isl_extent3d(4, 4, 1);
   } else {
  /* In Skylake, RENDER_SUFFACE_STATE.SurfaceVerticalAlignment is in 
units
   * of surface elements (not pixels nor samples). For compressed 
formats,
-- 
2.5.0.400.gff86faf

___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev