Re: [Mesa-dev] [PATCH 05/10] postprocess: fix new gcc6 warnings

[Matt Turner]

On Tue, Feb 16, 2016 at 10:58 AM, Rob Clark  wrote:
> In file included from src/gallium/state_trackers/dri/dri_screen.h:44:0,
>  from src/gallium/state_trackers/dri/dri_query_renderer.c:7:
> src/gallium/auxiliary/postprocess/filters.h:54:33: warning: ‘pp_filters’
> defined but not used [-Wunused-const-variable]
>  static const struct pp_filter_t pp_filters[PP_FILTERS] = {
>  ^~
>
> Note, this one we may actually want to move into an .c file instead?

I think that would be best. I expect this table is being duplicated
for each compilation unit that uses it.
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [PATCH 05/10] postprocess: fix new gcc6 warnings

[Rob Clark]

In file included from src/gallium/state_trackers/dri/dri_screen.h:44:0,
 from src/gallium/state_trackers/dri/dri_query_renderer.c:7:
src/gallium/auxiliary/postprocess/filters.h:54:33: warning: ‘pp_filters’
defined but not used [-Wunused-const-variable]
 static const struct pp_filter_t pp_filters[PP_FILTERS] = {
 ^~

Note, this one we may actually want to move into an .c file instead?

Signed-off-by: Rob Clark 
---
 src/gallium/auxiliary/postprocess/filters.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/gallium/auxiliary/postprocess/filters.h 
b/src/gallium/auxiliary/postprocess/filters.h
index 321f333..8028df9 100644
--- a/src/gallium/auxiliary/postprocess/filters.h
+++ b/src/gallium/auxiliary/postprocess/filters.h
@@ -51,7 +51,7 @@ struct pp_filter_t
 
 /* Order matters. Put new filters in a suitable place. */
 
-static const struct pp_filter_t pp_filters[PP_FILTERS] = {
+static const struct pp_filter_t pp_filters[PP_FILTERS] UNUSED = {
 /*name inner   shaders verts   init
run   free   */
{ "pp_noblue",  0,  2,  1,  pp_noblue_init, 
pp_nocolor,   pp_nocolor_free },
{ "pp_nogreen", 0,  2,  1,  pp_nogreen_init,
pp_nocolor,   pp_nocolor_free },
-- 
2.5.0

___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev