Re: [Mesa-dev] [PATCH 05/15] spirv: Handle the SpvDecorationStream decoration

2018-07-27 Thread Timothy Arceri

Reviewed-by: Timothy Arceri 

On 21/07/18 01:08, Alejandro Piñeiro wrote:

From: Neil Roberts 

This just sets the stream on the nir_variable.
---
  src/compiler/spirv/vtn_variables.c | 5 -
  1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/src/compiler/spirv/vtn_variables.c 
b/src/compiler/spirv/vtn_variables.c
index 6ff2e83515a..8dab86abd74 100644
--- a/src/compiler/spirv/vtn_variables.c
+++ b/src/compiler/spirv/vtn_variables.c
@@ -1298,7 +1298,6 @@ apply_var_decoration(struct vtn_builder *b,
 case SpvDecorationMatrixStride:
 case SpvDecorationAliased:
 case SpvDecorationUniform:
-   case SpvDecorationStream:
 case SpvDecorationLinkageAttributes:
break; /* Do nothing with these here */
  
@@ -1337,6 +1336,10 @@ apply_var_decoration(struct vtn_builder *b,

var_data->offset = dec->literals[0];
break;
  
+   case SpvDecorationStream:

+  var_data->stream = dec->literals[0];
+  break;
+
 case SpvDecorationCPacked:
 case SpvDecorationSaturatedConversion:
 case SpvDecorationFuncParamAttr:


___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev


[Mesa-dev] [PATCH 05/15] spirv: Handle the SpvDecorationStream decoration

2018-07-20 Thread Alejandro Piñeiro
From: Neil Roberts 

This just sets the stream on the nir_variable.
---
 src/compiler/spirv/vtn_variables.c | 5 -
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/src/compiler/spirv/vtn_variables.c 
b/src/compiler/spirv/vtn_variables.c
index 6ff2e83515a..8dab86abd74 100644
--- a/src/compiler/spirv/vtn_variables.c
+++ b/src/compiler/spirv/vtn_variables.c
@@ -1298,7 +1298,6 @@ apply_var_decoration(struct vtn_builder *b,
case SpvDecorationMatrixStride:
case SpvDecorationAliased:
case SpvDecorationUniform:
-   case SpvDecorationStream:
case SpvDecorationLinkageAttributes:
   break; /* Do nothing with these here */
 
@@ -1337,6 +1336,10 @@ apply_var_decoration(struct vtn_builder *b,
   var_data->offset = dec->literals[0];
   break;
 
+   case SpvDecorationStream:
+  var_data->stream = dec->literals[0];
+  break;
+
case SpvDecorationCPacked:
case SpvDecorationSaturatedConversion:
case SpvDecorationFuncParamAttr:
-- 
2.14.1

___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev