Re: [Mesa-dev] [PATCH 05/18] mesa/es: Remove redundant glCompressedTexImage3DOES target validation

2012-08-21 Thread Kenneth Graunke
On 08/20/2012 05:06 PM, Ian Romanick wrote:
 From: Ian Romanick ian.d.roman...@intel.com
 
 Signed-off-by: Ian Romanick ian.d.roman...@intel.com
 ---
  src/mesa/main/APIspec.xml |4 
  1 files changed, 0 insertions(+), 4 deletions(-)
 
 diff --git a/src/mesa/main/APIspec.xml b/src/mesa/main/APIspec.xml
 index 1306ac7..991e373 100644
 --- a/src/mesa/main/APIspec.xml
 +++ b/src/mesa/main/APIspec.xml
 @@ -2055,10 +2055,6 @@
   param name=imagesize type=GLsizei/
   param name=data type=const GLvoid */
   /proto
 -
 - desc name=target
 - value name=GL_TEXTURE_3D_OES/
 - /desc
  /template
  
  template name=CompressedTexSubImage3D

I believe this will allow GL_PROXY_TEXTURE_3D to slip through.
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev


Re: [Mesa-dev] [PATCH 05/18] mesa/es: Remove redundant glCompressedTexImage3DOES target validation

2012-08-21 Thread Kenneth Graunke
On 08/20/2012 10:12 PM, Kenneth Graunke wrote:
 On 08/20/2012 05:06 PM, Ian Romanick wrote:
 From: Ian Romanick ian.d.roman...@intel.com

 Signed-off-by: Ian Romanick ian.d.roman...@intel.com
 ---
  src/mesa/main/APIspec.xml |4 
  1 files changed, 0 insertions(+), 4 deletions(-)

 diff --git a/src/mesa/main/APIspec.xml b/src/mesa/main/APIspec.xml
 index 1306ac7..991e373 100644
 --- a/src/mesa/main/APIspec.xml
 +++ b/src/mesa/main/APIspec.xml
 @@ -2055,10 +2055,6 @@
  param name=imagesize type=GLsizei/
  param name=data type=const GLvoid */
  /proto
 -
 -desc name=target
 -value name=GL_TEXTURE_3D_OES/
 -/desc
  /template
  
  template name=CompressedTexSubImage3D
 
 I believe this will allow GL_PROXY_TEXTURE_3D to slip through.

...which you actually fix in the very next patch.  I'd just squash this
into patch 6, where you kill the rest of this stuff and do it right.

Not a big deal, but avoids a tiny bit of intermittent breakage.


___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev


[Mesa-dev] [PATCH 05/18] mesa/es: Remove redundant glCompressedTexImage3DOES target validation

2012-08-20 Thread Ian Romanick
From: Ian Romanick ian.d.roman...@intel.com

Signed-off-by: Ian Romanick ian.d.roman...@intel.com
---
 src/mesa/main/APIspec.xml |4 
 1 files changed, 0 insertions(+), 4 deletions(-)

diff --git a/src/mesa/main/APIspec.xml b/src/mesa/main/APIspec.xml
index 1306ac7..991e373 100644
--- a/src/mesa/main/APIspec.xml
+++ b/src/mesa/main/APIspec.xml
@@ -2055,10 +2055,6 @@
param name=imagesize type=GLsizei/
param name=data type=const GLvoid */
/proto
-
-   desc name=target
-   value name=GL_TEXTURE_3D_OES/
-   /desc
 /template
 
 template name=CompressedTexSubImage3D
-- 
1.7.6.5

___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev