Re: [Mesa-dev] [PATCH 09/10] main/glsles: return two minor digits for SHADING_LANGUAGE_VERSION

2014-12-02 Thread Ian Romanick
With Brian's suggested change to the commit message, this patch is

Reviewed-by: Ian Romanick ian.d.roman...@intel.com

On 12/01/2014 05:04 AM, Eduardo Lima Mitev wrote:
 From: Samuel Iglesias Gonsalvez sigles...@igalia.com
 
 For OpenGL ES 3.0 spec, the minor number for SHADING_LANGUAGE_VERSION is 
 always
 two digits, matching the OpenGL ES Shading Language Specification release
 number. For example, this query might return the string 3.00.
 
 This patch fixes the following dEQP test:
 
dEQP-GLES3.functional.state_query.string.shading_language_version
 
 No piglit regression observed.
 
 Signed-off-by: Samuel Iglesias Gonsalvez sigles...@igalia.com
 ---
  src/mesa/main/getstring.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
 
 diff --git a/src/mesa/main/getstring.c b/src/mesa/main/getstring.c
 index 431d60b..7054fc7 100644
 --- a/src/mesa/main/getstring.c
 +++ b/src/mesa/main/getstring.c
 @@ -68,7 +68,7 @@ shading_language_version(struct gl_context *ctx)
 case API_OPENGLES2:
return (ctx-Version  30)
   ? (const GLubyte *) OpenGL ES GLSL ES 1.0.16
 - : (const GLubyte *) OpenGL ES GLSL ES 3.0;
 + : (const GLubyte *) OpenGL ES GLSL ES 3.00;
  
 case API_OPENGLES:
/* fall-through */
 

___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev


[Mesa-dev] [PATCH 09/10] main/glsles: return two minor digits for SHADING_LANGUAGE_VERSION

2014-12-01 Thread Eduardo Lima Mitev
From: Samuel Iglesias Gonsalvez sigles...@igalia.com

For OpenGL ES 3.0 spec, the minor number for SHADING_LANGUAGE_VERSION is always
two digits, matching the OpenGL ES Shading Language Specification release
number. For example, this query might return the string 3.00.

This patch fixes the following dEQP test:

   dEQP-GLES3.functional.state_query.string.shading_language_version

No piglit regression observed.

Signed-off-by: Samuel Iglesias Gonsalvez sigles...@igalia.com
---
 src/mesa/main/getstring.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/mesa/main/getstring.c b/src/mesa/main/getstring.c
index 431d60b..7054fc7 100644
--- a/src/mesa/main/getstring.c
+++ b/src/mesa/main/getstring.c
@@ -68,7 +68,7 @@ shading_language_version(struct gl_context *ctx)
case API_OPENGLES2:
   return (ctx-Version  30)
  ? (const GLubyte *) OpenGL ES GLSL ES 1.0.16
- : (const GLubyte *) OpenGL ES GLSL ES 3.0;
+ : (const GLubyte *) OpenGL ES GLSL ES 3.00;
 
case API_OPENGLES:
   /* fall-through */
-- 
2.1.3

___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev


Re: [Mesa-dev] [PATCH 09/10] main/glsles: return two minor digits for SHADING_LANGUAGE_VERSION

2014-12-01 Thread Brian Paul
I'd change the subject to main: return two minor digits for ES shading 
language version



On 12/01/2014 06:04 AM, Eduardo Lima Mitev wrote:

From: Samuel Iglesias Gonsalvez sigles...@igalia.com

For OpenGL ES 3.0 spec, the minor number for SHADING_LANGUAGE_VERSION is always
two digits, matching the OpenGL ES Shading Language Specification release
number. For example, this query might return the string 3.00.

This patch fixes the following dEQP test:

dEQP-GLES3.functional.state_query.string.shading_language_version

No piglit regression observed.

Signed-off-by: Samuel Iglesias Gonsalvez sigles...@igalia.com
---
  src/mesa/main/getstring.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/mesa/main/getstring.c b/src/mesa/main/getstring.c
index 431d60b..7054fc7 100644
--- a/src/mesa/main/getstring.c
+++ b/src/mesa/main/getstring.c
@@ -68,7 +68,7 @@ shading_language_version(struct gl_context *ctx)
 case API_OPENGLES2:
return (ctx-Version  30)
   ? (const GLubyte *) OpenGL ES GLSL ES 1.0.16
- : (const GLubyte *) OpenGL ES GLSL ES 3.0;
+ : (const GLubyte *) OpenGL ES GLSL ES 3.00;

 case API_OPENGLES:
/* fall-through */



___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev


Re: [Mesa-dev] [PATCH 09/10] main/glsles: return two minor digits for SHADING_LANGUAGE_VERSION

2014-12-01 Thread Samuel Iglesias Gonsálvez
On Monday, December 01, 2014 09:29:13 AM Brian Paul wrote:
 I'd change the subject to main: return two minor digits for ES shading
 language version
 

We'll do that.

Thanks!

Sam

 On 12/01/2014 06:04 AM, Eduardo Lima Mitev wrote:
  From: Samuel Iglesias Gonsalvez sigles...@igalia.com
  
  For OpenGL ES 3.0 spec, the minor number for SHADING_LANGUAGE_VERSION is
  always two digits, matching the OpenGL ES Shading Language Specification
  release number. For example, this query might return the string 3.00.
  
  This patch fixes the following dEQP test:
  dEQP-GLES3.functional.state_query.string.shading_language_version
  
  No piglit regression observed.
  
  Signed-off-by: Samuel Iglesias Gonsalvez sigles...@igalia.com
  ---
  
src/mesa/main/getstring.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
  
  diff --git a/src/mesa/main/getstring.c b/src/mesa/main/getstring.c
  index 431d60b..7054fc7 100644
  --- a/src/mesa/main/getstring.c
  +++ b/src/mesa/main/getstring.c
  @@ -68,7 +68,7 @@ shading_language_version(struct gl_context *ctx)
  
   case API_OPENGLES2:
  return (ctx-Version  30)
  
 ? (const GLubyte *) OpenGL ES GLSL ES 1.0.16
  
  - : (const GLubyte *) OpenGL ES GLSL ES 3.0;
  + : (const GLubyte *) OpenGL ES GLSL ES 3.00;
  
   case API_OPENGLES:
  /* fall-through */
 
 ___
 mesa-dev mailing list
 mesa-dev@lists.freedesktop.org
 http://lists.freedesktop.org/mailman/listinfo/mesa-dev


signature.asc
Description: This is a digitally signed message part.
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev