[Mesa-dev] [PATCH 09/11] mesa: Fix alpha component in unpack_R8G8B8X8_SRGB.

[Dave Airlie]

From: Richard Sandiford 

The function was using the "X" component as the alpha channel,
rather than setting alpha to 1.0.

Signed-off-by: Richard Sandiford 
Reviewed-by: Brian Paul 
Signed-off-by: Dave Airlie 
---
 src/mesa/main/format_unpack.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/mesa/main/format_unpack.c b/src/mesa/main/format_unpack.c
index 68fbcb3..cfa6a60 100644
--- a/src/mesa/main/format_unpack.c
+++ b/src/mesa/main/format_unpack.c
@@ -2127,7 +2127,7 @@ unpack_R8G8B8X8_SRGB(const void *src, GLfloat dst[][4], 
GLuint n)
   dst[i][RCOMP] = util_format_srgb_8unorm_to_linear_float( (s[i]  ) & 
0xff );
   dst[i][GCOMP] = util_format_srgb_8unorm_to_linear_float( (s[i] >>  8) & 
0xff );
   dst[i][BCOMP] = util_format_srgb_8unorm_to_linear_float( (s[i] >> 16) & 
0xff );
-  dst[i][ACOMP] = UBYTE_TO_FLOAT( s[i] >> 24 ); /* linear! */
+  dst[i][ACOMP] = 1.0f;
}
 }
 
-- 
1.9.3

___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 09/11] mesa: Fix alpha component in unpack_R8G8B8X8_SRGB.

[Jason Ekstrand]

Reviewed-by: Jason Ekstrand 

This is why we should be auto-generating these...

On Mon, Sep 15, 2014 at 11:28 PM, Dave Airlie  wrote:

> From: Richard Sandiford 
>
> The function was using the "X" component as the alpha channel,
> rather than setting alpha to 1.0.
>
> Signed-off-by: Richard Sandiford 
> Reviewed-by: Brian Paul 
> Signed-off-by: Dave Airlie 
> ---
>  src/mesa/main/format_unpack.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/mesa/main/format_unpack.c b/src/mesa/main/format_unpack.c
> index 68fbcb3..cfa6a60 100644
> --- a/src/mesa/main/format_unpack.c
> +++ b/src/mesa/main/format_unpack.c
> @@ -2127,7 +2127,7 @@ unpack_R8G8B8X8_SRGB(const void *src, GLfloat
> dst[][4], GLuint n)
>dst[i][RCOMP] = util_format_srgb_8unorm_to_linear_float( (s[i]
> ) & 0xff );
>dst[i][GCOMP] = util_format_srgb_8unorm_to_linear_float( (s[i] >>
> 8) & 0xff );
>dst[i][BCOMP] = util_format_srgb_8unorm_to_linear_float( (s[i] >>
> 16) & 0xff );
> -  dst[i][ACOMP] = UBYTE_TO_FLOAT( s[i] >> 24 ); /* linear! */
> +  dst[i][ACOMP] = 1.0f;
> }
>  }
>
> --
> 1.9.3
>
> ___
> mesa-dev mailing list
> mesa-dev@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/mesa-dev
>
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev