[Mesa-dev] [PATCH 09/13] i965: Drop #include of main/glheader.h.
It's never used. --- src/mesa/drivers/dri/i965/brw_clear.c | 1 - src/mesa/drivers/dri/i965/brw_clip.c | 1 - src/mesa/drivers/dri/i965/brw_clip_line.c | 1 - src/mesa/drivers/dri/i965/brw_clip_point.c | 1 - src/mesa/drivers/dri/i965/brw_clip_tri.c | 1 - src/mesa/drivers/dri/i965/brw_clip_unfilled.c | 1 - src/mesa/drivers/dri/i965/brw_clip_util.c | 1 - src/mesa/drivers/dri/i965/brw_compute.c| 1 - src/mesa/drivers/dri/i965/brw_curbe.c | 1 - src/mesa/drivers/dri/i965/brw_draw.c | 1 - src/mesa/drivers/dri/i965/brw_draw_upload.c| 1 - src/mesa/drivers/dri/i965/brw_ff_gs.c | 1 - src/mesa/drivers/dri/i965/brw_ff_gs_emit.c | 1 - src/mesa/drivers/dri/i965/brw_sf.c | 1 - src/mesa/drivers/dri/i965/brw_sf_emit.c| 1 - src/mesa/drivers/dri/i965/brw_tex.c| 1 - src/mesa/drivers/dri/i965/gen8_draw_upload.c | 1 - src/mesa/drivers/dri/i965/intel_pixel_bitmap.c | 1 - src/mesa/drivers/dri/i965/intel_pixel_copy.c | 1 - src/mesa/drivers/dri/i965/intel_pixel_draw.c | 1 - src/mesa/drivers/dri/i965/intel_pixel_read.c | 1 - src/mesa/drivers/dri/i965/intel_screen.c | 1 - src/mesa/drivers/dri/i965/intel_state.c| 1 - src/mesa/drivers/dri/i965/intel_tex_image.c| 1 - 24 files changed, 24 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_clear.c b/src/mesa/drivers/dri/i965/brw_clear.c index b011955..841ba5d 100644 --- a/src/mesa/drivers/dri/i965/brw_clear.c +++ b/src/mesa/drivers/dri/i965/brw_clear.c @@ -24,7 +24,6 @@ * SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE. */ -#include "main/glheader.h" #include "main/mtypes.h" #include "main/condrender.h" #include "swrast/swrast.h" diff --git a/src/mesa/drivers/dri/i965/brw_clip.c b/src/mesa/drivers/dri/i965/brw_clip.c index 2d5abc7..9db35ce 100644 --- a/src/mesa/drivers/dri/i965/brw_clip.c +++ b/src/mesa/drivers/dri/i965/brw_clip.c @@ -29,7 +29,6 @@ * Keith Whitwell */ -#include "main/glheader.h" #include "main/macros.h" #include "main/enums.h" diff --git a/src/mesa/drivers/dri/i965/brw_clip_line.c b/src/mesa/drivers/dri/i965/brw_clip_line.c index 8e34f7c..d59e884 100644 --- a/src/mesa/drivers/dri/i965/brw_clip_line.c +++ b/src/mesa/drivers/dri/i965/brw_clip_line.c @@ -29,7 +29,6 @@ * Keith Whitwell */ -#include "main/glheader.h" #include "main/macros.h" #include "main/enums.h" #include "program/program.h" diff --git a/src/mesa/drivers/dri/i965/brw_clip_point.c b/src/mesa/drivers/dri/i965/brw_clip_point.c index 81487d3..5cf2f5e 100644 --- a/src/mesa/drivers/dri/i965/brw_clip_point.c +++ b/src/mesa/drivers/dri/i965/brw_clip_point.c @@ -29,7 +29,6 @@ * Keith Whitwell */ -#include "main/glheader.h" #include "main/macros.h" #include "main/enums.h" #include "program/program.h" diff --git a/src/mesa/drivers/dri/i965/brw_clip_tri.c b/src/mesa/drivers/dri/i965/brw_clip_tri.c index cca7eb1..38ab007 100644 --- a/src/mesa/drivers/dri/i965/brw_clip_tri.c +++ b/src/mesa/drivers/dri/i965/brw_clip_tri.c @@ -29,7 +29,6 @@ * Keith Whitwell */ -#include "main/glheader.h" #include "main/macros.h" #include "main/enums.h" #include "program/program.h" diff --git a/src/mesa/drivers/dri/i965/brw_clip_unfilled.c b/src/mesa/drivers/dri/i965/brw_clip_unfilled.c index 9a4d2a9..214a346 100644 --- a/src/mesa/drivers/dri/i965/brw_clip_unfilled.c +++ b/src/mesa/drivers/dri/i965/brw_clip_unfilled.c @@ -29,7 +29,6 @@ * Keith Whitwell */ -#include "main/glheader.h" #include "main/macros.h" #include "main/enums.h" #include "program/program.h" diff --git a/src/mesa/drivers/dri/i965/brw_clip_util.c b/src/mesa/drivers/dri/i965/brw_clip_util.c index 73ba85e..713d445 100644 --- a/src/mesa/drivers/dri/i965/brw_clip_util.c +++ b/src/mesa/drivers/dri/i965/brw_clip_util.c @@ -30,7 +30,6 @@ */ -#include "main/glheader.h" #include "main/macros.h" #include "main/enums.h" #include "program/program.h" diff --git a/src/mesa/drivers/dri/i965/brw_compute.c b/src/mesa/drivers/dri/i965/brw_compute.c index fe991a4..d9f181a 100644 --- a/src/mesa/drivers/dri/i965/brw_compute.c +++ b/src/mesa/drivers/dri/i965/brw_compute.c @@ -24,7 +24,6 @@ #include #include "main/condrender.h" -#include "main/glheader.h" #include "main/mtypes.h" #include "main/state.h" #include "brw_context.h" diff --git a/src/mesa/drivers/dri/i965/brw_curbe.c b/src/mesa/drivers/dri/i965/brw_curbe.c index a149ce3..b777bce 100644 --- a/src/mesa/drivers/dri/i965/brw_curbe.c +++ b/src/mesa/drivers/dri/i965/brw_curbe.c @@ -50,7 +50,6 @@ */ -#include "main/glheader.h" #include "main/context.h" #include "main/macros.h" #include "main/enums.h" diff --git a/src/mesa/drivers/dri/i965/brw_draw.c b/src/mesa/drivers/dri/i965/brw_draw.c index bff484f..f250208 100644 --- a/src/mesa/drivers/dri/i965/brw_draw.c +++ b/src/mesa/drivers/dri/i965/brw_draw.c @@ -25,7 +25,6 @@ #include -#include "main/glheade
Re: [Mesa-dev] [PATCH 09/13] i965: Drop #include of main/glheader.h.
Have you built this series with debug and release builds? There have been cases in the past where removing or changing headers worked fine in one but not the other. On 11/23/2015 01:55 PM, Matt Turner wrote: > It's never used. > --- > src/mesa/drivers/dri/i965/brw_clear.c | 1 - > src/mesa/drivers/dri/i965/brw_clip.c | 1 - > src/mesa/drivers/dri/i965/brw_clip_line.c | 1 - > src/mesa/drivers/dri/i965/brw_clip_point.c | 1 - > src/mesa/drivers/dri/i965/brw_clip_tri.c | 1 - > src/mesa/drivers/dri/i965/brw_clip_unfilled.c | 1 - > src/mesa/drivers/dri/i965/brw_clip_util.c | 1 - > src/mesa/drivers/dri/i965/brw_compute.c| 1 - > src/mesa/drivers/dri/i965/brw_curbe.c | 1 - > src/mesa/drivers/dri/i965/brw_draw.c | 1 - > src/mesa/drivers/dri/i965/brw_draw_upload.c| 1 - > src/mesa/drivers/dri/i965/brw_ff_gs.c | 1 - > src/mesa/drivers/dri/i965/brw_ff_gs_emit.c | 1 - > src/mesa/drivers/dri/i965/brw_sf.c | 1 - > src/mesa/drivers/dri/i965/brw_sf_emit.c| 1 - > src/mesa/drivers/dri/i965/brw_tex.c| 1 - > src/mesa/drivers/dri/i965/gen8_draw_upload.c | 1 - > src/mesa/drivers/dri/i965/intel_pixel_bitmap.c | 1 - > src/mesa/drivers/dri/i965/intel_pixel_copy.c | 1 - > src/mesa/drivers/dri/i965/intel_pixel_draw.c | 1 - > src/mesa/drivers/dri/i965/intel_pixel_read.c | 1 - > src/mesa/drivers/dri/i965/intel_screen.c | 1 - > src/mesa/drivers/dri/i965/intel_state.c| 1 - > src/mesa/drivers/dri/i965/intel_tex_image.c| 1 - > 24 files changed, 24 deletions(-) > > diff --git a/src/mesa/drivers/dri/i965/brw_clear.c > b/src/mesa/drivers/dri/i965/brw_clear.c > index b011955..841ba5d 100644 > --- a/src/mesa/drivers/dri/i965/brw_clear.c > +++ b/src/mesa/drivers/dri/i965/brw_clear.c > @@ -24,7 +24,6 @@ > * SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE. > */ > > -#include "main/glheader.h" > #include "main/mtypes.h" > #include "main/condrender.h" > #include "swrast/swrast.h" > diff --git a/src/mesa/drivers/dri/i965/brw_clip.c > b/src/mesa/drivers/dri/i965/brw_clip.c > index 2d5abc7..9db35ce 100644 > --- a/src/mesa/drivers/dri/i965/brw_clip.c > +++ b/src/mesa/drivers/dri/i965/brw_clip.c > @@ -29,7 +29,6 @@ >* Keith Whitwell >*/ > > -#include "main/glheader.h" > #include "main/macros.h" > #include "main/enums.h" > > diff --git a/src/mesa/drivers/dri/i965/brw_clip_line.c > b/src/mesa/drivers/dri/i965/brw_clip_line.c > index 8e34f7c..d59e884 100644 > --- a/src/mesa/drivers/dri/i965/brw_clip_line.c > +++ b/src/mesa/drivers/dri/i965/brw_clip_line.c > @@ -29,7 +29,6 @@ >* Keith Whitwell >*/ > > -#include "main/glheader.h" > #include "main/macros.h" > #include "main/enums.h" > #include "program/program.h" > diff --git a/src/mesa/drivers/dri/i965/brw_clip_point.c > b/src/mesa/drivers/dri/i965/brw_clip_point.c > index 81487d3..5cf2f5e 100644 > --- a/src/mesa/drivers/dri/i965/brw_clip_point.c > +++ b/src/mesa/drivers/dri/i965/brw_clip_point.c > @@ -29,7 +29,6 @@ >* Keith Whitwell >*/ > > -#include "main/glheader.h" > #include "main/macros.h" > #include "main/enums.h" > #include "program/program.h" > diff --git a/src/mesa/drivers/dri/i965/brw_clip_tri.c > b/src/mesa/drivers/dri/i965/brw_clip_tri.c > index cca7eb1..38ab007 100644 > --- a/src/mesa/drivers/dri/i965/brw_clip_tri.c > +++ b/src/mesa/drivers/dri/i965/brw_clip_tri.c > @@ -29,7 +29,6 @@ >* Keith Whitwell >*/ > > -#include "main/glheader.h" > #include "main/macros.h" > #include "main/enums.h" > #include "program/program.h" > diff --git a/src/mesa/drivers/dri/i965/brw_clip_unfilled.c > b/src/mesa/drivers/dri/i965/brw_clip_unfilled.c > index 9a4d2a9..214a346 100644 > --- a/src/mesa/drivers/dri/i965/brw_clip_unfilled.c > +++ b/src/mesa/drivers/dri/i965/brw_clip_unfilled.c > @@ -29,7 +29,6 @@ >* Keith Whitwell >*/ > > -#include "main/glheader.h" > #include "main/macros.h" > #include "main/enums.h" > #include "program/program.h" > diff --git a/src/mesa/drivers/dri/i965/brw_clip_util.c > b/src/mesa/drivers/dri/i965/brw_clip_util.c > index 73ba85e..713d445 100644 > --- a/src/mesa/drivers/dri/i965/brw_clip_util.c > +++ b/src/mesa/drivers/dri/i965/brw_clip_util.c > @@ -30,7 +30,6 @@ >*/ > > > -#include "main/glheader.h" > #include "main/macros.h" > #include "main/enums.h" > #include "program/program.h" > diff --git a/src/mesa/drivers/dri/i965/brw_compute.c > b/src/mesa/drivers/dri/i965/brw_compute.c > index fe991a4..d9f181a 100644 > --- a/src/mesa/drivers/dri/i965/brw_compute.c > +++ b/src/mesa/drivers/dri/i965/brw_compute.c > @@ -24,7 +24,6 @@ > #include > > #include "main/condrender.h" > -#include "main/glheader.h" > #include "main/mtypes.h" > #include "main/state.h" > #include "brw_context.h" > diff --git a/src/mesa/drivers/dri/i965/brw_curbe.c > b/src/mesa/drivers/dri/i965/brw_curbe.c > index a149ce3..b777bce 100644 > -
Re: [Mesa-dev] [PATCH 09/13] i965: Drop #include of main/glheader.h.
On Mon, Nov 23, 2015 at 1:57 PM, Ian Romanick wrote: > Have you built this series with debug and release builds? There have > been cases in the past where removing or changing headers worked fine in > one but not the other. Yes. ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
Re: [Mesa-dev] [PATCH 09/13] i965: Drop #include of main/glheader.h.
On 11/23/2015 02:09 PM, Matt Turner wrote: > On Mon, Nov 23, 2015 at 1:57 PM, Ian Romanick wrote: >> Have you built this series with debug and release builds? There have >> been cases in the past where removing or changing headers worked fine in >> one but not the other. > > Yes. Cool. This series is Reviewed-by: Ian Romanick ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
