Re: [Mesa-dev] [PATCH 09/33] aubinator: print number of dwords per instruction

2017-10-31 Thread Lionel Landwerlin 

On 31/10/17 17:59, Scott D Phillips wrote:

Lionel Landwerlin  writes:


Signed-off-by: Lionel Landwerlin 
---
  src/intel/tools/aubinator.c | 7 +--
  1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/src/intel/tools/aubinator.c b/src/intel/tools/aubinator.c
index 48d4456cc16..2c4eaab1701 100644
--- a/src/intel/tools/aubinator.c
+++ b/src/intel/tools/aubinator.c
@@ -729,9 +729,12 @@ parse_commands(struct gen_spec *spec, uint32_t *cmds, int 
size, int engine)
else
   offset = 0;
  
-  fprintf(outfile, "%s0x%08"PRIx64":  0x%08x:  %-80s%s\n",

+  fprintf(outfile, "%s0x%08"PRIx64":  0x%08x:  %s (%i Dwords) %-80s %s\n",
color, offset, p[0],
-  gen_group_get_name(inst), reset_color);
+  gen_group_get_name(inst),
+  gen_group_get_length(inst, p),
+  "",

The 80 columns of color here don't line up nicely anymore. Maybe just
take it out so it doesn't wrap narrower terminals. The color stands out
on its own well enough IMO. (Or you could do the math to make it line up
again if you feel like it, whatever).


Yeah, I think I'll just drop this patch. Now that I have the UI, I'm not 
using the text version of aubinator very much.





+  reset_color);
  
if (option_full_decode) {

   decode_group(inst, p, 0);
--
2.15.0.rc2

___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev



___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 09/33] aubinator: print number of dwords per instruction

2017-10-31 Thread Scott D Phillips 
Lionel Landwerlin  writes:

> Signed-off-by: Lionel Landwerlin 
> ---
>  src/intel/tools/aubinator.c | 7 +--
>  1 file changed, 5 insertions(+), 2 deletions(-)
>
> diff --git a/src/intel/tools/aubinator.c b/src/intel/tools/aubinator.c
> index 48d4456cc16..2c4eaab1701 100644
> --- a/src/intel/tools/aubinator.c
> +++ b/src/intel/tools/aubinator.c
> @@ -729,9 +729,12 @@ parse_commands(struct gen_spec *spec, uint32_t *cmds, 
> int size, int engine)
>else
>   offset = 0;
>  
> -  fprintf(outfile, "%s0x%08"PRIx64":  0x%08x:  %-80s%s\n",
> +  fprintf(outfile, "%s0x%08"PRIx64":  0x%08x:  %s (%i Dwords) %-80s 
> %s\n",
>color, offset, p[0],
> -  gen_group_get_name(inst), reset_color);
> +  gen_group_get_name(inst),
> +  gen_group_get_length(inst, p),
> +  "",

The 80 columns of color here don't line up nicely anymore. Maybe just
take it out so it doesn't wrap narrower terminals. The color stands out
on its own well enough IMO. (Or you could do the math to make it line up
again if you feel like it, whatever).

> +  reset_color);
>  
>if (option_full_decode) {
>   decode_group(inst, p, 0);
> -- 
> 2.15.0.rc2
>
> ___
> mesa-dev mailing list
> mesa-dev@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [PATCH 09/33] aubinator: print number of dwords per instruction

2017-10-30 Thread Lionel Landwerlin 
Signed-off-by: Lionel Landwerlin 
---
 src/intel/tools/aubinator.c | 7 +--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/src/intel/tools/aubinator.c b/src/intel/tools/aubinator.c
index 48d4456cc16..2c4eaab1701 100644
--- a/src/intel/tools/aubinator.c
+++ b/src/intel/tools/aubinator.c
@@ -729,9 +729,12 @@ parse_commands(struct gen_spec *spec, uint32_t *cmds, int 
size, int engine)
   else
  offset = 0;
 
-  fprintf(outfile, "%s0x%08"PRIx64":  0x%08x:  %-80s%s\n",
+  fprintf(outfile, "%s0x%08"PRIx64":  0x%08x:  %s (%i Dwords) %-80s %s\n",
   color, offset, p[0],
-  gen_group_get_name(inst), reset_color);
+  gen_group_get_name(inst),
+  gen_group_get_length(inst, p),
+  "",
+  reset_color);
 
   if (option_full_decode) {
  decode_group(inst, p, 0);
-- 
2.15.0.rc2

___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev