Re: [Mesa-dev] [PATCH 1/1] r600, llvm: Fix mem leak
On Mon, Dec 01, 2014 at 06:33:10PM -0500, Jan Vesely wrote: > ping I've pushed this, thanks. -Tom > > On Mon, 2014-11-03 at 20:29 -0500, Jan Vesely wrote: > > Signed-off-by: Jan Vesely > > --- > > src/gallium/drivers/r600/r600_llvm.c | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/src/gallium/drivers/r600/r600_llvm.c > > b/src/gallium/drivers/r600/r600_llvm.c > > index c19693a..5f74bf7 100644 > > --- a/src/gallium/drivers/r600/r600_llvm.c > > +++ b/src/gallium/drivers/r600/r600_llvm.c > > @@ -888,6 +888,7 @@ unsigned r600_llvm_compile( > > > > FREE(binary.code); > > FREE(binary.config); > > + FREE(binary.rodata); > > > > return r; > > } > > -- > Jan Vesely > ___ > mesa-dev mailing list > mesa-dev@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/mesa-dev ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
Re: [Mesa-dev] [PATCH 1/1] r600, llvm: Fix mem leak
I like it, but one thing I'd like to request... Can you check to make sure that radeon_shader_binary.global_symbol_offsets isn't also leaked? If so, let's fix that as well. If that's not getting leaked, then it looks good to me. --Aaron On Mon, Dec 1, 2014 at 5:33 PM, Jan Vesely wrote: > ping > > On Mon, 2014-11-03 at 20:29 -0500, Jan Vesely wrote: >> Signed-off-by: Jan Vesely >> --- >> src/gallium/drivers/r600/r600_llvm.c | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/src/gallium/drivers/r600/r600_llvm.c >> b/src/gallium/drivers/r600/r600_llvm.c >> index c19693a..5f74bf7 100644 >> --- a/src/gallium/drivers/r600/r600_llvm.c >> +++ b/src/gallium/drivers/r600/r600_llvm.c >> @@ -888,6 +888,7 @@ unsigned r600_llvm_compile( >> >> FREE(binary.code); >> FREE(binary.config); >> + FREE(binary.rodata); >> >> return r; >> } > > -- > Jan Vesely > > ___ > mesa-dev mailing list > mesa-dev@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/mesa-dev > ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
Re: [Mesa-dev] [PATCH 1/1] r600, llvm: Fix mem leak
ping On Mon, 2014-11-03 at 20:29 -0500, Jan Vesely wrote: > Signed-off-by: Jan Vesely > --- > src/gallium/drivers/r600/r600_llvm.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/src/gallium/drivers/r600/r600_llvm.c > b/src/gallium/drivers/r600/r600_llvm.c > index c19693a..5f74bf7 100644 > --- a/src/gallium/drivers/r600/r600_llvm.c > +++ b/src/gallium/drivers/r600/r600_llvm.c > @@ -888,6 +888,7 @@ unsigned r600_llvm_compile( > > FREE(binary.code); > FREE(binary.config); > + FREE(binary.rodata); > > return r; > } -- Jan Vesely signature.asc Description: This is a digitally signed message part ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
[Mesa-dev] [PATCH 1/1] r600, llvm: Fix mem leak
Signed-off-by: Jan Vesely --- src/gallium/drivers/r600/r600_llvm.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/gallium/drivers/r600/r600_llvm.c b/src/gallium/drivers/r600/r600_llvm.c index c19693a..5f74bf7 100644 --- a/src/gallium/drivers/r600/r600_llvm.c +++ b/src/gallium/drivers/r600/r600_llvm.c @@ -888,6 +888,7 @@ unsigned r600_llvm_compile( FREE(binary.code); FREE(binary.config); + FREE(binary.rodata); return r; } -- 1.9.3 ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
