Re: [Mesa-dev] [PATCH 1/1] r600: upload implicit arguments even if there are no explicit args

2015-01-22 Thread Jan Vesely 
On Tue, 2014-12-02 at 14:52 -0500, Jan Vesely wrote:
 On Tue, 2014-12-02 at 11:33 -0500, Tom Stellard wrote:
  On Mon, Nov 03, 2014 at 08:29:37PM -0500, Jan Vesely wrote:
   Signed-off-by: Jan Vesely jan.ves...@rutgers.edu
   ---
   
   moreover, the condition is never true now that clover appends dim info
   
src/gallium/drivers/r600/evergreen_compute.c | 4 
1 file changed, 4 deletions(-)
   
   diff --git a/src/gallium/drivers/r600/evergreen_compute.c 
   b/src/gallium/drivers/r600/evergreen_compute.c
   index 90fdd79..41dc93e 100644
   --- a/src/gallium/drivers/r600/evergreen_compute.c
   +++ b/src/gallium/drivers/r600/evergreen_compute.c
   @@ -295,10 +295,6 @@ void evergreen_compute_upload_input(
 struct pipe_box box;
 struct pipe_transfer *transfer = NULL;

   - if (shader-input_size == 0) {
   - return;
   - }
   -
  
  We shouldn't rely on clover specific behavior, because in theory there
  could be other state trackers.
 
 right, I should probably drop that comment from commit message.
 Other than that, is there a reason to skip uploading driver arguments if
 there are no state tracker ones?

ping.
without that comment (it won't show in the commit message anyway), is
there a reason to ever skip uploading implicit args?
to be honest I have hard time imagining possible use of kernels with no
arguments, as there's no way they can produce any output, or am I
missing something?

jan

 
 jan
 
  
  -Tom
  
 if (!shader-kernel_param) {
 /* Add space for the grid dimensions */
 shader-kernel_param = (struct r600_resource *)
   -- 
   1.9.3
   
   ___
   mesa-dev mailing list
   mesa-dev@lists.freedesktop.org
   http://lists.freedesktop.org/mailman/listinfo/mesa-dev
 

-- 
Jan Vesely jan.ves...@rutgers.edu


signature.asc
Description: This is a digitally signed message part
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 1/1] r600: upload implicit arguments even if there are no explicit args

2014-12-02 Thread Tom Stellard 
On Mon, Nov 03, 2014 at 08:29:37PM -0500, Jan Vesely wrote:
 Signed-off-by: Jan Vesely jan.ves...@rutgers.edu
 ---
 
 moreover, the condition is never true now that clover appends dim info
 
  src/gallium/drivers/r600/evergreen_compute.c | 4 
  1 file changed, 4 deletions(-)
 
 diff --git a/src/gallium/drivers/r600/evergreen_compute.c 
 b/src/gallium/drivers/r600/evergreen_compute.c
 index 90fdd79..41dc93e 100644
 --- a/src/gallium/drivers/r600/evergreen_compute.c
 +++ b/src/gallium/drivers/r600/evergreen_compute.c
 @@ -295,10 +295,6 @@ void evergreen_compute_upload_input(
   struct pipe_box box;
   struct pipe_transfer *transfer = NULL;
  
 - if (shader-input_size == 0) {
 - return;
 - }
 -

We shouldn't rely on clover specific behavior, because in theory there
could be other state trackers.

-Tom

   if (!shader-kernel_param) {
   /* Add space for the grid dimensions */
   shader-kernel_param = (struct r600_resource *)
 -- 
 1.9.3
 
 ___
 mesa-dev mailing list
 mesa-dev@lists.freedesktop.org
 http://lists.freedesktop.org/mailman/listinfo/mesa-dev
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 1/1] r600: upload implicit arguments even if there are no explicit args

2014-12-02 Thread Jan Vesely 
On Tue, 2014-12-02 at 11:33 -0500, Tom Stellard wrote:
 On Mon, Nov 03, 2014 at 08:29:37PM -0500, Jan Vesely wrote:
  Signed-off-by: Jan Vesely jan.ves...@rutgers.edu
  ---
  
  moreover, the condition is never true now that clover appends dim info
  
   src/gallium/drivers/r600/evergreen_compute.c | 4 
   1 file changed, 4 deletions(-)
  
  diff --git a/src/gallium/drivers/r600/evergreen_compute.c 
  b/src/gallium/drivers/r600/evergreen_compute.c
  index 90fdd79..41dc93e 100644
  --- a/src/gallium/drivers/r600/evergreen_compute.c
  +++ b/src/gallium/drivers/r600/evergreen_compute.c
  @@ -295,10 +295,6 @@ void evergreen_compute_upload_input(
  struct pipe_box box;
  struct pipe_transfer *transfer = NULL;
   
  -   if (shader-input_size == 0) {
  -   return;
  -   }
  -
 
 We shouldn't rely on clover specific behavior, because in theory there
 could be other state trackers.

right, I should probably drop that comment from commit message.
Other than that, is there a reason to skip uploading driver arguments if
there are no state tracker ones?

jan

 
 -Tom
 
  if (!shader-kernel_param) {
  /* Add space for the grid dimensions */
  shader-kernel_param = (struct r600_resource *)
  -- 
  1.9.3
  
  ___
  mesa-dev mailing list
  mesa-dev@lists.freedesktop.org
  http://lists.freedesktop.org/mailman/listinfo/mesa-dev

-- 
Jan Vesely jan.ves...@rutgers.edu


signature.asc
Description: This is a digitally signed message part
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 1/1] r600: upload implicit arguments even if there are no explicit args

2014-11-18 Thread Jan Vesely 
ping

On Mon, 2014-11-03 at 20:29 -0500, Jan Vesely wrote:
 Signed-off-by: Jan Vesely jan.ves...@rutgers.edu
 ---
 
 moreover, the condition is never true now that clover appends dim info
 
  src/gallium/drivers/r600/evergreen_compute.c | 4 
  1 file changed, 4 deletions(-)
 
 diff --git a/src/gallium/drivers/r600/evergreen_compute.c 
 b/src/gallium/drivers/r600/evergreen_compute.c
 index 90fdd79..41dc93e 100644
 --- a/src/gallium/drivers/r600/evergreen_compute.c
 +++ b/src/gallium/drivers/r600/evergreen_compute.c
 @@ -295,10 +295,6 @@ void evergreen_compute_upload_input(
   struct pipe_box box;
   struct pipe_transfer *transfer = NULL;
  
 - if (shader-input_size == 0) {
 - return;
 - }
 -
   if (!shader-kernel_param) {
   /* Add space for the grid dimensions */
   shader-kernel_param = (struct r600_resource *)

-- 
Jan Vesely jan.ves...@rutgers.edu


signature.asc
Description: This is a digitally signed message part
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [PATCH 1/1] r600: upload implicit arguments even if there are no explicit args

2014-11-03 Thread Jan Vesely 
Signed-off-by: Jan Vesely jan.ves...@rutgers.edu
---

moreover, the condition is never true now that clover appends dim info

 src/gallium/drivers/r600/evergreen_compute.c | 4 
 1 file changed, 4 deletions(-)

diff --git a/src/gallium/drivers/r600/evergreen_compute.c 
b/src/gallium/drivers/r600/evergreen_compute.c
index 90fdd79..41dc93e 100644
--- a/src/gallium/drivers/r600/evergreen_compute.c
+++ b/src/gallium/drivers/r600/evergreen_compute.c
@@ -295,10 +295,6 @@ void evergreen_compute_upload_input(
struct pipe_box box;
struct pipe_transfer *transfer = NULL;
 
-   if (shader-input_size == 0) {
-   return;
-   }
-
if (!shader-kernel_param) {
/* Add space for the grid dimensions */
shader-kernel_param = (struct r600_resource *)
-- 
1.9.3

___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev