[Mesa-dev] [PATCH 1/2] clover: Call end_query before getting timestamp result v2

[Tom Stellard]

v2:
  - Move the end_query() call into the timestamp constructor.
  - Still pass false as the wait parameter to get_query_result().
---
 src/gallium/state_trackers/clover/core/timestamp.cpp | 1 +
 1 file changed, 1 insertion(+)

diff --git a/src/gallium/state_trackers/clover/core/timestamp.cpp 
b/src/gallium/state_trackers/clover/core/timestamp.cpp
index 481c4f9..3fd341f 100644
--- a/src/gallium/state_trackers/clover/core/timestamp.cpp
+++ b/src/gallium/state_trackers/clover/core/timestamp.cpp
@@ -30,6 +30,7 @@ using namespace clover;
 timestamp::query::query(command_queue &q) :
q(q),
_query(q.pipe->create_query(q.pipe, PIPE_QUERY_TIMESTAMP, 0)) {
+   q.pipe->end_query(q.pipe, _query);
 }
 
 timestamp::query::query(query &&other) :
-- 
1.8.1.5

___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 1/2] clover: Call end_query before getting timestamp result v2

[Niels Ole Salscheider]

Reviewed-by: Niels Ole Salscheider 

On Wednesday 16 July 2014, 17:37:48, Tom Stellard wrote:
> v2:
>   - Move the end_query() call into the timestamp constructor.
>   - Still pass false as the wait parameter to get_query_result().
> ---
>  src/gallium/state_trackers/clover/core/timestamp.cpp | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/src/gallium/state_trackers/clover/core/timestamp.cpp
> b/src/gallium/state_trackers/clover/core/timestamp.cpp index
> 481c4f9..3fd341f 100644
> --- a/src/gallium/state_trackers/clover/core/timestamp.cpp
> +++ b/src/gallium/state_trackers/clover/core/timestamp.cpp
> @@ -30,6 +30,7 @@ using namespace clover;
>  timestamp::query::query(command_queue &q) :
> q(q),
> _query(q.pipe->create_query(q.pipe, PIPE_QUERY_TIMESTAMP, 0)) {
> +   q.pipe->end_query(q.pipe, _query);
>  }
> 
>  timestamp::query::query(query &&other) :
> --
> 1.8.1.5

___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 1/2] clover: Call end_query before getting timestamp result v2

[Francisco Jerez]

Tom Stellard  writes:

> v2:
>   - Move the end_query() call into the timestamp constructor.
>   - Still pass false as the wait parameter to get_query_result().

Reviewed-by: Francisco Jerez 

> ---
>  src/gallium/state_trackers/clover/core/timestamp.cpp | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/src/gallium/state_trackers/clover/core/timestamp.cpp 
> b/src/gallium/state_trackers/clover/core/timestamp.cpp
> index 481c4f9..3fd341f 100644
> --- a/src/gallium/state_trackers/clover/core/timestamp.cpp
> +++ b/src/gallium/state_trackers/clover/core/timestamp.cpp
> @@ -30,6 +30,7 @@ using namespace clover;
>  timestamp::query::query(command_queue &q) :
> q(q),
> _query(q.pipe->create_query(q.pipe, PIPE_QUERY_TIMESTAMP, 0)) {
> +   q.pipe->end_query(q.pipe, _query);
>  }
>  
>  timestamp::query::query(query &&other) :
> -- 
> 1.8.1.5


pgp6BHrKR3yXH.pgp
Description: PGP signature
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev