Re: [Mesa-dev] [PATCH 1/3] i965/vec4: Don't return void from a void function.

[Ian Romanick]

Series is

Reviewed-by: Ian Romanick 

On 06/23/2014 01:30 PM, Matt Turner wrote:
> ---
>  src/mesa/drivers/dri/i965/brw_vec4_visitor.cpp | 8 
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/src/mesa/drivers/dri/i965/brw_vec4_visitor.cpp 
> b/src/mesa/drivers/dri/i965/brw_vec4_visitor.cpp
> index 7fd8c2b..f3316f8 100644
> --- a/src/mesa/drivers/dri/i965/brw_vec4_visitor.cpp
> +++ b/src/mesa/drivers/dri/i965/brw_vec4_visitor.cpp
> @@ -366,9 +366,9 @@ vec4_visitor::emit_math(opcode opcode, dst_reg dst, 
> src_reg src)
> }
>  
> if (brw->gen >= 6) {
> -  return emit_math1_gen6(opcode, dst, src);
> +  emit_math1_gen6(opcode, dst, src);
> } else {
> -  return emit_math1_gen4(opcode, dst, src);
> +  emit_math1_gen4(opcode, dst, src);
> }
>  }
>  
> @@ -418,9 +418,9 @@ vec4_visitor::emit_math(enum opcode opcode,
> }
>  
> if (brw->gen >= 6) {
> -  return emit_math2_gen6(opcode, dst, src0, src1);
> +  emit_math2_gen6(opcode, dst, src0, src1);
> } else {
> -  return emit_math2_gen4(opcode, dst, src0, src1);
> +  emit_math2_gen4(opcode, dst, src0, src1);
> }
>  }
>  
> 

___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [PATCH 1/3] i965/vec4: Don't return void from a void function.

[Matt Turner]

---
 src/mesa/drivers/dri/i965/brw_vec4_visitor.cpp | 8 
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/mesa/drivers/dri/i965/brw_vec4_visitor.cpp 
b/src/mesa/drivers/dri/i965/brw_vec4_visitor.cpp
index 7fd8c2b..f3316f8 100644
--- a/src/mesa/drivers/dri/i965/brw_vec4_visitor.cpp
+++ b/src/mesa/drivers/dri/i965/brw_vec4_visitor.cpp
@@ -366,9 +366,9 @@ vec4_visitor::emit_math(opcode opcode, dst_reg dst, src_reg 
src)
}
 
if (brw->gen >= 6) {
-  return emit_math1_gen6(opcode, dst, src);
+  emit_math1_gen6(opcode, dst, src);
} else {
-  return emit_math1_gen4(opcode, dst, src);
+  emit_math1_gen4(opcode, dst, src);
}
 }
 
@@ -418,9 +418,9 @@ vec4_visitor::emit_math(enum opcode opcode,
}
 
if (brw->gen >= 6) {
-  return emit_math2_gen6(opcode, dst, src0, src1);
+  emit_math2_gen6(opcode, dst, src0, src1);
} else {
-  return emit_math2_gen4(opcode, dst, src0, src1);
+  emit_math2_gen4(opcode, dst, src0, src1);
}
 }
 
-- 
1.8.3.2

___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev