Re: [Mesa-dev] [PATCH 1/4] mesa: enable ARB_direct_state_access in compat for GL3.1+

2018-08-27 Thread Marek Olšák 
_mesa_VertexArrayVertexBuffer_no_error crashes if vaobj == 0.
_mesa_VertexArrayVertexBuffer doesn't have this issue.

Marek

On Fri, Aug 24, 2018 at 7:06 AM, Timothy Arceri  wrote:
> We could enable it for lower versions of GL but this allows us
> to just use the existing version/extension checks that are already
> used by the core profile.
> ---
>  src/mapi/glapi/gen/apiexec.py| 194 +++
>  src/mesa/main/extensions_table.h |   2 +-
>  src/mesa/main/fbobject.c |  13 ++-
>  3 files changed, 105 insertions(+), 104 deletions(-)
>
> diff --git a/src/mapi/glapi/gen/apiexec.py b/src/mapi/glapi/gen/apiexec.py
> index b163d88549b..e2fc124be22 100644
> --- a/src/mapi/glapi/gen/apiexec.py
> +++ b/src/mapi/glapi/gen/apiexec.py
> @@ -152,103 +152,103 @@ functions = {
>
>  # OpenGL 4.5 / GL_ARB_direct_state_access.   Mesa can expose the 
> extension
>  # with core profile.
> -"CreateTransformFeedbacks": exec_info(compatibility=45, core=31),
> -"TransformFeedbackBufferBase": exec_info(compatibility=45, core=31),
> -"TransformFeedbackBufferRange": exec_info(compatibility=45, core=31),
> -"GetTransformFeedbackiv": exec_info(compatibility=45, core=31),
> -"GetTransformFeedbacki_v": exec_info(compatibility=45, core=31),
> -"GetTransformFeedbacki64_v": exec_info(compatibility=45, core=31),
> -"CreateBuffers": exec_info(compatibility=45, core=31),
> -"NamedBufferStorage": exec_info(compatibility=45, core=31),
> -"NamedBufferData": exec_info(compatibility=45, core=31),
> -"NamedBufferSubData": exec_info(compatibility=45, core=31),
> -"CopyNamedBufferSubData": exec_info(compatibility=45, core=31),
> -"ClearNamedBufferData": exec_info(compatibility=45, core=31),
> -"ClearNamedBufferSubData": exec_info(compatibility=45, core=31),
> -"MapNamedBuffer": exec_info(compatibility=45, core=31),
> -"MapNamedBufferRange": exec_info(compatibility=45, core=31),
> -"UnmapNamedBuffer": exec_info(compatibility=45, core=31),
> -"FlushMappedNamedBufferRange": exec_info(compatibility=45, core=31),
> -"GetNamedBufferParameteriv": exec_info(compatibility=45, core=31),
> -"GetNamedBufferParameteri64v": exec_info(compatibility=45, core=31),
> -"GetNamedBufferPointerv": exec_info(compatibility=45, core=31),
> -"GetNamedBufferSubData": exec_info(compatibility=45, core=31),
> -"CreateFramebuffers": exec_info(compatibility=45, core=31),
> -"NamedFramebufferRenderbuffer": exec_info(compatibility=45, core=31),
> -"NamedFramebufferParameteri": exec_info(compatibility=45, core=31),
> -"NamedFramebufferTexture": exec_info(compatibility=45, core=31),
> -"NamedFramebufferTextureLayer": exec_info(compatibility=45, core=31),
> -"NamedFramebufferDrawBuffer": exec_info(compatibility=45, core=31),
> -"NamedFramebufferDrawBuffers": exec_info(compatibility=45, core=31),
> -"NamedFramebufferReadBuffer": exec_info(compatibility=45, core=31),
> -"InvalidateNamedFramebufferData": exec_info(compatibility=45, core=31),
> -"InvalidateNamedFramebufferSubData": exec_info(compatibility=45, 
> core=31),
> -"ClearNamedFramebufferiv": exec_info(compatibility=45, core=31),
> -"ClearNamedFramebufferuiv": exec_info(compatibility=45, core=31),
> -"ClearNamedFramebufferfv": exec_info(compatibility=45, core=31),
> -"ClearNamedFramebufferfi": exec_info(compatibility=45, core=31),
> -"BlitNamedFramebuffer": exec_info(compatibility=45, core=31),
> -"CheckNamedFramebufferStatus": exec_info(compatibility=45, core=31),
> -"GetNamedFramebufferParameteriv": exec_info(compatibility=45, core=31),
> -"GetNamedFramebufferAttachmentParameteriv": exec_info(compatibility=45, 
> core=31),
> -"CreateRenderbuffers": exec_info(compatibility=45, core=31),
> -"NamedRenderbufferStorage": exec_info(compatibility=45, core=31),
> -"NamedRenderbufferStorageMultisample": exec_info(compatibility=45, 
> core=31),
> -"GetNamedRenderbufferParameteriv": exec_info(compatibility=45, core=31),
> -"CreateTextures": exec_info(compatibility=45, core=31),
> -"TextureBuffer": exec_info(compatibility=45, core=31),
> -"TextureBufferRange": exec_info(compatibility=45, core=31),
> -"TextureStorage1D": exec_info(compatibility=45, core=31),
> -"TextureStorage2D": exec_info(compatibility=45, core=31),
> -"TextureStorage3D": exec_info(compatibility=45, core=31),
> -"TextureStorage2DMultisample": exec_info(compatibility=45, core=31),
> -"TextureStorage3DMultisample": exec_info(compatibility=45, core=31),
> -"TextureSubImage1D": exec_info(compatibility=45, core=31),
> -"TextureSubImage2D": exec_info(compatibility=45, core=31),
> -"TextureSubImage3D": exec_info(compatibility=45, core=31),
> -"CompressedTextureSubImage1D": exec_info(compatibility=45, core=31),
> -"CompressedTextureSubImage2D": exec_info(compatibility=45, core=31),
> -"CompressedTextureSubImage3D":

[Mesa-dev] [PATCH 1/4] mesa: enable ARB_direct_state_access in compat for GL3.1+

2018-08-24 Thread Timothy Arceri 
We could enable it for lower versions of GL but this allows us
to just use the existing version/extension checks that are already
used by the core profile.
---
 src/mapi/glapi/gen/apiexec.py| 194 +++
 src/mesa/main/extensions_table.h |   2 +-
 src/mesa/main/fbobject.c |  13 ++-
 3 files changed, 105 insertions(+), 104 deletions(-)

diff --git a/src/mapi/glapi/gen/apiexec.py b/src/mapi/glapi/gen/apiexec.py
index b163d88549b..e2fc124be22 100644
--- a/src/mapi/glapi/gen/apiexec.py
+++ b/src/mapi/glapi/gen/apiexec.py
@@ -152,103 +152,103 @@ functions = {
 
 # OpenGL 4.5 / GL_ARB_direct_state_access.   Mesa can expose the extension
 # with core profile.
-"CreateTransformFeedbacks": exec_info(compatibility=45, core=31),
-"TransformFeedbackBufferBase": exec_info(compatibility=45, core=31),
-"TransformFeedbackBufferRange": exec_info(compatibility=45, core=31),
-"GetTransformFeedbackiv": exec_info(compatibility=45, core=31),
-"GetTransformFeedbacki_v": exec_info(compatibility=45, core=31),
-"GetTransformFeedbacki64_v": exec_info(compatibility=45, core=31),
-"CreateBuffers": exec_info(compatibility=45, core=31),
-"NamedBufferStorage": exec_info(compatibility=45, core=31),
-"NamedBufferData": exec_info(compatibility=45, core=31),
-"NamedBufferSubData": exec_info(compatibility=45, core=31),
-"CopyNamedBufferSubData": exec_info(compatibility=45, core=31),
-"ClearNamedBufferData": exec_info(compatibility=45, core=31),
-"ClearNamedBufferSubData": exec_info(compatibility=45, core=31),
-"MapNamedBuffer": exec_info(compatibility=45, core=31),
-"MapNamedBufferRange": exec_info(compatibility=45, core=31),
-"UnmapNamedBuffer": exec_info(compatibility=45, core=31),
-"FlushMappedNamedBufferRange": exec_info(compatibility=45, core=31),
-"GetNamedBufferParameteriv": exec_info(compatibility=45, core=31),
-"GetNamedBufferParameteri64v": exec_info(compatibility=45, core=31),
-"GetNamedBufferPointerv": exec_info(compatibility=45, core=31),
-"GetNamedBufferSubData": exec_info(compatibility=45, core=31),
-"CreateFramebuffers": exec_info(compatibility=45, core=31),
-"NamedFramebufferRenderbuffer": exec_info(compatibility=45, core=31),
-"NamedFramebufferParameteri": exec_info(compatibility=45, core=31),
-"NamedFramebufferTexture": exec_info(compatibility=45, core=31),
-"NamedFramebufferTextureLayer": exec_info(compatibility=45, core=31),
-"NamedFramebufferDrawBuffer": exec_info(compatibility=45, core=31),
-"NamedFramebufferDrawBuffers": exec_info(compatibility=45, core=31),
-"NamedFramebufferReadBuffer": exec_info(compatibility=45, core=31),
-"InvalidateNamedFramebufferData": exec_info(compatibility=45, core=31),
-"InvalidateNamedFramebufferSubData": exec_info(compatibility=45, core=31),
-"ClearNamedFramebufferiv": exec_info(compatibility=45, core=31),
-"ClearNamedFramebufferuiv": exec_info(compatibility=45, core=31),
-"ClearNamedFramebufferfv": exec_info(compatibility=45, core=31),
-"ClearNamedFramebufferfi": exec_info(compatibility=45, core=31),
-"BlitNamedFramebuffer": exec_info(compatibility=45, core=31),
-"CheckNamedFramebufferStatus": exec_info(compatibility=45, core=31),
-"GetNamedFramebufferParameteriv": exec_info(compatibility=45, core=31),
-"GetNamedFramebufferAttachmentParameteriv": exec_info(compatibility=45, 
core=31),
-"CreateRenderbuffers": exec_info(compatibility=45, core=31),
-"NamedRenderbufferStorage": exec_info(compatibility=45, core=31),
-"NamedRenderbufferStorageMultisample": exec_info(compatibility=45, 
core=31),
-"GetNamedRenderbufferParameteriv": exec_info(compatibility=45, core=31),
-"CreateTextures": exec_info(compatibility=45, core=31),
-"TextureBuffer": exec_info(compatibility=45, core=31),
-"TextureBufferRange": exec_info(compatibility=45, core=31),
-"TextureStorage1D": exec_info(compatibility=45, core=31),
-"TextureStorage2D": exec_info(compatibility=45, core=31),
-"TextureStorage3D": exec_info(compatibility=45, core=31),
-"TextureStorage2DMultisample": exec_info(compatibility=45, core=31),
-"TextureStorage3DMultisample": exec_info(compatibility=45, core=31),
-"TextureSubImage1D": exec_info(compatibility=45, core=31),
-"TextureSubImage2D": exec_info(compatibility=45, core=31),
-"TextureSubImage3D": exec_info(compatibility=45, core=31),
-"CompressedTextureSubImage1D": exec_info(compatibility=45, core=31),
-"CompressedTextureSubImage2D": exec_info(compatibility=45, core=31),
-"CompressedTextureSubImage3D": exec_info(compatibility=45, core=31),
-"CopyTextureSubImage1D": exec_info(compatibility=45, core=31),
-"CopyTextureSubImage2D": exec_info(compatibility=45, core=31),
-"CopyTextureSubImage3D": exec_info(compatibility=45, core=31),
-"TextureParameterf": exec_info(compatibility=45, core=31),
-"TextureParameterfv":