Re: [Mesa-dev] [PATCH 11/64] isl/state: Remove some unused fields
On Thu 16 Jun 2016, Jason Ekstrand wrote: > On Thu, Jun 16, 2016 at 10:14 AM, Chad Versace > wrote: > > > On Sat 11 Jun 2016, Jason Ekstrand wrote: > > > They're already zero-initialized and we have no plans of doing anything > > > more interesting with them. > > > --- > > > src/intel/isl/isl_surface_state.c | 9 - > > > 1 file changed, 9 deletions(-) > > > > > > > > > @@ -261,12 +258,6 @@ isl_genX(surf_fill_state_s)(const struct isl_device > > *dev, void *state, > > > s.MultisampledSurfaceStorageFormat = > > >isl_to_gen_multisample_layout[info->surf->msaa_layout]; > > > s.NumberofMultisamples = ffs(info->surf->samples) - 1; > > > - s.MultisamplePositionPaletteIndex = 0; /* UNUSED */ > > > - > > > - s.XOffset = 0; > > > - s.YOffset = 0; > > > > Wait. Seriously? i965 no longer uses XOffset/YOffset on *any* gen!?!?!? > > When did that happen? I've been waiting for years for i965 to stop using > > XOffset/YOffset on old hardware, but obviously I wasn't paying enough > > attention to the git logs. > > > > Nope. Further on I add them back in for real. I haven't yet reached the patch that adds them back. Be aware that these fields are buggy on Haswell. ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
Re: [Mesa-dev] [PATCH 11/64] isl/state: Remove some unused fields
On Thu 16 Jun 2016, Chad Versace wrote: > On Sat 11 Jun 2016, Jason Ekstrand wrote: > > They're already zero-initialized and we have no plans of doing anything > > more interesting with them. > > --- > > src/intel/isl/isl_surface_state.c | 9 - > > 1 file changed, 9 deletions(-) > > > > > @@ -261,12 +258,6 @@ isl_genX(surf_fill_state_s)(const struct isl_device > > *dev, void *state, > > s.MultisampledSurfaceStorageFormat = > >isl_to_gen_multisample_layout[info->surf->msaa_layout]; > > s.NumberofMultisamples = ffs(info->surf->samples) - 1; > > - s.MultisamplePositionPaletteIndex = 0; /* UNUSED */ > > - > > - s.XOffset = 0; > > - s.YOffset = 0; > > Wait. Seriously? i965 no longer uses XOffset/YOffset on *any* gen!?!?!? > When did that happen? I've been waiting for years for i965 to stop using > XOffset/YOffset on old hardware, but obviously I wasn't paying enough > attention to the git logs. I found the commit: commit b1080cfbdb0a084122fcd662cd27b4748c5598fd Author: Eric Anholt Date: Wed Aug 28 11:53:09 2013 -0700 Subject: i965: Switch gen4-6 to using the sampler's base level for GL BASE_LEVEL. This patch is Reviewed-by: Chad Versace ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
Re: [Mesa-dev] [PATCH 11/64] isl/state: Remove some unused fields
On Thu, Jun 16, 2016 at 10:14 AM, Chad Versace wrote: > On Sat 11 Jun 2016, Jason Ekstrand wrote: > > They're already zero-initialized and we have no plans of doing anything > > more interesting with them. > > --- > > src/intel/isl/isl_surface_state.c | 9 - > > 1 file changed, 9 deletions(-) > > > > > @@ -261,12 +258,6 @@ isl_genX(surf_fill_state_s)(const struct isl_device > *dev, void *state, > > s.MultisampledSurfaceStorageFormat = > >isl_to_gen_multisample_layout[info->surf->msaa_layout]; > > s.NumberofMultisamples = ffs(info->surf->samples) - 1; > > - s.MultisamplePositionPaletteIndex = 0; /* UNUSED */ > > - > > - s.XOffset = 0; > > - s.YOffset = 0; > > Wait. Seriously? i965 no longer uses XOffset/YOffset on *any* gen!?!?!? > When did that happen? I've been waiting for years for i965 to stop using > XOffset/YOffset on old hardware, but obviously I wasn't paying enough > attention to the git logs. > Nope. Further on I add them back in for real. ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
Re: [Mesa-dev] [PATCH 11/64] isl/state: Remove some unused fields
On Sat 11 Jun 2016, Jason Ekstrand wrote: > They're already zero-initialized and we have no plans of doing anything > more interesting with them. > --- > src/intel/isl/isl_surface_state.c | 9 - > 1 file changed, 9 deletions(-) > @@ -261,12 +258,6 @@ isl_genX(surf_fill_state_s)(const struct isl_device > *dev, void *state, > s.MultisampledSurfaceStorageFormat = >isl_to_gen_multisample_layout[info->surf->msaa_layout]; > s.NumberofMultisamples = ffs(info->surf->samples) - 1; > - s.MultisamplePositionPaletteIndex = 0; /* UNUSED */ > - > - s.XOffset = 0; > - s.YOffset = 0; Wait. Seriously? i965 no longer uses XOffset/YOffset on *any* gen!?!?!? When did that happen? I've been waiting for years for i965 to stop using XOffset/YOffset on old hardware, but obviously I wasn't paying enough attention to the git logs. ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
[Mesa-dev] [PATCH 11/64] isl/state: Remove some unused fields
They're already zero-initialized and we have no plans of doing anything more interesting with them. --- src/intel/isl/isl_surface_state.c | 9 - 1 file changed, 9 deletions(-) diff --git a/src/intel/isl/isl_surface_state.c b/src/intel/isl/isl_surface_state.c index ae8096f..c36ef3b 100644 --- a/src/intel/isl/isl_surface_state.c +++ b/src/intel/isl/isl_surface_state.c @@ -218,9 +218,6 @@ isl_genX(surf_fill_state_s)(const struct isl_device *dev, void *state, TILEWALK_YMAJOR; #endif - s.VerticalLineStride = 0; - s.VerticalLineStrideOffset = 0; - #if (GEN_GEN == 7) s.SurfaceArraySpacing = info->surf->array_pitch_span == ISL_ARRAY_PITCH_SPAN_COMPACT; @@ -261,12 +258,6 @@ isl_genX(surf_fill_state_s)(const struct isl_device *dev, void *state, s.MultisampledSurfaceStorageFormat = isl_to_gen_multisample_layout[info->surf->msaa_layout]; s.NumberofMultisamples = ffs(info->surf->samples) - 1; - s.MultisamplePositionPaletteIndex = 0; /* UNUSED */ - - s.XOffset = 0; - s.YOffset = 0; - - s.ResourceMinLOD = 0.0; s.MIPCountLOD = 0; /* TEMPLATE */ s.SurfaceMinLOD = 0; /* TEMPLATE */ -- 2.5.0.400.gff86faf ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
