Re: [Mesa-dev] [PATCH 2/2] anv/i965: drop libdrm_intel dependency completely

2017-06-15 Thread Lionel Landwerlin 

On 15/06/17 09:45, Emil Velikov wrote:

Hi Lionel,

Final reminder - doing this will throw a wrench into non-Linux
platforms which want to use Mesa.

On those the kernel vs libdrm copy of the headers have diverged and
while I'm nudging with the guys to get that sorted, the extra copy is
a recipe for disaster.

On 15 June 2017 at 01:22, Lionel Landwerlin
 wrote:

With Ken's work to drop the library dependency on libdrm_intel, we now
only depend on libdrm for the kernel uapi headers it provides. It
seems like we're better off just embeddeding those headers ourselves,
making the lives of people developping news features tightly
integrated with the kernel a tiny bit easier.

This change also makes it a bit more obvious what cflags/libs are
required by the i915 drivers vs i965, by renaming INTEL_CFLAGS/LIBS
into I915_CFLAGS/LIBS.


This should be a separate commit.


Sure.




Headers were generated from drm-tip on the following commit :

commit cafd1e4df1e6e039268c4e4b1a55c88915d21f2e
Author: Rodrigo Vivi 
Date:   Wed Jun 14 12:56:57 2017 -0700

drm-tip: 2017y-06m-14d-19h-56m-24s UTC integration manifest

v2: Use installed files from the kernel (Daniel Vetter)

Signed-off-by: Lionel Landwerlin 
---
  configure.ac|6 +-
  src/gallium/drivers/i915/Automake.inc   |2 +-
  src/gallium/targets/pipe-loader/Makefile.am |2 +-
  src/gallium/winsys/i915/drm/Makefile.am |2 +-
  src/intel/Makefile.drm.am   |   22 +
  src/intel/Makefile.sources  |6 +
  src/intel/Makefile.tools.am |3 +-
  src/intel/Makefile.vulkan.am|4 +-
  src/intel/drm/drm.h |  925 +
  src/intel/drm/drm_fourcc.h  |  358 +++
  src/intel/drm/drm_mode.h|  739 ++
  src/intel/drm/i915_drm.h| 1459 +++

You seriously want a README in the folder which described the dos
and/or don'ts of handling the files.


Will do, thanks!



Thanks
Emil
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev



___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 2/2] anv/i965: drop libdrm_intel dependency completely

2017-06-15 Thread Emil Velikov 
Hi Lionel,

Final reminder - doing this will throw a wrench into non-Linux
platforms which want to use Mesa.

On those the kernel vs libdrm copy of the headers have diverged and
while I'm nudging with the guys to get that sorted, the extra copy is
a recipe for disaster.

On 15 June 2017 at 01:22, Lionel Landwerlin
 wrote:
> With Ken's work to drop the library dependency on libdrm_intel, we now
> only depend on libdrm for the kernel uapi headers it provides. It
> seems like we're better off just embeddeding those headers ourselves,
> making the lives of people developping news features tightly
> integrated with the kernel a tiny bit easier.
>
> This change also makes it a bit more obvious what cflags/libs are
> required by the i915 drivers vs i965, by renaming INTEL_CFLAGS/LIBS
> into I915_CFLAGS/LIBS.
>
This should be a separate commit.

> Headers were generated from drm-tip on the following commit :
>
>commit cafd1e4df1e6e039268c4e4b1a55c88915d21f2e
>Author: Rodrigo Vivi 
>Date:   Wed Jun 14 12:56:57 2017 -0700
>
>drm-tip: 2017y-06m-14d-19h-56m-24s UTC integration manifest
>
> v2: Use installed files from the kernel (Daniel Vetter)
>
> Signed-off-by: Lionel Landwerlin 
> ---
>  configure.ac|6 +-
>  src/gallium/drivers/i915/Automake.inc   |2 +-
>  src/gallium/targets/pipe-loader/Makefile.am |2 +-
>  src/gallium/winsys/i915/drm/Makefile.am |2 +-
>  src/intel/Makefile.drm.am   |   22 +
>  src/intel/Makefile.sources  |6 +
>  src/intel/Makefile.tools.am |3 +-
>  src/intel/Makefile.vulkan.am|4 +-
>  src/intel/drm/drm.h |  925 +
>  src/intel/drm/drm_fourcc.h  |  358 +++
>  src/intel/drm/drm_mode.h|  739 ++
>  src/intel/drm/i915_drm.h| 1459 
> +++
You seriously want a README in the folder which described the dos
and/or don'ts of handling the files.

Thanks
Emil
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 2/2] anv/i965: drop libdrm_intel dependency completely

2017-06-14 Thread Jason Ekstrand 
On Wed, Jun 14, 2017 at 5:22 PM, Lionel Landwerlin <
lionel.g.landwer...@intel.com> wrote:

> With Ken's work to drop the library dependency on libdrm_intel, we now
> only depend on libdrm for the kernel uapi headers it provides. It
> seems like we're better off just embeddeding those headers ourselves,
> making the lives of people developping news features tightly
> integrated with the kernel a tiny bit easier.
>
> This change also makes it a bit more obvious what cflags/libs are
> required by the i915 drivers vs i965, by renaming INTEL_CFLAGS/LIBS
> into I915_CFLAGS/LIBS.
>
> Headers were generated from drm-tip on the following commit :
>
>commit cafd1e4df1e6e039268c4e4b1a55c88915d21f2e
>Author: Rodrigo Vivi 
>Date:   Wed Jun 14 12:56:57 2017 -0700
>
>drm-tip: 2017y-06m-14d-19h-56m-24s UTC integration manifest
>
> v2: Use installed files from the kernel (Daniel Vetter)
>

I'm not even going to pretend to review the build system patches.  However,
I do think that this is something we should do.  Both are

Acked-by: Jason Ekstrand 


>
> Signed-off-by: Lionel Landwerlin 
> ---
>  configure.ac|6 +-
>  src/gallium/drivers/i915/Automake.inc   |2 +-
>  src/gallium/targets/pipe-loader/Makefile.am |2 +-
>  src/gallium/winsys/i915/drm/Makefile.am |2 +-
>  src/intel/Makefile.drm.am   |   22 +
>  src/intel/Makefile.sources  |6 +
>  src/intel/Makefile.tools.am |3 +-
>  src/intel/Makefile.vulkan.am|4 +-
>  src/intel/drm/drm.h |  925 +
>  src/intel/drm/drm_fourcc.h  |  358 +++
>  src/intel/drm/drm_mode.h|  739 ++
>  src/intel/drm/i915_drm.h| 1459
> +++
>  src/mesa/drivers/dri/i915/Makefile.am   |4 +-
>  src/mesa/drivers/dri/i965/Makefile.am   |2 +-
>  14 files changed, 3520 insertions(+), 14 deletions(-)
>  create mode 100644 src/intel/Makefile.drm.am
>  create mode 100644 src/intel/drm/drm.h
>  create mode 100644 src/intel/drm/drm_fourcc.h
>  create mode 100644 src/intel/drm/drm_mode.h
>  create mode 100644 src/intel/drm/i915_drm.h
>
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev