Re: [Mesa-dev] [PATCH 2/2] intel/compiler: fix uninit non-static variable.

2019-04-11 Thread Lionel Landwerlin 

To be honest we're not initializing nir_locals either :/

Reviewed-by: Lionel Landwerlin 

On 11/04/2019 11:32, Dave Airlie wrote:

From: Dave Airlie 

Pointed out by coverity.
---
  src/intel/compiler/brw_vec4_visitor.cpp | 2 ++
  1 file changed, 2 insertions(+)

diff --git a/src/intel/compiler/brw_vec4_visitor.cpp 
b/src/intel/compiler/brw_vec4_visitor.cpp
index 16ee31d730a..fa3d7fc13b7 100644
--- a/src/intel/compiler/brw_vec4_visitor.cpp
+++ b/src/intel/compiler/brw_vec4_visitor.cpp
@@ -1887,6 +1887,8 @@ vec4_visitor::vec4_visitor(const struct brw_compiler 
*compiler,
 this->max_grf = devinfo->gen >= 7 ? GEN7_MRF_HACK_START : BRW_MAX_GRF;
  
 this->uniforms = 0;

+
+   this->nir_ssa_values = NULL;
  }
  
  



___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [PATCH 2/2] intel/compiler: fix uninit non-static variable.

2019-04-11 Thread Dave Airlie 
From: Dave Airlie 

Pointed out by coverity.
---
 src/intel/compiler/brw_vec4_visitor.cpp | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/src/intel/compiler/brw_vec4_visitor.cpp 
b/src/intel/compiler/brw_vec4_visitor.cpp
index 16ee31d730a..fa3d7fc13b7 100644
--- a/src/intel/compiler/brw_vec4_visitor.cpp
+++ b/src/intel/compiler/brw_vec4_visitor.cpp
@@ -1887,6 +1887,8 @@ vec4_visitor::vec4_visitor(const struct brw_compiler 
*compiler,
this->max_grf = devinfo->gen >= 7 ? GEN7_MRF_HACK_START : BRW_MAX_GRF;
 
this->uniforms = 0;
+
+   this->nir_ssa_values = NULL;
 }
 
 
-- 
2.20.1

___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev