subject:"\[Mesa\-dev\] \[PATCH 2\/3\] mesa\: enable ARB_texture_buffer_\* extensions in the Compatibility profile"

Re: [Mesa-dev] [PATCH 2/3] mesa: enable ARB_texture_buffer_* extensions in the Compatibility profile

2017-11-02 Thread Marek Olšák

One possibility would be to discard each hunk in each patch until you
find the problematic one. It might be a bug in i965 that was just
uncovered and fixing it might be non-trivial. For example,
set_max_gl_versions in i965 doesn't allow creating GL 4.6 contexts
directly, but there might be more.

The bottom line is that the environment variables are not guaranteed
to work in all cases (they are hacks) and I wouldn't like to block the
series because of them.

Marek

On Thu, Nov 2, 2017 at 2:07 AM, Mark Janes  wrote:
> The FC suffix does not help.  We are testing openglcts from
> opengl-cts-4.6.0 branch of gitlab.khronos.org:Tracker/vk-gl-cts.git:
>
> d6144a989   Fix attribute mapping in enhanced layouts tests for input 
> arrays
>
> MESA_GLES_VERSION_OVERRIDE=3.2 MESA_GLSL_VERSION_OVERRIDE=460 
> MESA_GL_VERSION_OVERRIDE=4.6FC ./glcts --deqp-runmode=xml-caselist
> Writing test log into TestResults.qpa
> dEQP Core git-d6144a989937b2829a9fc9813de994c4f514ebae (0xd6144a98) 
> starting..
>   target implementation = 'X11 EGL'
> Writing test cases from 'CTS-Configs' to file 'CTS-Configs-cases.xml'..
> Writing test cases from 'dEQP-EGL' to file 'dEQP-EGL-cases.xml'..
> Writing test cases from 'KHR-GLES2' to file 'KHR-GLES2-cases.xml'..
> Writing test cases from 'dEQP-GLES2' to file 'dEQP-GLES2-cases.xml'..
> Writing test cases from 'KHR-GLES3' to file 'KHR-GLES3-cases.xml'..
> Writing test cases from 'dEQP-GLES3' to file 'dEQP-GLES3-cases.xml'..
> Writing test cases from 'dEQP-GLES31' to file 'dEQP-GLES31-cases.xml'..
> Writing test cases from 'KHR-GLES31' to file 'KHR-GLES31-cases.xml'..
> Writing test cases from 'KHR-GLESEXT' to file 'KHR-GLESEXT-cases.xml'..
> Writing test cases from 'KHR-GLES32' to file 'KHR-GLES32-cases.xml'..
> Writing test cases from 'KHR-NoContext' to file 
> 'KHR-NoContext-cases.xml'..
> Writing test cases from 'KHR-GL30' to file 'KHR-GL30-cases.xml'..
> Writing test cases from 'KHR-GL31' to file 'KHR-GL31-cases.xml'..
> FATAL ERROR: Failed to initialize dEQP: Got EGL_BAD_MATCH: 
> eglCreateContext() at egluGLUtil.cpp:198
> ERROR: command failed
>
> Marek Olšák  writes:
>
>> This should work (I added "FC" at the end):
>>
>> MESA_GLSL_VERSION_OVERRIDE=460 MESA_GL_VERSION_OVERRIDE=4.6FC
>>
>> Marek
>>
>> On Wed, Nov 1, 2017 at 11:16 PM, Mark Janes  wrote:
>>> Mark Janes  writes:
>>>
 Marek Olšák  writes:

> Hi Mark,
>
> Can you try the attached patches instead?

 After talking with Ken and Dylan, I realize that I missed a one-line
 patch from your thread with my last test (Oct 25 patch to
 intel_extensions.c).  With that patch, there are no regressions in CI.

 I'm testing the attached patches as well.
>>>
>>> With the most recent patches, I'm unable to run the GL CTS 4.6:
>>>
>>> MESA_GLSL_VERSION_OVERRIDE=460 MESA_GL_VERSION_OVERRIDE=4.6 ./glcts 
>>> --deqp-runmode=xml-caselist
>>> Writing test log into TestResults.qpa
>>> dEQP Core git-d6144a989937b2829a9fc9813de994c4f514ebae (0xd6144a98) 
>>> starting..
>>>   target implementation = 'X11 EGL'
>>> Writing test cases from 'CTS-Configs' to file 'CTS-Configs-cases.xml'..
>>> Writing test cases from 'dEQP-EGL' to file 'dEQP-EGL-cases.xml'..
>>> Writing test cases from 'KHR-GLES2' to file 'KHR-GLES2-cases.xml'..
>>> Writing test cases from 'dEQP-GLES2' to file 'dEQP-GLES2-cases.xml'..
>>> Writing test cases from 'KHR-GLES3' to file 'KHR-GLES3-cases.xml'..
>>> Writing test cases from 'dEQP-GLES3' to file 'dEQP-GLES3-cases.xml'..
>>> Writing test cases from 'dEQP-GLES31' to file 'dEQP-GLES31-cases.xml'..
>>> Writing test cases from 'KHR-GLES31' to file 'KHR-GLES31-cases.xml'..
>>> Writing test cases from 'KHR-GLESEXT' to file 'KHR-GLESEXT-cases.xml'..
>>> Writing test cases from 'KHR-GLES32' to file 'KHR-GLES32-cases.xml'..
>>> Writing test cases from 'KHR-NoContext' to file 
>>> 'KHR-NoContext-cases.xml'..
>>> Writing test cases from 'KHR-GL30' to file 'KHR-GL30-cases.xml'..
>>> Writing test cases from 'KHR-GL31' to file 'KHR-GL31-cases.xml'..
>>> FATAL ERROR: Failed to initialize dEQP: Got EGL_BAD_MATCH: 
>>> eglCreateContext() at egluGLUtil.cpp:198
>>>
>>> piglit, deqp, and gles-cts encountered no regressions.
>>>
> Thanks,
> Marek
>
> On Wed, Nov 1, 2017 at 9:49 PM, Mark Janes  wrote:
>> Dylan Baker  writes:
>>
>>> I haven't run the CTS tests, but both the deqp and the piglit test pass 
>>> on my
>>> skl with Marek's patches applied.
>>
>> I must have tested with only the patch 2 applied.  Running with all
>> three patches in the series, I see no piglit/deqp regressions.
>>
>> However, GLES CTS fails thousands of ES31-CTS.functional.texture

Re: [Mesa-dev] [PATCH 2/3] mesa: enable ARB_texture_buffer_* extensions in the Compatibility profile

2017-11-01 Thread Mark Janes

The FC suffix does not help.  We are testing openglcts from
opengl-cts-4.6.0 branch of gitlab.khronos.org:Tracker/vk-gl-cts.git:

d6144a989   Fix attribute mapping in enhanced layouts tests for input arrays

MESA_GLES_VERSION_OVERRIDE=3.2 MESA_GLSL_VERSION_OVERRIDE=460 
MESA_GL_VERSION_OVERRIDE=4.6FC ./glcts --deqp-runmode=xml-caselist
Writing test log into TestResults.qpa
dEQP Core git-d6144a989937b2829a9fc9813de994c4f514ebae (0xd6144a98) 
starting..
  target implementation = 'X11 EGL'
Writing test cases from 'CTS-Configs' to file 'CTS-Configs-cases.xml'..
Writing test cases from 'dEQP-EGL' to file 'dEQP-EGL-cases.xml'..
Writing test cases from 'KHR-GLES2' to file 'KHR-GLES2-cases.xml'..
Writing test cases from 'dEQP-GLES2' to file 'dEQP-GLES2-cases.xml'..
Writing test cases from 'KHR-GLES3' to file 'KHR-GLES3-cases.xml'..
Writing test cases from 'dEQP-GLES3' to file 'dEQP-GLES3-cases.xml'..
Writing test cases from 'dEQP-GLES31' to file 'dEQP-GLES31-cases.xml'..
Writing test cases from 'KHR-GLES31' to file 'KHR-GLES31-cases.xml'..
Writing test cases from 'KHR-GLESEXT' to file 'KHR-GLESEXT-cases.xml'..
Writing test cases from 'KHR-GLES32' to file 'KHR-GLES32-cases.xml'..
Writing test cases from 'KHR-NoContext' to file 'KHR-NoContext-cases.xml'..
Writing test cases from 'KHR-GL30' to file 'KHR-GL30-cases.xml'..
Writing test cases from 'KHR-GL31' to file 'KHR-GL31-cases.xml'..
FATAL ERROR: Failed to initialize dEQP: Got EGL_BAD_MATCH: 
eglCreateContext() at egluGLUtil.cpp:198
ERROR: command failed

Marek Olšák  writes:

> This should work (I added "FC" at the end):
>
> MESA_GLSL_VERSION_OVERRIDE=460 MESA_GL_VERSION_OVERRIDE=4.6FC
>
> Marek
>
> On Wed, Nov 1, 2017 at 11:16 PM, Mark Janes  wrote:
>> Mark Janes  writes:
>>
>>> Marek Olšák  writes:
>>>
 Hi Mark,

 Can you try the attached patches instead?
>>>
>>> After talking with Ken and Dylan, I realize that I missed a one-line
>>> patch from your thread with my last test (Oct 25 patch to
>>> intel_extensions.c).  With that patch, there are no regressions in CI.
>>>
>>> I'm testing the attached patches as well.
>>
>> With the most recent patches, I'm unable to run the GL CTS 4.6:
>>
>> MESA_GLSL_VERSION_OVERRIDE=460 MESA_GL_VERSION_OVERRIDE=4.6 ./glcts 
>> --deqp-runmode=xml-caselist
>> Writing test log into TestResults.qpa
>> dEQP Core git-d6144a989937b2829a9fc9813de994c4f514ebae (0xd6144a98) 
>> starting..
>>   target implementation = 'X11 EGL'
>> Writing test cases from 'CTS-Configs' to file 'CTS-Configs-cases.xml'..
>> Writing test cases from 'dEQP-EGL' to file 'dEQP-EGL-cases.xml'..
>> Writing test cases from 'KHR-GLES2' to file 'KHR-GLES2-cases.xml'..
>> Writing test cases from 'dEQP-GLES2' to file 'dEQP-GLES2-cases.xml'..
>> Writing test cases from 'KHR-GLES3' to file 'KHR-GLES3-cases.xml'..
>> Writing test cases from 'dEQP-GLES3' to file 'dEQP-GLES3-cases.xml'..
>> Writing test cases from 'dEQP-GLES31' to file 'dEQP-GLES31-cases.xml'..
>> Writing test cases from 'KHR-GLES31' to file 'KHR-GLES31-cases.xml'..
>> Writing test cases from 'KHR-GLESEXT' to file 'KHR-GLESEXT-cases.xml'..
>> Writing test cases from 'KHR-GLES32' to file 'KHR-GLES32-cases.xml'..
>> Writing test cases from 'KHR-NoContext' to file 
>> 'KHR-NoContext-cases.xml'..
>> Writing test cases from 'KHR-GL30' to file 'KHR-GL30-cases.xml'..
>> Writing test cases from 'KHR-GL31' to file 'KHR-GL31-cases.xml'..
>> FATAL ERROR: Failed to initialize dEQP: Got EGL_BAD_MATCH: 
>> eglCreateContext() at egluGLUtil.cpp:198
>>
>> piglit, deqp, and gles-cts encountered no regressions.
>>
 Thanks,
 Marek

 On Wed, Nov 1, 2017 at 9:49 PM, Mark Janes  wrote:
> Dylan Baker  writes:
>
>> I haven't run the CTS tests, but both the deqp and the piglit test pass 
>> on my
>> skl with Marek's patches applied.
>
> I must have tested with only the patch 2 applied.  Running with all
> three patches in the series, I see no piglit/deqp regressions.
>
> However, GLES CTS fails thousands of ES31-CTS.functional.texture tests,
> eg:
>
> ES31-CTS.functional.texture.format.buffer.rg8i_npot
> glGetIntegerv() failed: glGetError() returned GL_INVALID_ENUM at 
> gluContextInfo.cpp:229
>
> -Mark
>
>>
>> Dylan
>>
>> Quoting Marek Olšák (2017-10-31 18:16:51)
>>> This is how I run piglit on i965:
>>> WAFFLE_GBM_DEVICE=/dev/dri/renderD128 PIGLIT_PLATFORM=gbm 
>>> piglit/bin/glinfo|head
>>> GL_RENDERER = Mesa DRI Intel(R) Ivybridge Desktop
>>>
>>> Of course I have Radeon as my main GPU.
>>>
>>> Marek
>>>
>>> On Wed, Nov 1, 2017 at 12:52 AM, Mark Janes  
>>> wrote:
>>> >

Re: [Mesa-dev] [PATCH 2/3] mesa: enable ARB_texture_buffer_* extensions in the Compatibility profile

2017-11-01 Thread Marek Olšák

This should work (I added "FC" at the end):

MESA_GLSL_VERSION_OVERRIDE=460 MESA_GL_VERSION_OVERRIDE=4.6FC

Marek

On Wed, Nov 1, 2017 at 11:16 PM, Mark Janes  wrote:
> Mark Janes  writes:
>
>> Marek Olšák  writes:
>>
>>> Hi Mark,
>>>
>>> Can you try the attached patches instead?
>>
>> After talking with Ken and Dylan, I realize that I missed a one-line
>> patch from your thread with my last test (Oct 25 patch to
>> intel_extensions.c).  With that patch, there are no regressions in CI.
>>
>> I'm testing the attached patches as well.
>
> With the most recent patches, I'm unable to run the GL CTS 4.6:
>
> MESA_GLSL_VERSION_OVERRIDE=460 MESA_GL_VERSION_OVERRIDE=4.6 ./glcts 
> --deqp-runmode=xml-caselist
> Writing test log into TestResults.qpa
> dEQP Core git-d6144a989937b2829a9fc9813de994c4f514ebae (0xd6144a98) 
> starting..
>   target implementation = 'X11 EGL'
> Writing test cases from 'CTS-Configs' to file 'CTS-Configs-cases.xml'..
> Writing test cases from 'dEQP-EGL' to file 'dEQP-EGL-cases.xml'..
> Writing test cases from 'KHR-GLES2' to file 'KHR-GLES2-cases.xml'..
> Writing test cases from 'dEQP-GLES2' to file 'dEQP-GLES2-cases.xml'..
> Writing test cases from 'KHR-GLES3' to file 'KHR-GLES3-cases.xml'..
> Writing test cases from 'dEQP-GLES3' to file 'dEQP-GLES3-cases.xml'..
> Writing test cases from 'dEQP-GLES31' to file 'dEQP-GLES31-cases.xml'..
> Writing test cases from 'KHR-GLES31' to file 'KHR-GLES31-cases.xml'..
> Writing test cases from 'KHR-GLESEXT' to file 'KHR-GLESEXT-cases.xml'..
> Writing test cases from 'KHR-GLES32' to file 'KHR-GLES32-cases.xml'..
> Writing test cases from 'KHR-NoContext' to file 
> 'KHR-NoContext-cases.xml'..
> Writing test cases from 'KHR-GL30' to file 'KHR-GL30-cases.xml'..
> Writing test cases from 'KHR-GL31' to file 'KHR-GL31-cases.xml'..
> FATAL ERROR: Failed to initialize dEQP: Got EGL_BAD_MATCH: 
> eglCreateContext() at egluGLUtil.cpp:198
>
> piglit, deqp, and gles-cts encountered no regressions.
>
>>> Thanks,
>>> Marek
>>>
>>> On Wed, Nov 1, 2017 at 9:49 PM, Mark Janes  wrote:
 Dylan Baker  writes:

> I haven't run the CTS tests, but both the deqp and the piglit test pass 
> on my
> skl with Marek's patches applied.

 I must have tested with only the patch 2 applied.  Running with all
 three patches in the series, I see no piglit/deqp regressions.

 However, GLES CTS fails thousands of ES31-CTS.functional.texture tests,
 eg:

 ES31-CTS.functional.texture.format.buffer.rg8i_npot
 glGetIntegerv() failed: glGetError() returned GL_INVALID_ENUM at 
 gluContextInfo.cpp:229

 -Mark

>
> Dylan
>
> Quoting Marek Olšák (2017-10-31 18:16:51)
>> This is how I run piglit on i965:
>> WAFFLE_GBM_DEVICE=/dev/dri/renderD128 PIGLIT_PLATFORM=gbm 
>> piglit/bin/glinfo|head
>> GL_RENDERER = Mesa DRI Intel(R) Ivybridge Desktop
>>
>> Of course I have Radeon as my main GPU.
>>
>> Marek
>>
>> On Wed, Nov 1, 2017 at 12:52 AM, Mark Janes  
>> wrote:
>> > No, please don't.  We can't have thousands of failures added to CI.
>> >
>> > Dylan, can you double check this for Marek?  I'm surprised that it
>> > doesn't reproduce for him.
>> >
>> > -Mark
>> >
>> > Marek Olšák  writes:
>> >
>> >> I can't reproduce the issue on my IVB. How about I just push this and
>> >> you guys fix i965 when you have time?
>> >>
>> >> Marek
>> >>
>> >> On Thu, Oct 26, 2017 at 5:46 PM, Mark Janes  
>> >> wrote:
>> >>> That fixed many issues, but:
>> >>>
>> >>> On deqp EGL tests, we get:
>> >>>
>> >>> dEQP-EGL.functional.create_context_ext.gl_42.rgba_no_depth_no_stencil
>> >>> deqp-egl: main/api_exec.c:135: _mesa_initialize_exec_table: 
>> >>> Assertion `ctx->Version > 0' failed.
>> >>>
>> >>> On ES31 CTS tests:
>> >>> ES31-CTS.functional.texture.texture_buffer.render.as_vertex_array_as_vertex_texture_as_fragment_texture.range_size_513
>> >>> glGetIntegerv() failed: glGetError() returned GL_INVALID_ENUM at
>> >>> gluContextInfo.cpp:229
>> >>>
>> >>> on GL46 CTS (27 failures):
>> >>> src/mesa/main/teximage.c:595: _mesa_tex_target_is_layered: Assertion
>> >>> `!"Invalid texture target."' failed.
>> >>>
>> >>> Piglit fails 3.5k tests with the same `ctx->Version > 0' assertion as
>> >>> deqp-egl.
>> >>>
>> >>> -Mark
>> >>>
>> >>> Dylan Baker  writes:
>> >>>
>>  I've pushed it to our CI, I'll let you know tomorrow what it looks 
>>  like
>> 
>>  Dylan
>> 
>>  Quoting Marek Olšák (2017-10-25 19:52:43)
>> > Hi

Re: [Mesa-dev] [PATCH 2/3] mesa: enable ARB_texture_buffer_* extensions in the Compatibility profile

2017-11-01 Thread Mark Janes

Mark Janes  writes:

> Marek Olšák  writes:
>
>> Hi Mark,
>>
>> Can you try the attached patches instead?
>
> After talking with Ken and Dylan, I realize that I missed a one-line
> patch from your thread with my last test (Oct 25 patch to
> intel_extensions.c).  With that patch, there are no regressions in CI.
>
> I'm testing the attached patches as well.

With the most recent patches, I'm unable to run the GL CTS 4.6:

MESA_GLSL_VERSION_OVERRIDE=460 MESA_GL_VERSION_OVERRIDE=4.6 ./glcts 
--deqp-runmode=xml-caselist
Writing test log into TestResults.qpa
dEQP Core git-d6144a989937b2829a9fc9813de994c4f514ebae (0xd6144a98) 
starting..
  target implementation = 'X11 EGL'
Writing test cases from 'CTS-Configs' to file 'CTS-Configs-cases.xml'..
Writing test cases from 'dEQP-EGL' to file 'dEQP-EGL-cases.xml'..
Writing test cases from 'KHR-GLES2' to file 'KHR-GLES2-cases.xml'..
Writing test cases from 'dEQP-GLES2' to file 'dEQP-GLES2-cases.xml'..
Writing test cases from 'KHR-GLES3' to file 'KHR-GLES3-cases.xml'..
Writing test cases from 'dEQP-GLES3' to file 'dEQP-GLES3-cases.xml'..
Writing test cases from 'dEQP-GLES31' to file 'dEQP-GLES31-cases.xml'..
Writing test cases from 'KHR-GLES31' to file 'KHR-GLES31-cases.xml'..
Writing test cases from 'KHR-GLESEXT' to file 'KHR-GLESEXT-cases.xml'..
Writing test cases from 'KHR-GLES32' to file 'KHR-GLES32-cases.xml'..
Writing test cases from 'KHR-NoContext' to file 'KHR-NoContext-cases.xml'..
Writing test cases from 'KHR-GL30' to file 'KHR-GL30-cases.xml'..
Writing test cases from 'KHR-GL31' to file 'KHR-GL31-cases.xml'..
FATAL ERROR: Failed to initialize dEQP: Got EGL_BAD_MATCH: 
eglCreateContext() at egluGLUtil.cpp:198

piglit, deqp, and gles-cts encountered no regressions.

>> Thanks,
>> Marek
>>
>> On Wed, Nov 1, 2017 at 9:49 PM, Mark Janes  wrote:
>>> Dylan Baker  writes:
>>>
 I haven't run the CTS tests, but both the deqp and the piglit test pass on 
 my
 skl with Marek's patches applied.
>>>
>>> I must have tested with only the patch 2 applied.  Running with all
>>> three patches in the series, I see no piglit/deqp regressions.
>>>
>>> However, GLES CTS fails thousands of ES31-CTS.functional.texture tests,
>>> eg:
>>>
>>> ES31-CTS.functional.texture.format.buffer.rg8i_npot
>>> glGetIntegerv() failed: glGetError() returned GL_INVALID_ENUM at 
>>> gluContextInfo.cpp:229
>>>
>>> -Mark
>>>

 Dylan

 Quoting Marek Olšák (2017-10-31 18:16:51)
> This is how I run piglit on i965:
> WAFFLE_GBM_DEVICE=/dev/dri/renderD128 PIGLIT_PLATFORM=gbm 
> piglit/bin/glinfo|head
> GL_RENDERER = Mesa DRI Intel(R) Ivybridge Desktop
>
> Of course I have Radeon as my main GPU.
>
> Marek
>
> On Wed, Nov 1, 2017 at 12:52 AM, Mark Janes  
> wrote:
> > No, please don't.  We can't have thousands of failures added to CI.
> >
> > Dylan, can you double check this for Marek?  I'm surprised that it
> > doesn't reproduce for him.
> >
> > -Mark
> >
> > Marek Olšák  writes:
> >
> >> I can't reproduce the issue on my IVB. How about I just push this and
> >> you guys fix i965 when you have time?
> >>
> >> Marek
> >>
> >> On Thu, Oct 26, 2017 at 5:46 PM, Mark Janes  
> >> wrote:
> >>> That fixed many issues, but:
> >>>
> >>> On deqp EGL tests, we get:
> >>>
> >>> dEQP-EGL.functional.create_context_ext.gl_42.rgba_no_depth_no_stencil
> >>> deqp-egl: main/api_exec.c:135: _mesa_initialize_exec_table: Assertion 
> >>> `ctx->Version > 0' failed.
> >>>
> >>> On ES31 CTS tests:
> >>> ES31-CTS.functional.texture.texture_buffer.render.as_vertex_array_as_vertex_texture_as_fragment_texture.range_size_513
> >>> glGetIntegerv() failed: glGetError() returned GL_INVALID_ENUM at
> >>> gluContextInfo.cpp:229
> >>>
> >>> on GL46 CTS (27 failures):
> >>> src/mesa/main/teximage.c:595: _mesa_tex_target_is_layered: Assertion
> >>> `!"Invalid texture target."' failed.
> >>>
> >>> Piglit fails 3.5k tests with the same `ctx->Version > 0' assertion as
> >>> deqp-egl.
> >>>
> >>> -Mark
> >>>
> >>> Dylan Baker  writes:
> >>>
>  I've pushed it to our CI, I'll let you know tomorrow what it looks 
>  like
> 
>  Dylan
> 
>  Quoting Marek Olšák (2017-10-25 19:52:43)
> > Hi Dylan,
> >
> > Can you please add this and re-test?
> >
> > diff --git a/src/mesa/drivers/dri/i965/intel_extensions.c 
> > b/src/mesa/drivers/
> > dri/i965/intel_extensions.c
> > index 21cf632..4d17393 100644
> > --- a/src/mesa/drivers/dri/i965/intel_extensions.c
> > +++

Re: [Mesa-dev] [PATCH 2/3] mesa: enable ARB_texture_buffer_* extensions in the Compatibility profile

2017-11-01 Thread Mark Janes

Marek Olšák  writes:

> Hi Mark,
>
> Can you try the attached patches instead?

After talking with Ken and Dylan, I realize that I missed a one-line
patch from your thread with my last test (Oct 25 patch to
intel_extensions.c).  With that patch, there are no regressions in CI.

I'm testing the attached patches as well.

> Thanks,
> Marek
>
> On Wed, Nov 1, 2017 at 9:49 PM, Mark Janes  wrote:
>> Dylan Baker  writes:
>>
>>> I haven't run the CTS tests, but both the deqp and the piglit test pass on 
>>> my
>>> skl with Marek's patches applied.
>>
>> I must have tested with only the patch 2 applied.  Running with all
>> three patches in the series, I see no piglit/deqp regressions.
>>
>> However, GLES CTS fails thousands of ES31-CTS.functional.texture tests,
>> eg:
>>
>> ES31-CTS.functional.texture.format.buffer.rg8i_npot
>> glGetIntegerv() failed: glGetError() returned GL_INVALID_ENUM at 
>> gluContextInfo.cpp:229
>>
>> -Mark
>>
>>>
>>> Dylan
>>>
>>> Quoting Marek Olšák (2017-10-31 18:16:51)
 This is how I run piglit on i965:
 WAFFLE_GBM_DEVICE=/dev/dri/renderD128 PIGLIT_PLATFORM=gbm 
 piglit/bin/glinfo|head
 GL_RENDERER = Mesa DRI Intel(R) Ivybridge Desktop

 Of course I have Radeon as my main GPU.

 Marek

 On Wed, Nov 1, 2017 at 12:52 AM, Mark Janes  wrote:
 > No, please don't.  We can't have thousands of failures added to CI.
 >
 > Dylan, can you double check this for Marek?  I'm surprised that it
 > doesn't reproduce for him.
 >
 > -Mark
 >
 > Marek Olšák  writes:
 >
 >> I can't reproduce the issue on my IVB. How about I just push this and
 >> you guys fix i965 when you have time?
 >>
 >> Marek
 >>
 >> On Thu, Oct 26, 2017 at 5:46 PM, Mark Janes  
 >> wrote:
 >>> That fixed many issues, but:
 >>>
 >>> On deqp EGL tests, we get:
 >>>
 >>> dEQP-EGL.functional.create_context_ext.gl_42.rgba_no_depth_no_stencil
 >>> deqp-egl: main/api_exec.c:135: _mesa_initialize_exec_table: Assertion 
 >>> `ctx->Version > 0' failed.
 >>>
 >>> On ES31 CTS tests:
 >>> ES31-CTS.functional.texture.texture_buffer.render.as_vertex_array_as_vertex_texture_as_fragment_texture.range_size_513
 >>> glGetIntegerv() failed: glGetError() returned GL_INVALID_ENUM at
 >>> gluContextInfo.cpp:229
 >>>
 >>> on GL46 CTS (27 failures):
 >>> src/mesa/main/teximage.c:595: _mesa_tex_target_is_layered: Assertion
 >>> `!"Invalid texture target."' failed.
 >>>
 >>> Piglit fails 3.5k tests with the same `ctx->Version > 0' assertion as
 >>> deqp-egl.
 >>>
 >>> -Mark
 >>>
 >>> Dylan Baker  writes:
 >>>
  I've pushed it to our CI, I'll let you know tomorrow what it looks 
  like
 
  Dylan
 
  Quoting Marek Olšák (2017-10-25 19:52:43)
 > Hi Dylan,
 >
 > Can you please add this and re-test?
 >
 > diff --git a/src/mesa/drivers/dri/i965/intel_extensions.c 
 > b/src/mesa/drivers/
 > dri/i965/intel_extensions.c
 > index 21cf632..4d17393 100644
 > --- a/src/mesa/drivers/dri/i965/intel_extensions.c
 > +++ b/src/mesa/drivers/dri/i965/intel_extensions.c
 > @@ -178,7 +178,7 @@ intelInitExtensions(struct gl_context *ctx)
 >ctx->Extensions.ARB_pipeline_statistics_query = true;
 >ctx->Extensions.ARB_sample_shading = true;
 >ctx->Extensions.ARB_shading_language_420pack = true;
 > -  if (ctx->API == API_OPENGL_CORE) {
 > +  if (ctx->API != API_OPENGL_COMPAT) {
 >   ctx->Extensions.ARB_texture_buffer_object = true;
 >   ctx->Extensions.ARB_texture_buffer_object_rgb32 = true;
 >   ctx->Extensions.ARB_texture_buffer_range = true;
 >
 >
 > Marek
 >
 > On Wed, Oct 25, 2017 at 11:42 PM, Dylan Baker 
 >  wrote:
 >
 > There are a significant number of i965 regressions from
 > d96c68146a781c79a23f5181d7050174f1070d90, largely related to 
 > texturing (I
 > can
 > send you a complete list of regressions if you care, but due to 
 > the large
 > number
 > of them I suspect it's something fairly simple).
 >
 > For example:
 > ES31-CTS.functional.texture.format.buffer.r32ui_npot
 >
 > glGetIntegerv() failed: glGetError() returned GL_INVALID_ENUM at
 > gluContextInfo.cpp:229
 >
 > dEQP-GLES31.functional.state_query.integer.texture_buffer_
 > binding_getinteger:
 >
 >

Re: [Mesa-dev] [PATCH 2/3] mesa: enable ARB_texture_buffer_* extensions in the Compatibility profile

2017-11-01 Thread Marek Olšák

Hi Mark,

Can you try the attached patches instead?

Thanks,
Marek

On Wed, Nov 1, 2017 at 9:49 PM, Mark Janes  wrote:
> Dylan Baker  writes:
>
>> I haven't run the CTS tests, but both the deqp and the piglit test pass on my
>> skl with Marek's patches applied.
>
> I must have tested with only the patch 2 applied.  Running with all
> three patches in the series, I see no piglit/deqp regressions.
>
> However, GLES CTS fails thousands of ES31-CTS.functional.texture tests,
> eg:
>
> ES31-CTS.functional.texture.format.buffer.rg8i_npot
> glGetIntegerv() failed: glGetError() returned GL_INVALID_ENUM at 
> gluContextInfo.cpp:229
>
> -Mark
>
>>
>> Dylan
>>
>> Quoting Marek Olšák (2017-10-31 18:16:51)
>>> This is how I run piglit on i965:
>>> WAFFLE_GBM_DEVICE=/dev/dri/renderD128 PIGLIT_PLATFORM=gbm 
>>> piglit/bin/glinfo|head
>>> GL_RENDERER = Mesa DRI Intel(R) Ivybridge Desktop
>>>
>>> Of course I have Radeon as my main GPU.
>>>
>>> Marek
>>>
>>> On Wed, Nov 1, 2017 at 12:52 AM, Mark Janes  wrote:
>>> > No, please don't.  We can't have thousands of failures added to CI.
>>> >
>>> > Dylan, can you double check this for Marek?  I'm surprised that it
>>> > doesn't reproduce for him.
>>> >
>>> > -Mark
>>> >
>>> > Marek Olšák  writes:
>>> >
>>> >> I can't reproduce the issue on my IVB. How about I just push this and
>>> >> you guys fix i965 when you have time?
>>> >>
>>> >> Marek
>>> >>
>>> >> On Thu, Oct 26, 2017 at 5:46 PM, Mark Janes  
>>> >> wrote:
>>> >>> That fixed many issues, but:
>>> >>>
>>> >>> On deqp EGL tests, we get:
>>> >>>
>>> >>> dEQP-EGL.functional.create_context_ext.gl_42.rgba_no_depth_no_stencil
>>> >>> deqp-egl: main/api_exec.c:135: _mesa_initialize_exec_table: Assertion 
>>> >>> `ctx->Version > 0' failed.
>>> >>>
>>> >>> On ES31 CTS tests:
>>> >>> ES31-CTS.functional.texture.texture_buffer.render.as_vertex_array_as_vertex_texture_as_fragment_texture.range_size_513
>>> >>> glGetIntegerv() failed: glGetError() returned GL_INVALID_ENUM at
>>> >>> gluContextInfo.cpp:229
>>> >>>
>>> >>> on GL46 CTS (27 failures):
>>> >>> src/mesa/main/teximage.c:595: _mesa_tex_target_is_layered: Assertion
>>> >>> `!"Invalid texture target."' failed.
>>> >>>
>>> >>> Piglit fails 3.5k tests with the same `ctx->Version > 0' assertion as
>>> >>> deqp-egl.
>>> >>>
>>> >>> -Mark
>>> >>>
>>> >>> Dylan Baker  writes:
>>> >>>
>>>  I've pushed it to our CI, I'll let you know tomorrow what it looks like
>>> 
>>>  Dylan
>>> 
>>>  Quoting Marek Olšák (2017-10-25 19:52:43)
>>> > Hi Dylan,
>>> >
>>> > Can you please add this and re-test?
>>> >
>>> > diff --git a/src/mesa/drivers/dri/i965/intel_extensions.c 
>>> > b/src/mesa/drivers/
>>> > dri/i965/intel_extensions.c
>>> > index 21cf632..4d17393 100644
>>> > --- a/src/mesa/drivers/dri/i965/intel_extensions.c
>>> > +++ b/src/mesa/drivers/dri/i965/intel_extensions.c
>>> > @@ -178,7 +178,7 @@ intelInitExtensions(struct gl_context *ctx)
>>> >ctx->Extensions.ARB_pipeline_statistics_query = true;
>>> >ctx->Extensions.ARB_sample_shading = true;
>>> >ctx->Extensions.ARB_shading_language_420pack = true;
>>> > -  if (ctx->API == API_OPENGL_CORE) {
>>> > +  if (ctx->API != API_OPENGL_COMPAT) {
>>> >   ctx->Extensions.ARB_texture_buffer_object = true;
>>> >   ctx->Extensions.ARB_texture_buffer_object_rgb32 = true;
>>> >   ctx->Extensions.ARB_texture_buffer_range = true;
>>> >
>>> >
>>> > Marek
>>> >
>>> > On Wed, Oct 25, 2017 at 11:42 PM, Dylan Baker 
>>> >  wrote:
>>> >
>>> > There are a significant number of i965 regressions from
>>> > d96c68146a781c79a23f5181d7050174f1070d90, largely related to 
>>> > texturing (I
>>> > can
>>> > send you a complete list of regressions if you care, but due to 
>>> > the large
>>> > number
>>> > of them I suspect it's something fairly simple).
>>> >
>>> > For example:
>>> > ES31-CTS.functional.texture.format.buffer.r32ui_npot
>>> >
>>> > glGetIntegerv() failed: glGetError() returned GL_INVALID_ENUM at
>>> > gluContextInfo.cpp:229
>>> >
>>> > dEQP-GLES31.functional.state_query.integer.texture_buffer_
>>> > binding_getinteger:
>>> >
>>> > glGetIntegerv(GL_TEXTURE_BUFFER_BINDING, 0x7ffee0c43834);
>>> > // data = { -555819298 }
>>> > glGetError();
>>> > // GL_INVALID_ENUM returned
>>> >  // ERROR: glGetIntegerv: glGetError() returned GL_INVALID_ENUM
>>> >
>>> > Dylan
>>> >
>>> > Quoting Emil Velikov (2017-10-24 09:30:03)
>>> > > Hi Marek,
>>> > >
>>> > > On 21 October 2017 at 13:54, Marek Olšák  
>>>

Re: [Mesa-dev] [PATCH 2/3] mesa: enable ARB_texture_buffer_* extensions in the Compatibility profile

2017-11-01 Thread Mark Janes

Dylan Baker  writes:

> I haven't run the CTS tests, but both the deqp and the piglit test pass on my
> skl with Marek's patches applied.

I must have tested with only the patch 2 applied.  Running with all
three patches in the series, I see no piglit/deqp regressions.

However, GLES CTS fails thousands of ES31-CTS.functional.texture tests,
eg:

ES31-CTS.functional.texture.format.buffer.rg8i_npot
glGetIntegerv() failed: glGetError() returned GL_INVALID_ENUM at 
gluContextInfo.cpp:229

-Mark

>
> Dylan
>
> Quoting Marek Olšák (2017-10-31 18:16:51)
>> This is how I run piglit on i965:
>> WAFFLE_GBM_DEVICE=/dev/dri/renderD128 PIGLIT_PLATFORM=gbm 
>> piglit/bin/glinfo|head
>> GL_RENDERER = Mesa DRI Intel(R) Ivybridge Desktop
>> 
>> Of course I have Radeon as my main GPU.
>> 
>> Marek
>> 
>> On Wed, Nov 1, 2017 at 12:52 AM, Mark Janes  wrote:
>> > No, please don't.  We can't have thousands of failures added to CI.
>> >
>> > Dylan, can you double check this for Marek?  I'm surprised that it
>> > doesn't reproduce for him.
>> >
>> > -Mark
>> >
>> > Marek Olšák  writes:
>> >
>> >> I can't reproduce the issue on my IVB. How about I just push this and
>> >> you guys fix i965 when you have time?
>> >>
>> >> Marek
>> >>
>> >> On Thu, Oct 26, 2017 at 5:46 PM, Mark Janes  
>> >> wrote:
>> >>> That fixed many issues, but:
>> >>>
>> >>> On deqp EGL tests, we get:
>> >>>
>> >>> dEQP-EGL.functional.create_context_ext.gl_42.rgba_no_depth_no_stencil
>> >>> deqp-egl: main/api_exec.c:135: _mesa_initialize_exec_table: Assertion 
>> >>> `ctx->Version > 0' failed.
>> >>>
>> >>> On ES31 CTS tests:
>> >>> ES31-CTS.functional.texture.texture_buffer.render.as_vertex_array_as_vertex_texture_as_fragment_texture.range_size_513
>> >>> glGetIntegerv() failed: glGetError() returned GL_INVALID_ENUM at
>> >>> gluContextInfo.cpp:229
>> >>>
>> >>> on GL46 CTS (27 failures):
>> >>> src/mesa/main/teximage.c:595: _mesa_tex_target_is_layered: Assertion
>> >>> `!"Invalid texture target."' failed.
>> >>>
>> >>> Piglit fails 3.5k tests with the same `ctx->Version > 0' assertion as
>> >>> deqp-egl.
>> >>>
>> >>> -Mark
>> >>>
>> >>> Dylan Baker  writes:
>> >>>
>>  I've pushed it to our CI, I'll let you know tomorrow what it looks like
>> 
>>  Dylan
>> 
>>  Quoting Marek Olšák (2017-10-25 19:52:43)
>> > Hi Dylan,
>> >
>> > Can you please add this and re-test?
>> >
>> > diff --git a/src/mesa/drivers/dri/i965/intel_extensions.c 
>> > b/src/mesa/drivers/
>> > dri/i965/intel_extensions.c
>> > index 21cf632..4d17393 100644
>> > --- a/src/mesa/drivers/dri/i965/intel_extensions.c
>> > +++ b/src/mesa/drivers/dri/i965/intel_extensions.c
>> > @@ -178,7 +178,7 @@ intelInitExtensions(struct gl_context *ctx)
>> >ctx->Extensions.ARB_pipeline_statistics_query = true;
>> >ctx->Extensions.ARB_sample_shading = true;
>> >ctx->Extensions.ARB_shading_language_420pack = true;
>> > -  if (ctx->API == API_OPENGL_CORE) {
>> > +  if (ctx->API != API_OPENGL_COMPAT) {
>> >   ctx->Extensions.ARB_texture_buffer_object = true;
>> >   ctx->Extensions.ARB_texture_buffer_object_rgb32 = true;
>> >   ctx->Extensions.ARB_texture_buffer_range = true;
>> >
>> >
>> > Marek
>> >
>> > On Wed, Oct 25, 2017 at 11:42 PM, Dylan Baker 
>> >  wrote:
>> >
>> > There are a significant number of i965 regressions from
>> > d96c68146a781c79a23f5181d7050174f1070d90, largely related to 
>> > texturing (I
>> > can
>> > send you a complete list of regressions if you care, but due to 
>> > the large
>> > number
>> > of them I suspect it's something fairly simple).
>> >
>> > For example:
>> > ES31-CTS.functional.texture.format.buffer.r32ui_npot
>> >
>> > glGetIntegerv() failed: glGetError() returned GL_INVALID_ENUM at
>> > gluContextInfo.cpp:229
>> >
>> > dEQP-GLES31.functional.state_query.integer.texture_buffer_
>> > binding_getinteger:
>> >
>> > glGetIntegerv(GL_TEXTURE_BUFFER_BINDING, 0x7ffee0c43834);
>> > // data = { -555819298 }
>> > glGetError();
>> > // GL_INVALID_ENUM returned
>> >  // ERROR: glGetIntegerv: glGetError() returned GL_INVALID_ENUM
>> >
>> > Dylan
>> >
>> > Quoting Emil Velikov (2017-10-24 09:30:03)
>> > > Hi Marek,
>> > >
>> > > On 21 October 2017 at 13:54, Marek Olšák  
>> > wrote:
>> > > > From: Marek Olšák 
>> > > >
>> > > > We already have piglit tests testing alpha, luminance, and 
>> > intensity
>> > > > formats. They were skipped by piglit until now.
>> > > >
>> > > >

Re: [Mesa-dev] [PATCH 2/3] mesa: enable ARB_texture_buffer_* extensions in the Compatibility profile

2017-11-01 Thread Dylan Baker

I haven't run the CTS tests, but both the deqp and the piglit test pass on my
skl with Marek's patches applied.

Dylan

Quoting Marek Olšák (2017-10-31 18:16:51)
> This is how I run piglit on i965:
> WAFFLE_GBM_DEVICE=/dev/dri/renderD128 PIGLIT_PLATFORM=gbm 
> piglit/bin/glinfo|head
> GL_RENDERER = Mesa DRI Intel(R) Ivybridge Desktop
> 
> Of course I have Radeon as my main GPU.
> 
> Marek
> 
> On Wed, Nov 1, 2017 at 12:52 AM, Mark Janes  wrote:
> > No, please don't.  We can't have thousands of failures added to CI.
> >
> > Dylan, can you double check this for Marek?  I'm surprised that it
> > doesn't reproduce for him.
> >
> > -Mark
> >
> > Marek Olšák  writes:
> >
> >> I can't reproduce the issue on my IVB. How about I just push this and
> >> you guys fix i965 when you have time?
> >>
> >> Marek
> >>
> >> On Thu, Oct 26, 2017 at 5:46 PM, Mark Janes  wrote:
> >>> That fixed many issues, but:
> >>>
> >>> On deqp EGL tests, we get:
> >>>
> >>> dEQP-EGL.functional.create_context_ext.gl_42.rgba_no_depth_no_stencil
> >>> deqp-egl: main/api_exec.c:135: _mesa_initialize_exec_table: Assertion 
> >>> `ctx->Version > 0' failed.
> >>>
> >>> On ES31 CTS tests:
> >>> ES31-CTS.functional.texture.texture_buffer.render.as_vertex_array_as_vertex_texture_as_fragment_texture.range_size_513
> >>> glGetIntegerv() failed: glGetError() returned GL_INVALID_ENUM at
> >>> gluContextInfo.cpp:229
> >>>
> >>> on GL46 CTS (27 failures):
> >>> src/mesa/main/teximage.c:595: _mesa_tex_target_is_layered: Assertion
> >>> `!"Invalid texture target."' failed.
> >>>
> >>> Piglit fails 3.5k tests with the same `ctx->Version > 0' assertion as
> >>> deqp-egl.
> >>>
> >>> -Mark
> >>>
> >>> Dylan Baker  writes:
> >>>
>  I've pushed it to our CI, I'll let you know tomorrow what it looks like
> 
>  Dylan
> 
>  Quoting Marek Olšák (2017-10-25 19:52:43)
> > Hi Dylan,
> >
> > Can you please add this and re-test?
> >
> > diff --git a/src/mesa/drivers/dri/i965/intel_extensions.c 
> > b/src/mesa/drivers/
> > dri/i965/intel_extensions.c
> > index 21cf632..4d17393 100644
> > --- a/src/mesa/drivers/dri/i965/intel_extensions.c
> > +++ b/src/mesa/drivers/dri/i965/intel_extensions.c
> > @@ -178,7 +178,7 @@ intelInitExtensions(struct gl_context *ctx)
> >ctx->Extensions.ARB_pipeline_statistics_query = true;
> >ctx->Extensions.ARB_sample_shading = true;
> >ctx->Extensions.ARB_shading_language_420pack = true;
> > -  if (ctx->API == API_OPENGL_CORE) {
> > +  if (ctx->API != API_OPENGL_COMPAT) {
> >   ctx->Extensions.ARB_texture_buffer_object = true;
> >   ctx->Extensions.ARB_texture_buffer_object_rgb32 = true;
> >   ctx->Extensions.ARB_texture_buffer_range = true;
> >
> >
> > Marek
> >
> > On Wed, Oct 25, 2017 at 11:42 PM, Dylan Baker 
> >  wrote:
> >
> > There are a significant number of i965 regressions from
> > d96c68146a781c79a23f5181d7050174f1070d90, largely related to 
> > texturing (I
> > can
> > send you a complete list of regressions if you care, but due to the 
> > large
> > number
> > of them I suspect it's something fairly simple).
> >
> > For example:
> > ES31-CTS.functional.texture.format.buffer.r32ui_npot
> >
> > glGetIntegerv() failed: glGetError() returned GL_INVALID_ENUM at
> > gluContextInfo.cpp:229
> >
> > dEQP-GLES31.functional.state_query.integer.texture_buffer_
> > binding_getinteger:
> >
> > glGetIntegerv(GL_TEXTURE_BUFFER_BINDING, 0x7ffee0c43834);
> > // data = { -555819298 }
> > glGetError();
> > // GL_INVALID_ENUM returned
> >  // ERROR: glGetIntegerv: glGetError() returned GL_INVALID_ENUM
> >
> > Dylan
> >
> > Quoting Emil Velikov (2017-10-24 09:30:03)
> > > Hi Marek,
> > >
> > > On 21 October 2017 at 13:54, Marek Olšák  wrote:
> > > > From: Marek Olšák 
> > > >
> > > > We already have piglit tests testing alpha, luminance, and 
> > intensity
> > > > formats. They were skipped by piglit until now.
> > > >
> > > > Additionally, I'm enabling one ARB_texture_buffer_range piglit 
> > test to
> > run
> > > > with the compat profile.
> > >
> > > Can you please mention that ARB_texture_buffer_* on i965 is 
> > unchanged
> > > - aka still enabled only for core profiles.
> > > Out of curiosity - can you tried the series with anything more 
> > than
> > piglit?
> > >
> > > The Intel guys can run the lot through CTS, dEQP... admittedly 
> > only on
> > > Intel

Re: [Mesa-dev] [PATCH 2/3] mesa: enable ARB_texture_buffer_* extensions in the Compatibility profile

2017-11-01 Thread Marek Olšák

On Wed, Nov 1, 2017 at 6:56 PM, Dylan Baker  wrote:
> I'm asking a dumb question, but we always build with --enable-debug, are you
> building with --enable-debug?

Yes. If ctx->Version == 0, something is terribly wrong and the OpenGL
driver should be non-functional.

Marek
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 2/3] mesa: enable ARB_texture_buffer_* extensions in the Compatibility profile

2017-11-01 Thread Dylan Baker

I'm asking a dumb question, but we always build with --enable-debug, are you
building with --enable-debug?

Dylan

Quoting Marek Olšák (2017-10-31 18:16:51)
> This is how I run piglit on i965:
> WAFFLE_GBM_DEVICE=/dev/dri/renderD128 PIGLIT_PLATFORM=gbm 
> piglit/bin/glinfo|head
> GL_RENDERER = Mesa DRI Intel(R) Ivybridge Desktop
> 
> Of course I have Radeon as my main GPU.
> 
> Marek
> 
> On Wed, Nov 1, 2017 at 12:52 AM, Mark Janes  wrote:
> > No, please don't.  We can't have thousands of failures added to CI.
> >
> > Dylan, can you double check this for Marek?  I'm surprised that it
> > doesn't reproduce for him.
> >
> > -Mark
> >
> > Marek Olšák  writes:
> >
> >> I can't reproduce the issue on my IVB. How about I just push this and
> >> you guys fix i965 when you have time?
> >>
> >> Marek
> >>
> >> On Thu, Oct 26, 2017 at 5:46 PM, Mark Janes  wrote:
> >>> That fixed many issues, but:
> >>>
> >>> On deqp EGL tests, we get:
> >>>
> >>> dEQP-EGL.functional.create_context_ext.gl_42.rgba_no_depth_no_stencil
> >>> deqp-egl: main/api_exec.c:135: _mesa_initialize_exec_table: Assertion 
> >>> `ctx->Version > 0' failed.
> >>>
> >>> On ES31 CTS tests:
> >>> ES31-CTS.functional.texture.texture_buffer.render.as_vertex_array_as_vertex_texture_as_fragment_texture.range_size_513
> >>> glGetIntegerv() failed: glGetError() returned GL_INVALID_ENUM at
> >>> gluContextInfo.cpp:229
> >>>
> >>> on GL46 CTS (27 failures):
> >>> src/mesa/main/teximage.c:595: _mesa_tex_target_is_layered: Assertion
> >>> `!"Invalid texture target."' failed.
> >>>
> >>> Piglit fails 3.5k tests with the same `ctx->Version > 0' assertion as
> >>> deqp-egl.
> >>>
> >>> -Mark
> >>>
> >>> Dylan Baker  writes:
> >>>
>  I've pushed it to our CI, I'll let you know tomorrow what it looks like
> 
>  Dylan
> 
>  Quoting Marek Olšák (2017-10-25 19:52:43)
> > Hi Dylan,
> >
> > Can you please add this and re-test?
> >
> > diff --git a/src/mesa/drivers/dri/i965/intel_extensions.c 
> > b/src/mesa/drivers/
> > dri/i965/intel_extensions.c
> > index 21cf632..4d17393 100644
> > --- a/src/mesa/drivers/dri/i965/intel_extensions.c
> > +++ b/src/mesa/drivers/dri/i965/intel_extensions.c
> > @@ -178,7 +178,7 @@ intelInitExtensions(struct gl_context *ctx)
> >ctx->Extensions.ARB_pipeline_statistics_query = true;
> >ctx->Extensions.ARB_sample_shading = true;
> >ctx->Extensions.ARB_shading_language_420pack = true;
> > -  if (ctx->API == API_OPENGL_CORE) {
> > +  if (ctx->API != API_OPENGL_COMPAT) {
> >   ctx->Extensions.ARB_texture_buffer_object = true;
> >   ctx->Extensions.ARB_texture_buffer_object_rgb32 = true;
> >   ctx->Extensions.ARB_texture_buffer_range = true;
> >
> >
> > Marek
> >
> > On Wed, Oct 25, 2017 at 11:42 PM, Dylan Baker 
> >  wrote:
> >
> > There are a significant number of i965 regressions from
> > d96c68146a781c79a23f5181d7050174f1070d90, largely related to 
> > texturing (I
> > can
> > send you a complete list of regressions if you care, but due to the 
> > large
> > number
> > of them I suspect it's something fairly simple).
> >
> > For example:
> > ES31-CTS.functional.texture.format.buffer.r32ui_npot
> >
> > glGetIntegerv() failed: glGetError() returned GL_INVALID_ENUM at
> > gluContextInfo.cpp:229
> >
> > dEQP-GLES31.functional.state_query.integer.texture_buffer_
> > binding_getinteger:
> >
> > glGetIntegerv(GL_TEXTURE_BUFFER_BINDING, 0x7ffee0c43834);
> > // data = { -555819298 }
> > glGetError();
> > // GL_INVALID_ENUM returned
> >  // ERROR: glGetIntegerv: glGetError() returned GL_INVALID_ENUM
> >
> > Dylan
> >
> > Quoting Emil Velikov (2017-10-24 09:30:03)
> > > Hi Marek,
> > >
> > > On 21 October 2017 at 13:54, Marek Olšák  wrote:
> > > > From: Marek Olšák 
> > > >
> > > > We already have piglit tests testing alpha, luminance, and 
> > intensity
> > > > formats. They were skipped by piglit until now.
> > > >
> > > > Additionally, I'm enabling one ARB_texture_buffer_range piglit 
> > test to
> > run
> > > > with the compat profile.
> > >
> > > Can you please mention that ARB_texture_buffer_* on i965 is 
> > unchanged
> > > - aka still enabled only for core profiles.
> > > Out of curiosity - can you tried the series with anything more 
> > than
> > piglit?
> > >
> > > The Intel guys can run the lot through CTS, dEQP... admittedly 
> > only on
> > > Intel hardware.
>

Re: [Mesa-dev] [PATCH 2/3] mesa: enable ARB_texture_buffer_* extensions in the Compatibility profile

2017-10-31 Thread Marek Olšák

This is how I run piglit on i965:
WAFFLE_GBM_DEVICE=/dev/dri/renderD128 PIGLIT_PLATFORM=gbm piglit/bin/glinfo|head
GL_RENDERER = Mesa DRI Intel(R) Ivybridge Desktop

Of course I have Radeon as my main GPU.

Marek

On Wed, Nov 1, 2017 at 12:52 AM, Mark Janes  wrote:
> No, please don't.  We can't have thousands of failures added to CI.
>
> Dylan, can you double check this for Marek?  I'm surprised that it
> doesn't reproduce for him.
>
> -Mark
>
> Marek Olšák  writes:
>
>> I can't reproduce the issue on my IVB. How about I just push this and
>> you guys fix i965 when you have time?
>>
>> Marek
>>
>> On Thu, Oct 26, 2017 at 5:46 PM, Mark Janes  wrote:
>>> That fixed many issues, but:
>>>
>>> On deqp EGL tests, we get:
>>>
>>> dEQP-EGL.functional.create_context_ext.gl_42.rgba_no_depth_no_stencil
>>> deqp-egl: main/api_exec.c:135: _mesa_initialize_exec_table: Assertion 
>>> `ctx->Version > 0' failed.
>>>
>>> On ES31 CTS tests:
>>> ES31-CTS.functional.texture.texture_buffer.render.as_vertex_array_as_vertex_texture_as_fragment_texture.range_size_513
>>> glGetIntegerv() failed: glGetError() returned GL_INVALID_ENUM at
>>> gluContextInfo.cpp:229
>>>
>>> on GL46 CTS (27 failures):
>>> src/mesa/main/teximage.c:595: _mesa_tex_target_is_layered: Assertion
>>> `!"Invalid texture target."' failed.
>>>
>>> Piglit fails 3.5k tests with the same `ctx->Version > 0' assertion as
>>> deqp-egl.
>>>
>>> -Mark
>>>
>>> Dylan Baker  writes:
>>>
 I've pushed it to our CI, I'll let you know tomorrow what it looks like

 Dylan

 Quoting Marek Olšák (2017-10-25 19:52:43)
> Hi Dylan,
>
> Can you please add this and re-test?
>
> diff --git a/src/mesa/drivers/dri/i965/intel_extensions.c 
> b/src/mesa/drivers/
> dri/i965/intel_extensions.c
> index 21cf632..4d17393 100644
> --- a/src/mesa/drivers/dri/i965/intel_extensions.c
> +++ b/src/mesa/drivers/dri/i965/intel_extensions.c
> @@ -178,7 +178,7 @@ intelInitExtensions(struct gl_context *ctx)
>ctx->Extensions.ARB_pipeline_statistics_query = true;
>ctx->Extensions.ARB_sample_shading = true;
>ctx->Extensions.ARB_shading_language_420pack = true;
> -  if (ctx->API == API_OPENGL_CORE) {
> +  if (ctx->API != API_OPENGL_COMPAT) {
>   ctx->Extensions.ARB_texture_buffer_object = true;
>   ctx->Extensions.ARB_texture_buffer_object_rgb32 = true;
>   ctx->Extensions.ARB_texture_buffer_range = true;
>
>
> Marek
>
> On Wed, Oct 25, 2017 at 11:42 PM, Dylan Baker  
> wrote:
>
> There are a significant number of i965 regressions from
> d96c68146a781c79a23f5181d7050174f1070d90, largely related to 
> texturing (I
> can
> send you a complete list of regressions if you care, but due to the 
> large
> number
> of them I suspect it's something fairly simple).
>
> For example:
> ES31-CTS.functional.texture.format.buffer.r32ui_npot
>
> glGetIntegerv() failed: glGetError() returned GL_INVALID_ENUM at
> gluContextInfo.cpp:229
>
> dEQP-GLES31.functional.state_query.integer.texture_buffer_
> binding_getinteger:
>
> glGetIntegerv(GL_TEXTURE_BUFFER_BINDING, 0x7ffee0c43834);
> // data = { -555819298 }
> glGetError();
> // GL_INVALID_ENUM returned
>  // ERROR: glGetIntegerv: glGetError() returned GL_INVALID_ENUM
>
> Dylan
>
> Quoting Emil Velikov (2017-10-24 09:30:03)
> > Hi Marek,
> >
> > On 21 October 2017 at 13:54, Marek Olšák  wrote:
> > > From: Marek Olšák 
> > >
> > > We already have piglit tests testing alpha, luminance, and 
> intensity
> > > formats. They were skipped by piglit until now.
> > >
> > > Additionally, I'm enabling one ARB_texture_buffer_range piglit 
> test to
> run
> > > with the compat profile.
> >
> > Can you please mention that ARB_texture_buffer_* on i965 is 
> unchanged
> > - aka still enabled only for core profiles.
> > Out of curiosity - can you tried the series with anything more than
> piglit?
> >
> > The Intel guys can run the lot through CTS, dEQP... admittedly only 
> on
> > Intel hardware.
> > Still it should help catch if a piece is missing somewhere.
> >
> >
> > -Emil
> > ___
> > mesa-dev mailing list
> > mesa-dev@lists.freedesktop.org
> > https://lists.freedesktop.org/mailman/listinfo/mesa-dev
>
>
___
mesa-dev mailing list

Re: [Mesa-dev] [PATCH 2/3] mesa: enable ARB_texture_buffer_* extensions in the Compatibility profile

2017-10-31 Thread Mark Janes

No, please don't.  We can't have thousands of failures added to CI.

Dylan, can you double check this for Marek?  I'm surprised that it
doesn't reproduce for him.

-Mark

Marek Olšák  writes:

> I can't reproduce the issue on my IVB. How about I just push this and
> you guys fix i965 when you have time?
>
> Marek
>
> On Thu, Oct 26, 2017 at 5:46 PM, Mark Janes  wrote:
>> That fixed many issues, but:
>>
>> On deqp EGL tests, we get:
>>
>> dEQP-EGL.functional.create_context_ext.gl_42.rgba_no_depth_no_stencil
>> deqp-egl: main/api_exec.c:135: _mesa_initialize_exec_table: Assertion 
>> `ctx->Version > 0' failed.
>>
>> On ES31 CTS tests:
>> ES31-CTS.functional.texture.texture_buffer.render.as_vertex_array_as_vertex_texture_as_fragment_texture.range_size_513
>> glGetIntegerv() failed: glGetError() returned GL_INVALID_ENUM at
>> gluContextInfo.cpp:229
>>
>> on GL46 CTS (27 failures):
>> src/mesa/main/teximage.c:595: _mesa_tex_target_is_layered: Assertion
>> `!"Invalid texture target."' failed.
>>
>> Piglit fails 3.5k tests with the same `ctx->Version > 0' assertion as
>> deqp-egl.
>>
>> -Mark
>>
>> Dylan Baker  writes:
>>
>>> I've pushed it to our CI, I'll let you know tomorrow what it looks like
>>>
>>> Dylan
>>>
>>> Quoting Marek Olšák (2017-10-25 19:52:43)
 Hi Dylan,

 Can you please add this and re-test?

 diff --git a/src/mesa/drivers/dri/i965/intel_extensions.c 
 b/src/mesa/drivers/
 dri/i965/intel_extensions.c
 index 21cf632..4d17393 100644
 --- a/src/mesa/drivers/dri/i965/intel_extensions.c
 +++ b/src/mesa/drivers/dri/i965/intel_extensions.c
 @@ -178,7 +178,7 @@ intelInitExtensions(struct gl_context *ctx)
ctx->Extensions.ARB_pipeline_statistics_query = true;
ctx->Extensions.ARB_sample_shading = true;
ctx->Extensions.ARB_shading_language_420pack = true;
 -  if (ctx->API == API_OPENGL_CORE) {
 +  if (ctx->API != API_OPENGL_COMPAT) {
   ctx->Extensions.ARB_texture_buffer_object = true;
   ctx->Extensions.ARB_texture_buffer_object_rgb32 = true;
   ctx->Extensions.ARB_texture_buffer_range = true;


 Marek

 On Wed, Oct 25, 2017 at 11:42 PM, Dylan Baker  
 wrote:

 There are a significant number of i965 regressions from
 d96c68146a781c79a23f5181d7050174f1070d90, largely related to texturing 
 (I
 can
 send you a complete list of regressions if you care, but due to the 
 large
 number
 of them I suspect it's something fairly simple).

 For example:
 ES31-CTS.functional.texture.format.buffer.r32ui_npot

 glGetIntegerv() failed: glGetError() returned GL_INVALID_ENUM at
 gluContextInfo.cpp:229

 dEQP-GLES31.functional.state_query.integer.texture_buffer_
 binding_getinteger:

 glGetIntegerv(GL_TEXTURE_BUFFER_BINDING, 0x7ffee0c43834);
 // data = { -555819298 }
 glGetError();
 // GL_INVALID_ENUM returned
  // ERROR: glGetIntegerv: glGetError() returned GL_INVALID_ENUM

 Dylan

 Quoting Emil Velikov (2017-10-24 09:30:03)
 > Hi Marek,
 >
 > On 21 October 2017 at 13:54, Marek Olšák  wrote:
 > > From: Marek Olšák 
 > >
 > > We already have piglit tests testing alpha, luminance, and 
 intensity
 > > formats. They were skipped by piglit until now.
 > >
 > > Additionally, I'm enabling one ARB_texture_buffer_range piglit 
 test to
 run
 > > with the compat profile.
 >
 > Can you please mention that ARB_texture_buffer_* on i965 is unchanged
 > - aka still enabled only for core profiles.
 > Out of curiosity - can you tried the series with anything more than
 piglit?
 >
 > The Intel guys can run the lot through CTS, dEQP... admittedly only 
 on
 > Intel hardware.
 > Still it should help catch if a piece is missing somewhere.
 >
 >
 > -Emil
 > ___
 > mesa-dev mailing list
 > mesa-dev@lists.freedesktop.org
 > https://lists.freedesktop.org/mailman/listinfo/mesa-dev


___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 2/3] mesa: enable ARB_texture_buffer_* extensions in the Compatibility profile

2017-10-31 Thread Marek Olšák

I can't reproduce the issue on my IVB. How about I just push this and
you guys fix i965 when you have time?

Marek

On Thu, Oct 26, 2017 at 5:46 PM, Mark Janes  wrote:
> That fixed many issues, but:
>
> On deqp EGL tests, we get:
>
> dEQP-EGL.functional.create_context_ext.gl_42.rgba_no_depth_no_stencil
> deqp-egl: main/api_exec.c:135: _mesa_initialize_exec_table: Assertion 
> `ctx->Version > 0' failed.
>
> On ES31 CTS tests:
> ES31-CTS.functional.texture.texture_buffer.render.as_vertex_array_as_vertex_texture_as_fragment_texture.range_size_513
> glGetIntegerv() failed: glGetError() returned GL_INVALID_ENUM at
> gluContextInfo.cpp:229
>
> on GL46 CTS (27 failures):
> src/mesa/main/teximage.c:595: _mesa_tex_target_is_layered: Assertion
> `!"Invalid texture target."' failed.
>
> Piglit fails 3.5k tests with the same `ctx->Version > 0' assertion as
> deqp-egl.
>
> -Mark
>
> Dylan Baker  writes:
>
>> I've pushed it to our CI, I'll let you know tomorrow what it looks like
>>
>> Dylan
>>
>> Quoting Marek Olšák (2017-10-25 19:52:43)
>>> Hi Dylan,
>>>
>>> Can you please add this and re-test?
>>>
>>> diff --git a/src/mesa/drivers/dri/i965/intel_extensions.c 
>>> b/src/mesa/drivers/
>>> dri/i965/intel_extensions.c
>>> index 21cf632..4d17393 100644
>>> --- a/src/mesa/drivers/dri/i965/intel_extensions.c
>>> +++ b/src/mesa/drivers/dri/i965/intel_extensions.c
>>> @@ -178,7 +178,7 @@ intelInitExtensions(struct gl_context *ctx)
>>>ctx->Extensions.ARB_pipeline_statistics_query = true;
>>>ctx->Extensions.ARB_sample_shading = true;
>>>ctx->Extensions.ARB_shading_language_420pack = true;
>>> -  if (ctx->API == API_OPENGL_CORE) {
>>> +  if (ctx->API != API_OPENGL_COMPAT) {
>>>   ctx->Extensions.ARB_texture_buffer_object = true;
>>>   ctx->Extensions.ARB_texture_buffer_object_rgb32 = true;
>>>   ctx->Extensions.ARB_texture_buffer_range = true;
>>>
>>>
>>> Marek
>>>
>>> On Wed, Oct 25, 2017 at 11:42 PM, Dylan Baker  
>>> wrote:
>>>
>>> There are a significant number of i965 regressions from
>>> d96c68146a781c79a23f5181d7050174f1070d90, largely related to texturing 
>>> (I
>>> can
>>> send you a complete list of regressions if you care, but due to the 
>>> large
>>> number
>>> of them I suspect it's something fairly simple).
>>>
>>> For example:
>>> ES31-CTS.functional.texture.format.buffer.r32ui_npot
>>>
>>> glGetIntegerv() failed: glGetError() returned GL_INVALID_ENUM at
>>> gluContextInfo.cpp:229
>>>
>>> dEQP-GLES31.functional.state_query.integer.texture_buffer_
>>> binding_getinteger:
>>>
>>> glGetIntegerv(GL_TEXTURE_BUFFER_BINDING, 0x7ffee0c43834);
>>> // data = { -555819298 }
>>> glGetError();
>>> // GL_INVALID_ENUM returned
>>>  // ERROR: glGetIntegerv: glGetError() returned GL_INVALID_ENUM
>>>
>>> Dylan
>>>
>>> Quoting Emil Velikov (2017-10-24 09:30:03)
>>> > Hi Marek,
>>> >
>>> > On 21 October 2017 at 13:54, Marek Olšák  wrote:
>>> > > From: Marek Olšák 
>>> > >
>>> > > We already have piglit tests testing alpha, luminance, and intensity
>>> > > formats. They were skipped by piglit until now.
>>> > >
>>> > > Additionally, I'm enabling one ARB_texture_buffer_range piglit test 
>>> to
>>> run
>>> > > with the compat profile.
>>> >
>>> > Can you please mention that ARB_texture_buffer_* on i965 is unchanged
>>> > - aka still enabled only for core profiles.
>>> > Out of curiosity - can you tried the series with anything more than
>>> piglit?
>>> >
>>> > The Intel guys can run the lot through CTS, dEQP... admittedly only on
>>> > Intel hardware.
>>> > Still it should help catch if a piece is missing somewhere.
>>> >
>>> >
>>> > -Emil
>>> > ___
>>> > mesa-dev mailing list
>>> > mesa-dev@lists.freedesktop.org
>>> > https://lists.freedesktop.org/mailman/listinfo/mesa-dev
>>>
>>>
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 2/3] mesa: enable ARB_texture_buffer_* extensions in the Compatibility profile

2017-10-26 Thread Mark Janes

That fixed many issues, but:

On deqp EGL tests, we get:

dEQP-EGL.functional.create_context_ext.gl_42.rgba_no_depth_no_stencil
deqp-egl: main/api_exec.c:135: _mesa_initialize_exec_table: Assertion 
`ctx->Version > 0' failed.

On ES31 CTS tests:
ES31-CTS.functional.texture.texture_buffer.render.as_vertex_array_as_vertex_texture_as_fragment_texture.range_size_513
glGetIntegerv() failed: glGetError() returned GL_INVALID_ENUM at
gluContextInfo.cpp:229

on GL46 CTS (27 failures):
src/mesa/main/teximage.c:595: _mesa_tex_target_is_layered: Assertion
`!"Invalid texture target."' failed.

Piglit fails 3.5k tests with the same `ctx->Version > 0' assertion as
deqp-egl.

-Mark

Dylan Baker  writes:

> I've pushed it to our CI, I'll let you know tomorrow what it looks like
>
> Dylan
>
> Quoting Marek Olšák (2017-10-25 19:52:43)
>> Hi Dylan,
>> 
>> Can you please add this and re-test?
>> 
>> diff --git a/src/mesa/drivers/dri/i965/intel_extensions.c b/src/mesa/drivers/
>> dri/i965/intel_extensions.c
>> index 21cf632..4d17393 100644
>> --- a/src/mesa/drivers/dri/i965/intel_extensions.c
>> +++ b/src/mesa/drivers/dri/i965/intel_extensions.c
>> @@ -178,7 +178,7 @@ intelInitExtensions(struct gl_context *ctx)
>>ctx->Extensions.ARB_pipeline_statistics_query = true;
>>ctx->Extensions.ARB_sample_shading = true;
>>ctx->Extensions.ARB_shading_language_420pack = true;
>> -  if (ctx->API == API_OPENGL_CORE) {
>> +  if (ctx->API != API_OPENGL_COMPAT) {
>>   ctx->Extensions.ARB_texture_buffer_object = true;
>>   ctx->Extensions.ARB_texture_buffer_object_rgb32 = true;
>>   ctx->Extensions.ARB_texture_buffer_range = true;
>> 
>> 
>> Marek
>> 
>> On Wed, Oct 25, 2017 at 11:42 PM, Dylan Baker  
>> wrote:
>> 
>> There are a significant number of i965 regressions from
>> d96c68146a781c79a23f5181d7050174f1070d90, largely related to texturing (I
>> can
>> send you a complete list of regressions if you care, but due to the large
>> number
>> of them I suspect it's something fairly simple).
>> 
>> For example:
>> ES31-CTS.functional.texture.format.buffer.r32ui_npot
>> 
>> glGetIntegerv() failed: glGetError() returned GL_INVALID_ENUM at
>> gluContextInfo.cpp:229
>> 
>> dEQP-GLES31.functional.state_query.integer.texture_buffer_
>> binding_getinteger:
>> 
>> glGetIntegerv(GL_TEXTURE_BUFFER_BINDING, 0x7ffee0c43834);
>> // data = { -555819298 }
>> glGetError();
>> // GL_INVALID_ENUM returned
>>  // ERROR: glGetIntegerv: glGetError() returned GL_INVALID_ENUM
>>
>> Dylan
>> 
>> Quoting Emil Velikov (2017-10-24 09:30:03)
>> > Hi Marek,
>> >
>> > On 21 October 2017 at 13:54, Marek Olšák  wrote:
>> > > From: Marek Olšák 
>> > >
>> > > We already have piglit tests testing alpha, luminance, and intensity
>> > > formats. They were skipped by piglit until now.
>> > >
>> > > Additionally, I'm enabling one ARB_texture_buffer_range piglit test 
>> to
>> run
>> > > with the compat profile.
>> >
>> > Can you please mention that ARB_texture_buffer_* on i965 is unchanged
>> > - aka still enabled only for core profiles.
>> > Out of curiosity - can you tried the series with anything more than
>> piglit?
>> >
>> > The Intel guys can run the lot through CTS, dEQP... admittedly only on
>> > Intel hardware.
>> > Still it should help catch if a piece is missing somewhere.
>> >
>> >
>> > -Emil
>> > ___
>> > mesa-dev mailing list
>> > mesa-dev@lists.freedesktop.org
>> > https://lists.freedesktop.org/mailman/listinfo/mesa-dev
>> 
>> 
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 2/3] mesa: enable ARB_texture_buffer_* extensions in the Compatibility profile

2017-10-25 Thread Dylan Baker

I've pushed it to our CI, I'll let you know tomorrow what it looks like

Dylan

Quoting Marek Olšák (2017-10-25 19:52:43)
> Hi Dylan,
> 
> Can you please add this and re-test?
> 
> diff --git a/src/mesa/drivers/dri/i965/intel_extensions.c b/src/mesa/drivers/
> dri/i965/intel_extensions.c
> index 21cf632..4d17393 100644
> --- a/src/mesa/drivers/dri/i965/intel_extensions.c
> +++ b/src/mesa/drivers/dri/i965/intel_extensions.c
> @@ -178,7 +178,7 @@ intelInitExtensions(struct gl_context *ctx)
>ctx->Extensions.ARB_pipeline_statistics_query = true;
>ctx->Extensions.ARB_sample_shading = true;
>ctx->Extensions.ARB_shading_language_420pack = true;
> -  if (ctx->API == API_OPENGL_CORE) {
> +  if (ctx->API != API_OPENGL_COMPAT) {
>   ctx->Extensions.ARB_texture_buffer_object = true;
>   ctx->Extensions.ARB_texture_buffer_object_rgb32 = true;
>   ctx->Extensions.ARB_texture_buffer_range = true;
> 
> 
> Marek
> 
> On Wed, Oct 25, 2017 at 11:42 PM, Dylan Baker  
> wrote:
> 
> There are a significant number of i965 regressions from
> d96c68146a781c79a23f5181d7050174f1070d90, largely related to texturing (I
> can
> send you a complete list of regressions if you care, but due to the large
> number
> of them I suspect it's something fairly simple).
> 
> For example:
> ES31-CTS.functional.texture.format.buffer.r32ui_npot
> 
> glGetIntegerv() failed: glGetError() returned GL_INVALID_ENUM at
> gluContextInfo.cpp:229
> 
> dEQP-GLES31.functional.state_query.integer.texture_buffer_
> binding_getinteger:
> 
> glGetIntegerv(GL_TEXTURE_BUFFER_BINDING, 0x7ffee0c43834);
> // data = { -555819298 }
> glGetError();
> // GL_INVALID_ENUM returned
>  // ERROR: glGetIntegerv: glGetError() returned GL_INVALID_ENUM
>
> Dylan
> 
> Quoting Emil Velikov (2017-10-24 09:30:03)
> > Hi Marek,
> >
> > On 21 October 2017 at 13:54, Marek Olšák  wrote:
> > > From: Marek Olšák 
> > >
> > > We already have piglit tests testing alpha, luminance, and intensity
> > > formats. They were skipped by piglit until now.
> > >
> > > Additionally, I'm enabling one ARB_texture_buffer_range piglit test to
> run
> > > with the compat profile.
> >
> > Can you please mention that ARB_texture_buffer_* on i965 is unchanged
> > - aka still enabled only for core profiles.
> > Out of curiosity - can you tried the series with anything more than
> piglit?
> >
> > The Intel guys can run the lot through CTS, dEQP... admittedly only on
> > Intel hardware.
> > Still it should help catch if a piece is missing somewhere.
> >
> >
> > -Emil
> > ___
> > mesa-dev mailing list
> > mesa-dev@lists.freedesktop.org
> > https://lists.freedesktop.org/mailman/listinfo/mesa-dev
> 
> 


signature.asc
Description: signature
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 2/3] mesa: enable ARB_texture_buffer_* extensions in the Compatibility profile

2017-10-25 Thread Marek Olšák

Hi Dylan,

Can you please add this and re-test?

diff --git a/src/mesa/drivers/dri/i965/intel_extensions.c
b/src/mesa/drivers/dri/i965/intel_extensions.c
index 21cf632..4d17393 100644
--- a/src/mesa/drivers/dri/i965/intel_extensions.c
+++ b/src/mesa/drivers/dri/i965/intel_extensions.c
@@ -178,7 +178,7 @@ intelInitExtensions(struct gl_context *ctx)
   ctx->Extensions.ARB_pipeline_statistics_query = true;
   ctx->Extensions.ARB_sample_shading = true;
   ctx->Extensions.ARB_shading_language_420pack = true;
-  if (ctx->API == API_OPENGL_CORE) {
+  if (ctx->API != API_OPENGL_COMPAT) {
  ctx->Extensions.ARB_texture_buffer_object = true;
  ctx->Extensions.ARB_texture_buffer_object_rgb32 = true;
  ctx->Extensions.ARB_texture_buffer_range = true;


Marek

On Wed, Oct 25, 2017 at 11:42 PM, Dylan Baker 
wrote:

> There are a significant number of i965 regressions from
> d96c68146a781c79a23f5181d7050174f1070d90, largely related to texturing (I
> can
> send you a complete list of regressions if you care, but due to the large
> number
> of them I suspect it's something fairly simple).
>
> For example:
> ES31-CTS.functional.texture.format.buffer.r32ui_npot
>
> glGetIntegerv() failed: glGetError() returned GL_INVALID_ENUM at
> gluContextInfo.cpp:229
>
> dEQP-GLES31.functional.state_query.integer.texture_buffer_
> binding_getinteger:
>
> glGetIntegerv(GL_TEXTURE_BUFFER_BINDING, 0x7ffee0c43834);
> // data = { -555819298 }
> glGetError();
> // GL_INVALID_ENUM returned
>  // ERROR: glGetIntegerv: glGetError() returned GL_INVALID_ENUM
>
> Dylan
>
> Quoting Emil Velikov (2017-10-24 09:30:03)
> > Hi Marek,
> >
> > On 21 October 2017 at 13:54, Marek Olšák  wrote:
> > > From: Marek Olšák 
> > >
> > > We already have piglit tests testing alpha, luminance, and intensity
> > > formats. They were skipped by piglit until now.
> > >
> > > Additionally, I'm enabling one ARB_texture_buffer_range piglit test to
> run
> > > with the compat profile.
> >
> > Can you please mention that ARB_texture_buffer_* on i965 is unchanged
> > - aka still enabled only for core profiles.
> > Out of curiosity - can you tried the series with anything more than
> piglit?
> >
> > The Intel guys can run the lot through CTS, dEQP... admittedly only on
> > Intel hardware.
> > Still it should help catch if a piece is missing somewhere.
> >
> >
> > -Emil
> > ___
> > mesa-dev mailing list
> > mesa-dev@lists.freedesktop.org
> > https://lists.freedesktop.org/mailman/listinfo/mesa-dev
>
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 2/3] mesa: enable ARB_texture_buffer_* extensions in the Compatibility profile

2017-10-25 Thread Ilia Mirkin

On Sat, Oct 21, 2017 at 8:54 AM, Marek Olšák  wrote:
> From: Marek Olšák 
>
> We already have piglit tests testing alpha, luminance, and intensity
> formats. They were skipped by piglit until now.
>
> Additionally, I'm enabling one ARB_texture_buffer_range piglit test to run
> with the compat profile.
> ---
>  src/mapi/glapi/gen/apiexec.py| 12 +---
>  src/mesa/drivers/dri/i965/intel_extensions.c |  8 +---
>  src/mesa/main/extensions_table.h |  6 +++---
>  src/mesa/main/get.c  |  2 --
>  src/mesa/main/get_hash_params.py | 20 ++--
>  src/mesa/main/tests/dispatch_sanity.cpp  |  8 
>  src/mesa/main/texparam.c |  4 ++--
>  src/mesa/state_tracker/st_context.c  |  2 +-
>  src/mesa/state_tracker/st_extensions.c   |  8 +++-
>  src/mesa/state_tracker/st_extensions.h   |  3 ++-
>  src/mesa/state_tracker/st_manager.c  |  2 +-
>  11 files changed, 40 insertions(+), 35 deletions(-)
>
> diff --git a/src/mapi/glapi/gen/apiexec.py b/src/mapi/glapi/gen/apiexec.py
> index 61eda4b..7da0818 100644
> --- a/src/mapi/glapi/gen/apiexec.py
> +++ b/src/mapi/glapi/gen/apiexec.py
> @@ -28,21 +28,21 @@ class exec_info():
>  10).  For example, glCreateProgram was added in OpenGL 2.0, so
>  compatibility=20 and core=31.
>
>  If the attribute is None, then it cannot be supported by that
>  API.  For example, glNewList was removed from core profiles, so
>  compatibility=10 and core=None.
>
>  Each of the attributes that is not None must have a valid value.  The
>  valid ranges are:
>
> -compatiblity: [10, 30]
> +compatibility: [10, )
>  core: [31, )
>  es1: [10, 11]
>  es2: [20, )
>
>  These ranges are enforced by the constructor.
>  """
>  def __init__(self, compatibility=None, core=None, es1=None, es2=None):
>  if compatibility is not None:
>  assert isinstance(compatibility, int)
>  assert compatibility >= 10
> @@ -59,23 +59,22 @@ class exec_info():
>  if es2 is not None:
>  assert isinstance(es2, int)
>  assert es2 >= 20
>
>  self.compatibility = compatibility
>  self.core = core
>  self.es1 = es1
>  self.es2 = es2
>
>  functions = {
> -# OpenGL 3.1 / GL_ARB_texture_buffer_object.  Mesa only exposes this
> -# extension with core profile.
> -"TexBuffer": exec_info(core=31, es2=31),
> +# OpenGL 3.1 / GL_ARB_texture_buffer_object.
> +"TexBuffer": exec_info(compatibility=20, core=31, es2=31),
>
>  # OpenGL 3.2 / GL_OES_geometry_shader.
>  "FramebufferTexture": exec_info(core=32, es2=31),
>
>  # OpenGL 4.0 / GL_ARB_shader_subroutines. Mesa only exposes this
>  # extension with core profile.
>  "GetSubroutineUniformLocation": exec_info(core=31),
>  "GetSubroutineIndex": exec_info(core=31),
>  "GetActiveSubroutineUniformiv": exec_info(core=31),
>  "GetActiveSubroutineUniformName": exec_info(core=31),
> @@ -137,23 +136,22 @@ functions = {
>  "ViewportIndexedf": exec_info(core=32, es2=31),
>  "ViewportIndexedfv": exec_info(core=32, es2=31),
>  "ScissorArrayv": exec_info(core=32, es2=31),
>  "ScissorIndexed": exec_info(core=32, es2=31),
>  "ScissorIndexedv": exec_info(core=32, es2=31),
>  "DepthRangeArrayv": exec_info(core=32),
>  "DepthRangeIndexed": exec_info(core=32),
>  # GetFloati_v also GL_ARB_shader_atomic_counters
>  # GetDoublei_v also GL_ARB_shader_atomic_counters
>
> -# OpenGL 4.3 / GL_ARB_texture_buffer_range.  Mesa can expose the 
> extension
> -# with OpenGL 3.1.
> -"TexBufferRange": exec_info(core=31, es2=31),
> +# OpenGL 4.3 / GL_ARB_texture_buffer_range.
> +"TexBufferRange": exec_info(compatibility=20, core=31, es2=31),
>
>  # OpenGL 4.3 / GL_ARB_framebuffer_no_attachments.  Mesa can expose the
>  # extension with OpenGL 3.0.
>  "FramebufferParameteri": exec_info(compatibility=30, core=31, es2=31),
>  "GetFramebufferParameteri": exec_info(compatibility=30, core=31, es2=31),
>
>  # OpenGL 4.5 / GL_ARB_direct_state_access.   Mesa can expose the 
> extension
>  # with core profile.
>  "CreateTransformFeedbacks": exec_info(core=31),
>  "TransformFeedbackBufferBase": exec_info(core=31),
> diff --git a/src/mesa/drivers/dri/i965/intel_extensions.c 
> b/src/mesa/drivers/dri/i965/intel_extensions.c
> index 519d0a5..21cf632 100644
> --- a/src/mesa/drivers/dri/i965/intel_extensions.c
> +++ b/src/mesa/drivers/dri/i965/intel_extensions.c
> @@ -171,23 +171,25 @@ intelInitExtensions(struct gl_context *ctx)
>   !driQueryOptionb(>optionCache, "disable_blend_func_extended");
>ctx->Extensions.ARB_conditional_render_inverted = true;
>ctx->Extensions.ARB_cull_distance = true;
>ctx->Extensions.ARB_draw_buffers_blend =

Re: [Mesa-dev] [PATCH 2/3] mesa: enable ARB_texture_buffer_* extensions in the Compatibility profile

2017-10-25 Thread Dylan Baker

For list posterity, since my intel email isn't subscribed,

There are a significant number of i965 regressions from 



d96c68146a781c79a23f5181d7050174f1070d90, largely related to texturing (I can   



send you a complete list of regressions if you care, but due to the large 
number  

  
of them I suspect it's something fairly simple).




For example:



ES31-CTS.functional.texture.format.buffer.r32ui_npot




glGetIntegerv() failed: glGetError() returned GL_INVALID_ENUM at 
gluContextInfo.cpp:229  

   

dEQP-GLES31.functional.state_query.integer.texture_buffer_binding_getinteger:   




glGetIntegerv(GL_TEXTURE_BUFFER_BINDING, 0x7ffee0c43834);   



// data = { -555819298 }



glGetError();   



// GL_INVALID_ENUM returned 



 // ERROR: glGetIntegerv: glGetError() returned GL_INVALID_ENUM 




Dylan

Quoting Emil Velikov (2017-10-24 09:30:03)
> Hi Marek,
> 
> On 21 October 2017 at 13:54, Marek Olšák  wrote:
> > From: Marek Olšák 
> >
> > We already have piglit tests testing alpha, luminance, and intensity
> > formats. They were skipped by piglit until now.
> >
> > Additionally, I'm enabling one ARB_texture_buffer_range piglit test to run
> > with the compat profile.
> 
> Can you please mention that ARB_texture_buffer_* on i965 is unchanged
> - aka still enabled only for core profiles.
> Out of curiosity - can you tried the series with anything more than piglit?
> 
> The Intel guys can run the lot through CTS, dEQP... admittedly only on
> Intel hardware.
> Still it should help catch if a piece is missing somewhere.
> 
> 
> -Emil
> ___
> mesa-dev mailing list
> mesa-dev@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev


signature.asc
Description: signature
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 2/3] mesa: enable ARB_texture_buffer_* extensions in the Compatibility profile

2017-10-25 Thread Dylan Baker

I ran it through our CI and there do appear to be a fair number of regressions.
The majority of the errors are in the ES 3.1 CTS (there are also a few in deqp
ES 3.1) and have this as their error message:

glGetIntegerv() failed: glGetError() returned GL_INVALID_ENUM

I'm bisecting now, I'll update you when I know more.

Dylan

Quoting Emil Velikov (2017-10-24 09:30:03)
> Hi Marek,
> 
> On 21 October 2017 at 13:54, Marek Olšák  wrote:
> > From: Marek Olšák 
> >
> > We already have piglit tests testing alpha, luminance, and intensity
> > formats. They were skipped by piglit until now.
> >
> > Additionally, I'm enabling one ARB_texture_buffer_range piglit test to run
> > with the compat profile.
> 
> Can you please mention that ARB_texture_buffer_* on i965 is unchanged
> - aka still enabled only for core profiles.
> Out of curiosity - can you tried the series with anything more than piglit?
> 
> The Intel guys can run the lot through CTS, dEQP... admittedly only on
> Intel hardware.
> Still it should help catch if a piece is missing somewhere.
> 
> 
> -Emil
> ___
> mesa-dev mailing list
> mesa-dev@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev


signature.asc
Description: signature
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 2/3] mesa: enable ARB_texture_buffer_* extensions in the Compatibility profile

2017-10-25 Thread Marek Olšák

On Tue, Oct 24, 2017 at 6:30 PM, Emil Velikov  wrote:
> Hi Marek,
>
> On 21 October 2017 at 13:54, Marek Olšák  wrote:
>> From: Marek Olšák 
>>
>> We already have piglit tests testing alpha, luminance, and intensity
>> formats. They were skipped by piglit until now.
>>
>> Additionally, I'm enabling one ARB_texture_buffer_range piglit test to run
>> with the compat profile.
>
> Can you please mention that ARB_texture_buffer_* on i965 is unchanged
> - aka still enabled only for core profiles.
> Out of curiosity - can you tried the series with anything more than piglit?
>
> The Intel guys can run the lot through CTS, dEQP... admittedly only on
> Intel hardware.
> Still it should help catch if a piece is missing somewhere.

CTS doesn't test this. CTS is pretty useless for Compatibility stuff.
dEQP is more for OpenGL ES than OpenGL. I think we have pretty good
piglit coverage for this.

Marek
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 2/3] mesa: enable ARB_texture_buffer_* extensions in the Compatibility profile

2017-10-24 Thread Eric Anholt

Marek Olšák  writes:

> From: Marek Olšák 
>
> We already have piglit tests testing alpha, luminance, and intensity
> formats. They were skipped by piglit until now.
>
> Additionally, I'm enabling one ARB_texture_buffer_range piglit test to run
> with the compat profile.

Reviewed-by: Eric Anholt 


signature.asc
Description: PGP signature
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 2/3] mesa: enable ARB_texture_buffer_* extensions in the Compatibility profile

2017-10-24 Thread Emil Velikov

Hi Marek,

On 21 October 2017 at 13:54, Marek Olšák  wrote:
> From: Marek Olšák 
>
> We already have piglit tests testing alpha, luminance, and intensity
> formats. They were skipped by piglit until now.
>
> Additionally, I'm enabling one ARB_texture_buffer_range piglit test to run
> with the compat profile.

Can you please mention that ARB_texture_buffer_* on i965 is unchanged
- aka still enabled only for core profiles.
Out of curiosity - can you tried the series with anything more than piglit?

The Intel guys can run the lot through CTS, dEQP... admittedly only on
Intel hardware.
Still it should help catch if a piece is missing somewhere.


-Emil
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [PATCH 2/3] mesa: enable ARB_texture_buffer_* extensions in the Compatibility profile

2017-10-21 Thread Marek Olšák

From: Marek Olšák 

We already have piglit tests testing alpha, luminance, and intensity
formats. They were skipped by piglit until now.

Additionally, I'm enabling one ARB_texture_buffer_range piglit test to run
with the compat profile.
---
 src/mapi/glapi/gen/apiexec.py| 12 +---
 src/mesa/drivers/dri/i965/intel_extensions.c |  8 +---
 src/mesa/main/extensions_table.h |  6 +++---
 src/mesa/main/get.c  |  2 --
 src/mesa/main/get_hash_params.py | 20 ++--
 src/mesa/main/tests/dispatch_sanity.cpp  |  8 
 src/mesa/main/texparam.c |  4 ++--
 src/mesa/state_tracker/st_context.c  |  2 +-
 src/mesa/state_tracker/st_extensions.c   |  8 +++-
 src/mesa/state_tracker/st_extensions.h   |  3 ++-
 src/mesa/state_tracker/st_manager.c  |  2 +-
 11 files changed, 40 insertions(+), 35 deletions(-)

diff --git a/src/mapi/glapi/gen/apiexec.py b/src/mapi/glapi/gen/apiexec.py
index 61eda4b..7da0818 100644
--- a/src/mapi/glapi/gen/apiexec.py
+++ b/src/mapi/glapi/gen/apiexec.py
@@ -28,21 +28,21 @@ class exec_info():
 10).  For example, glCreateProgram was added in OpenGL 2.0, so
 compatibility=20 and core=31.
 
 If the attribute is None, then it cannot be supported by that
 API.  For example, glNewList was removed from core profiles, so
 compatibility=10 and core=None.
 
 Each of the attributes that is not None must have a valid value.  The
 valid ranges are:
 
-compatiblity: [10, 30]
+compatibility: [10, )
 core: [31, )
 es1: [10, 11]
 es2: [20, )
 
 These ranges are enforced by the constructor.
 """
 def __init__(self, compatibility=None, core=None, es1=None, es2=None):
 if compatibility is not None:
 assert isinstance(compatibility, int)
 assert compatibility >= 10
@@ -59,23 +59,22 @@ class exec_info():
 if es2 is not None:
 assert isinstance(es2, int)
 assert es2 >= 20
 
 self.compatibility = compatibility
 self.core = core
 self.es1 = es1
 self.es2 = es2
 
 functions = {
-# OpenGL 3.1 / GL_ARB_texture_buffer_object.  Mesa only exposes this
-# extension with core profile.
-"TexBuffer": exec_info(core=31, es2=31),
+# OpenGL 3.1 / GL_ARB_texture_buffer_object.
+"TexBuffer": exec_info(compatibility=20, core=31, es2=31),
 
 # OpenGL 3.2 / GL_OES_geometry_shader.
 "FramebufferTexture": exec_info(core=32, es2=31),
 
 # OpenGL 4.0 / GL_ARB_shader_subroutines. Mesa only exposes this
 # extension with core profile.
 "GetSubroutineUniformLocation": exec_info(core=31),
 "GetSubroutineIndex": exec_info(core=31),
 "GetActiveSubroutineUniformiv": exec_info(core=31),
 "GetActiveSubroutineUniformName": exec_info(core=31),
@@ -137,23 +136,22 @@ functions = {
 "ViewportIndexedf": exec_info(core=32, es2=31),
 "ViewportIndexedfv": exec_info(core=32, es2=31),
 "ScissorArrayv": exec_info(core=32, es2=31),
 "ScissorIndexed": exec_info(core=32, es2=31),
 "ScissorIndexedv": exec_info(core=32, es2=31),
 "DepthRangeArrayv": exec_info(core=32),
 "DepthRangeIndexed": exec_info(core=32),
 # GetFloati_v also GL_ARB_shader_atomic_counters
 # GetDoublei_v also GL_ARB_shader_atomic_counters
 
-# OpenGL 4.3 / GL_ARB_texture_buffer_range.  Mesa can expose the extension
-# with OpenGL 3.1.
-"TexBufferRange": exec_info(core=31, es2=31),
+# OpenGL 4.3 / GL_ARB_texture_buffer_range.
+"TexBufferRange": exec_info(compatibility=20, core=31, es2=31),
 
 # OpenGL 4.3 / GL_ARB_framebuffer_no_attachments.  Mesa can expose the
 # extension with OpenGL 3.0.
 "FramebufferParameteri": exec_info(compatibility=30, core=31, es2=31),
 "GetFramebufferParameteri": exec_info(compatibility=30, core=31, es2=31),
 
 # OpenGL 4.5 / GL_ARB_direct_state_access.   Mesa can expose the extension
 # with core profile.
 "CreateTransformFeedbacks": exec_info(core=31),
 "TransformFeedbackBufferBase": exec_info(core=31),
diff --git a/src/mesa/drivers/dri/i965/intel_extensions.c 
b/src/mesa/drivers/dri/i965/intel_extensions.c
index 519d0a5..21cf632 100644
--- a/src/mesa/drivers/dri/i965/intel_extensions.c
+++ b/src/mesa/drivers/dri/i965/intel_extensions.c
@@ -171,23 +171,25 @@ intelInitExtensions(struct gl_context *ctx)
  !driQueryOptionb(>optionCache, "disable_blend_func_extended");
   ctx->Extensions.ARB_conditional_render_inverted = true;
   ctx->Extensions.ARB_cull_distance = true;
   ctx->Extensions.ARB_draw_buffers_blend = true;
   ctx->Extensions.ARB_enhanced_layouts = true;
   ctx->Extensions.ARB_ES3_compatibility = true;
   ctx->Extensions.ARB_fragment_layer_viewport = true;
   ctx->Extensions.ARB_pipeline_statistics_query = true;
   ctx->Extensions.ARB_sample_shading =

Re: [Mesa-dev] [PATCH 2/3] mesa: enable ARB_texture_buffer_* extensions in the Compatibility profile

Re: [Mesa-dev] [PATCH 2/3] mesa: enable ARB_texture_buffer_* extensions in the Compatibility profile

Re: [Mesa-dev] [PATCH 2/3] mesa: enable ARB_texture_buffer_* extensions in the Compatibility profile

Re: [Mesa-dev] [PATCH 2/3] mesa: enable ARB_texture_buffer_* extensions in the Compatibility profile

Re: [Mesa-dev] [PATCH 2/3] mesa: enable ARB_texture_buffer_* extensions in the Compatibility profile

Re: [Mesa-dev] [PATCH 2/3] mesa: enable ARB_texture_buffer_* extensions in the Compatibility profile

Re: [Mesa-dev] [PATCH 2/3] mesa: enable ARB_texture_buffer_* extensions in the Compatibility profile

Re: [Mesa-dev] [PATCH 2/3] mesa: enable ARB_texture_buffer_* extensions in the Compatibility profile

Re: [Mesa-dev] [PATCH 2/3] mesa: enable ARB_texture_buffer_* extensions in the Compatibility profile

Re: [Mesa-dev] [PATCH 2/3] mesa: enable ARB_texture_buffer_* extensions in the Compatibility profile

Re: [Mesa-dev] [PATCH 2/3] mesa: enable ARB_texture_buffer_* extensions in the Compatibility profile

Re: [Mesa-dev] [PATCH 2/3] mesa: enable ARB_texture_buffer_* extensions in the Compatibility profile

Re: [Mesa-dev] [PATCH 2/3] mesa: enable ARB_texture_buffer_* extensions in the Compatibility profile

Re: [Mesa-dev] [PATCH 2/3] mesa: enable ARB_texture_buffer_* extensions in the Compatibility profile

Re: [Mesa-dev] [PATCH 2/3] mesa: enable ARB_texture_buffer_* extensions in the Compatibility profile

Re: [Mesa-dev] [PATCH 2/3] mesa: enable ARB_texture_buffer_* extensions in the Compatibility profile

Re: [Mesa-dev] [PATCH 2/3] mesa: enable ARB_texture_buffer_* extensions in the Compatibility profile

Re: [Mesa-dev] [PATCH 2/3] mesa: enable ARB_texture_buffer_* extensions in the Compatibility profile

Re: [Mesa-dev] [PATCH 2/3] mesa: enable ARB_texture_buffer_* extensions in the Compatibility profile

Re: [Mesa-dev] [PATCH 2/3] mesa: enable ARB_texture_buffer_* extensions in the Compatibility profile

Re: [Mesa-dev] [PATCH 2/3] mesa: enable ARB_texture_buffer_* extensions in the Compatibility profile

Re: [Mesa-dev] [PATCH 2/3] mesa: enable ARB_texture_buffer_* extensions in the Compatibility profile

[Mesa-dev] [PATCH 2/3] mesa: enable ARB_texture_buffer_* extensions in the Compatibility profile

23 matches

Site Navigation

Mail list logo

Footer information