[Mesa-dev] [PATCH 2/5] meson: add Wundef to the build flags

[Emil Velikov]

From: Emil Velikov 

Analogous to the other build systems.

Cc: Eric Engestrom 
Cc: Dylan Baker 
Signed-off-by: Emil Velikov 
---
 meson.build | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/meson.build b/meson.build
index 53013e47ec4..2e704e18c93 100644
--- a/meson.build
+++ b/meson.build
@@ -468,7 +468,7 @@ endif
 
 # Check for generic C arguments
 c_args = []
-foreach a : ['-Wall', '-Werror=implicit-function-declaration',
+foreach a : ['-Wall', '-Wundef', '-Werror=implicit-function-declaration',
  '-Werror=missing-prototypes', '-fno-math-errno',
  '-fno-trapping-math', '-Qunused-arguments']
   if cc.has_argument(a)
@@ -483,7 +483,7 @@ endif
 # Check for generic C++ arguments
 cpp = meson.get_compiler('cpp')
 cpp_args = []
-foreach a : ['-Wall', '-fno-math-errno', '-fno-trapping-math',
+foreach a : ['-Wall', '-Wundef', '-fno-math-errno', '-fno-trapping-math',
  '-Qunused-arguments', '-Wno-non-virtual-dtor']
   if cpp.has_argument(a)
 cpp_args += a
-- 
2.14.1

___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 2/5] meson: add Wundef to the build flags

[Dylan Baker]

This seems reasonable,
Reviewed-by: Dylan Baker 

Quoting Emil Velikov (2017-11-24 06:25:03)
> From: Emil Velikov 
> 
> Analogous to the other build systems.
> 
> Cc: Eric Engestrom 
> Cc: Dylan Baker 
> Signed-off-by: Emil Velikov 
> ---
>  meson.build | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/meson.build b/meson.build
> index 53013e47ec4..2e704e18c93 100644
> --- a/meson.build
> +++ b/meson.build
> @@ -468,7 +468,7 @@ endif
>  
>  # Check for generic C arguments
>  c_args = []
> -foreach a : ['-Wall', '-Werror=implicit-function-declaration',
> +foreach a : ['-Wall', '-Wundef', '-Werror=implicit-function-declaration',
>   '-Werror=missing-prototypes', '-fno-math-errno',
>   '-fno-trapping-math', '-Qunused-arguments']
>if cc.has_argument(a)
> @@ -483,7 +483,7 @@ endif
>  # Check for generic C++ arguments
>  cpp = meson.get_compiler('cpp')
>  cpp_args = []
> -foreach a : ['-Wall', '-fno-math-errno', '-fno-trapping-math',
> +foreach a : ['-Wall', '-Wundef', '-fno-math-errno', '-fno-trapping-math',
>   '-Qunused-arguments', '-Wno-non-virtual-dtor']
>if cpp.has_argument(a)
>  cpp_args += a
> -- 
> 2.14.1
> 


signature.asc
Description: signature
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 2/5] meson: add Wundef to the build flags

[Dylan Baker]

Although now that I think about it, meson does have a b_undef option, so
actually the right way to do this is to add
'b_undef=true' to the default options in the project() call.

Sorry for the confusion,

Dylan

Quoting Dylan Baker (2017-11-27 10:22:40)
> This seems reasonable,
> Reviewed-by: Dylan Baker 
> 
> Quoting Emil Velikov (2017-11-24 06:25:03)
> > From: Emil Velikov 
> > 
> > Analogous to the other build systems.
> > 
> > Cc: Eric Engestrom 
> > Cc: Dylan Baker 
> > Signed-off-by: Emil Velikov 
> > ---
> >  meson.build | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> > 
> > diff --git a/meson.build b/meson.build
> > index 53013e47ec4..2e704e18c93 100644
> > --- a/meson.build
> > +++ b/meson.build
> > @@ -468,7 +468,7 @@ endif
> >  
> >  # Check for generic C arguments
> >  c_args = []
> > -foreach a : ['-Wall', '-Werror=implicit-function-declaration',
> > +foreach a : ['-Wall', '-Wundef', '-Werror=implicit-function-declaration',
> >   '-Werror=missing-prototypes', '-fno-math-errno',
> >   '-fno-trapping-math', '-Qunused-arguments']
> >if cc.has_argument(a)
> > @@ -483,7 +483,7 @@ endif
> >  # Check for generic C++ arguments
> >  cpp = meson.get_compiler('cpp')
> >  cpp_args = []
> > -foreach a : ['-Wall', '-fno-math-errno', '-fno-trapping-math',
> > +foreach a : ['-Wall', '-Wundef', '-fno-math-errno', '-fno-trapping-math',
> >   '-Qunused-arguments', '-Wno-non-virtual-dtor']
> >if cpp.has_argument(a)
> >  cpp_args += a
> > -- 
> > 2.14.1
> > 
> 
> 
> ___
> mesa-dev mailing list
> mesa-dev@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev


signature.asc
Description: signature
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 2/5] meson: add Wundef to the build flags

[Dylan Baker]

Quoting Dylan Baker (2017-11-27 10:40:18)
> Although now that I think about it, meson does have a b_undef option, so
> actually the right way to do this is to add
> 'b_undef=true' to the default options in the project() call.
> 
> Sorry for the confusion,
> 
> Dylan
> 

And I can't read documentation apparently. My original rb stands, please ignore
the above.

Dylan


signature.asc
Description: signature
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev