Re: [Mesa-dev] [PATCH 20/20] tests/glx: Add unit tests for GLX_ARB_create_context GLX protocol
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 12/20/2011 12:31 PM, Ian Romanick wrote: > From: Ian Romanick > > This adds a new tests directory at the top-level and some extra build > infrastructure. The tests use the Google C++ Testing Framework, and > they will only be built if configure can detect its availability. The > tests are automatically wired-in to run with 'make check'. > > Signed-off-by: Ian Romanick > --- > Makefile |2 +- > configure.ac | 20 +- > src/glx/Makefile |5 +- > tests/Makefile.am |1 + > tests/glx/Makefile.am | 16 + > tests/glx/clientinfo_unittest.cpp | 723 > + > tests/glx/create_context_unittest.cpp | 513 +++ > tests/glx/fake_glx_screen.cpp | 57 +++ > tests/glx/fake_glx_screen.h | 149 +++ > tests/glx/mock_xdisplay.h | 32 ++ > 10 files changed, 1514 insertions(+), 4 deletions(-) > create mode 100644 tests/Makefile.am > create mode 100644 tests/glx/Makefile.am > create mode 100644 tests/glx/clientinfo_unittest.cpp > create mode 100644 tests/glx/create_context_unittest.cpp > create mode 100644 tests/glx/fake_glx_screen.cpp > create mode 100644 tests/glx/fake_glx_screen.h > create mode 100644 tests/glx/mock_xdisplay.h I'm not qualified to review these tests, but I do like the idea of adding unit tests to Mesa with gtest. Acked-by: Chad Versace - Chad Versace chad.vers...@linux.intel.com -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.11 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iQIcBAEBAgAGBQJO/P8eAAoJEAIvNt057x8ik4MQALVQjB8+bCNniN1+vh1gqL+p DMaC9GwCsILuUFf9Z5kVs7U2PLEFFMGJ0xP3vSivA63yZNN9pFkhrRTmdrney5ND Ubc/uNlW6X01AQp/aWZ8tt/mLylaZh9TrC+2mvuizd9Bnw4MSRipsGNjp8qwq2Kz mzaNpadfMeKXszn4PQFOTOQ+kKdNxuLDns6aD0aHM2v1KAZNeF/yw7dpiyBX4qq4 GR6nLjSoxSJ9FOR8q+5DjY7vwbYezSH/V2WcRAwnq7lEgjDJAGOwkC86sTi/bGJ1 pE178/6akQF2/kt6zE9Co06GHLSfVQ1jyHRYZe+8eC8xohrqCLwN0CVSg8eAQ8Dz EW2aFnLaFrWhJ+vpHxTLt8SMiZoIalG+x2ZKFbCjw7dsCCInZjEPuuO47LeB/apy iTNhF2nTXsF7CrUsawAol54df8Eka8DY560lGUWW4Fchk/5Ym8zIUdbkeJTbbOCT NEOKagORTqs2BNhnAjnjpRWpoIK0+bRintRgcC09YSFFnp+/RbAB0CWh32Q0FMqr e4YPk7Ukg/fphVx8ncAlXkKX/GuVwMiyq1wyH7yfpt3/r42jwJ3qVgmG9xmMbSPH P/X/vMusxWchn2jZQ4l1Ui2SrG1gFK8BKB04USVM+kflayrZttnnBjLPU487zWPz kxANracRn4G/tuvgqxWj =5OXj -END PGP SIGNATURE- ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
Re: [Mesa-dev] [PATCH 20/20] tests/glx: Add unit tests for GLX_ARB_create_context GLX protocol
Hi Ever since these tests went in I get failures during configure: configure: creating ./config.status config.status: creating configs/autoconf config.status: error: cannot find input file: `tests/Makefile.in' Before I raise a bug am I doing something stupid? Cheers Mike ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
Re: [Mesa-dev] [PATCH 20/20] tests/glx: Add unit tests for GLX_ARB_create_context GLX protocol
On 01/03/2012 11:13 AM, Mike Lothian wrote: Hi Ever since these tests went in I get failures during configure: configure: creating ./config.status config.status: creating configs/autoconf config.status: error: cannot find input file: `tests/Makefile.in' Before I raise a bug am I doing something stupid? It's possible that I didn't get the automake magic right when gtest isn't installed. Is the program gtest-config in your path? ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
Re: [Mesa-dev] [PATCH 20/20] tests/glx: Add unit tests for GLX_ARB_create_context GLX protocol
On 3 January 2012 20:27, Ian Romanick wrote: > On 01/03/2012 11:13 AM, Mike Lothian wrote: >> >> Hi >> >> Ever since these tests went in I get failures during configure: >> >> >> configure: creating ./config.status >> config.status: creating configs/autoconf >> config.status: error: cannot find input file: `tests/Makefile.in' >> >> Before I raise a bug am I doing something stupid? > > > It's possible that I didn't get the automake magic right when gtest isn't > installed. Is the program gtest-config in your path? Yes I have gtest-config in my path - it was apparently pulled in by gmock which is required by Clementine Should I un-install these, pass a configure parameter to mesa or is there something extra required in the automake hocus pocus? ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
Re: [Mesa-dev] [PATCH 20/20] tests/glx: Add unit tests for GLX_ARB_create_context GLX protocol
On 3 January 2012 20:27, Ian Romanick wrote: > On 01/03/2012 11:13 AM, Mike Lothian wrote: >> >> Hi >> >> Ever since these tests went in I get failures during configure: >> >> >> configure: creating ./config.status >> config.status: creating configs/autoconf >> config.status: error: cannot find input file: `tests/Makefile.in' >> >> Before I raise a bug am I doing something stupid? > > > It's possible that I didn't get the automake magic right when gtest isn't > installed. Is the program gtest-config in your path? I still get the issue even if I uninstall gtest I notice the log also contains: /bin/sh: /var/tmp/portage/media-libs/mesa-/work/Mesa-/bin/missing: No such file or directory configure: WARNING: `missing' script is too old or missing and I'm attaching the full build log too if that helps [32;01m * [39;49;00mPackage:media-libs/mesa- [32;01m * [39;49;00mRepository: x11 [32;01m * [39;49;00mMaintainer: x...@gentoo.org [32;01m * [39;49;00mUSE:amd64 classic consolekit egl elibc_glibc g3dvl gallium gbm gles2 kernel_linux llvm multilib nptl openvg policykit shared-dricore shared-glapi userland_GNU video_cards_i965 video_cards_r600 xvmc [32;01m * [39;49;00mFEATURES: sandbox >>> Unpacking source... GIT update --> repository: git://anongit.freedesktop.org/mesa/mesa at the commit:7e291e922e53a70d84751538b15c6c16310cca7f branch: master storage directory:"/usr/portage/distfiles/egit-src/mesa" checkout type:bare repository Cloning into '/var/tmp/portage/media-libs/mesa-/work/Mesa-'... done. Branch branch-master set up to track remote branch master from origin. Switched to a new branch 'branch-master' >>> Unpacked to /var/tmp/portage/media-libs/mesa-/work/Mesa- >>> Source unpacked in /var/tmp/portage/media-libs/mesa-/work >>> Preparing source in /var/tmp/portage/media-libs/mesa-/work/Mesa- ... [32;01m*[0m Running eautoreconf in '/var/tmp/portage/media-libs/mesa-/work/Mesa-' ... [32;01m*[0m Running aclocal ... [A[184C [34;01m[ [32;01mok[34;01m ][0m [32;01m*[0m Running autoconf ... [A[184C [34;01m[ [32;01mok[34;01m ][0m >>> Source prepared. >>> Configuring source in /var/tmp/portage/media-libs/mesa-/work/Mesa- ... * econf: updating Mesa-/bin/config.sub with /usr/share/gnuconfig/config.sub * econf: updating Mesa-/bin/config.guess with /usr/share/gnuconfig/config.guess ./configure --prefix=/usr --build=x86_64-pc-linux-gnu --host=x86_64-pc-linux-gnu --mandir=/usr/share/man --infodir=/usr/share/info --datadir=/usr/share --sysconfdir=/etc --localstatedir=/var/lib --libdir=/usr/lib64 --disable-dependency-tracking --disable-option-checking --enable-dri --enable-glx --enable-xcb --enable-texture-float --disable-debug --enable-egl --enable-gbm --disable-gles1 --enable-gles2 --enable-glx-tls --disable-osmesa --enable-asm --enable-shared-dricore --enable-shared-glapi --with-dri-drivers=,swrast,i965 --with-gallium-drivers=,swrast,r600 --with-egl-platforms=x11,drm --enable-gallium-egl --disable-d3d1x --enable-gallium-g3dvl --enable-gallium-llvm --enable-openvg --disable-vdpau --enable-xvmc checking build system type... x86_64-pc-linux-gnu checking host system type... x86_64-pc-linux-gnu checking for a BSD-compatible install... /usr/bin/install -c checking whether build environment is sane... yes /bin/sh: /var/tmp/portage/media-libs/mesa-/work/Mesa-/bin/missing: No such file or directory configure: WARNING: `missing' script is too old or missing checking for a thread-safe mkdir -p... /bin/mkdir -p checking for gawk... gawk checking whether make sets $(MAKE)... yes checking for style of include used by make... GNU checking for x86_64-pc-linux-gnu-gcc... x86_64-pc-linux-gnu-gcc checking whether the C compiler works... yes checking for C compiler default output file name... a.out checking for suffix of executables... checking whether we are cross compiling... no checking for suffix of object files... o checking whether we are using the GNU C compiler... yes checking whether x86_64-pc-linux-gnu-gcc accepts -g... yes checking for x86_64-pc-linux-gnu-gcc option to accept ISO C89... none needed checking dependency style of x86_64-pc-linux-gnu-gcc... none checking how to run the C preprocessor... x86_64-pc-linux-gnu-gcc -E checking for x86_64-pc-linux-gnu-gcc... (cached) x86_64-pc-linux-gnu-gcc checking whether we are using the GNU C compiler... (cached) yes checking whether x86_64-pc-linux-gnu-gcc accepts -g... (cached) yes checking for x86_64-pc-linux-gnu-gcc option to accept ISO C89... (cached) none needed checking dependency style of x86_64-pc-linux-gnu-gcc... (cached) none checking for x86_64-pc-linux-gnu-g++... x86_64-pc-linux-gnu-g++ checking whether we are using the GNU C++ compiler... yes checking whether x86_64-pc-linux-gnu-g++ accepts -g... yes checking dependency style of x86_64-pc-linux-gnu-g++... none checking for gmake...
Re: [Mesa-dev] [PATCH 20/20] tests/glx: Add unit tests for GLX_ARB_create_context GLX protocol
On 01/03/2012 06:06 PM, Mike Lothian wrote: On 3 January 2012 20:27, Ian Romanick wrote: On 01/03/2012 11:13 AM, Mike Lothian wrote: Hi Ever since these tests went in I get failures during configure: configure: creating ./config.status config.status: creating configs/autoconf config.status: error: cannot find input file: `tests/Makefile.in' Before I raise a bug am I doing something stupid? It's possible that I didn't get the automake magic right when gtest isn't installed. Is the program gtest-config in your path? I still get the issue even if I uninstall gtest I notice the log also contains: /bin/sh: /var/tmp/portage/media-libs/mesa-/work/Mesa-/bin/missing: No such file or directory configure: WARNING: `missing' script is too old or missing and I'm attaching the full build log too if that helps You should build from GIT, not from some tarball. I think Gaetan was correct. Some files aren't getting into the tarball. I'll have to fix that later, but I have much bigger fish to try in the mean time. ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
Re: [Mesa-dev] [PATCH 20/20] tests/glx: Add unit tests for GLX_ARB_create_context GLX protocol
On 12-01-03 03:27 PM, Ian Romanick wrote: > On 01/03/2012 11:13 AM, Mike Lothian wrote: >> Hi >> >> Ever since these tests went in I get failures during configure: >> >> >> configure: creating ./config.status >> config.status: creating configs/autoconf >> config.status: error: cannot find input file: `tests/Makefile.in' >> >> Before I raise a bug am I doing something stupid? > > It's possible that I didn't get the automake magic right when gtest > isn't installed. Is the program gtest-config in your path? This is usually because tests/Makefile.in did not get generataed by Automake. This is most likely to happen from a tarball where Makefile.in was not distributed. I noticed the toplevel Makefile does not navigate down to the tests subdir, so make dist would probably not include Makefile.in. You have "inserted" an orphan Automake subdir so there is probably some additional wiring to do. There is a section in the Automake manual to integrate custom makefiles, but I don't know if it covers your scenario. > ___ > xorg-de...@lists.x.org: X.Org development > Archives: http://lists.x.org/archives/xorg-devel > Info: http://lists.x.org/mailman/listinfo/xorg-devel > ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
Re: [Mesa-dev] [PATCH 20/20] tests/glx: Add unit tests for GLX_ARB_create_context GLX protocol
On 4 January 2012 03:50, Ian Romanick wrote: > On 01/03/2012 06:06 PM, Mike Lothian wrote: >> >> On 3 January 2012 20:27, Ian Romanick wrote: >>> >>> On 01/03/2012 11:13 AM, Mike Lothian wrote: Hi Ever since these tests went in I get failures during configure: configure: creating ./config.status config.status: creating configs/autoconf config.status: error: cannot find input file: `tests/Makefile.in' Before I raise a bug am I doing something stupid? >>> >>> >>> >>> It's possible that I didn't get the automake magic right when gtest isn't >>> installed. Is the program gtest-config in your path? >> >> >> I still get the issue even if I uninstall gtest >> >> I notice the log also contains: >> >> /bin/sh: /var/tmp/portage/media-libs/mesa-/work/Mesa-/bin/missing: >> No such file or directory >> configure: WARNING: `missing' script is too old or missing >> >> and I'm attaching the full build log too if that helps > > > You should build from GIT, not from some tarball. I think Gaetan was > correct. Some files aren't getting into the tarball. I'll have to fix that > later, but I have much bigger fish to try in the mean time. I am building from git - I'm using the gentoo live ebuild. It pulls from git then builds the sources ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
Re: [Mesa-dev] [PATCH 20/20] tests/glx: Add unit tests for GLX_ARB_create_context GLX protocol
On 01/04/2012 12:54 AM, Mike Lothian wrote: On 4 January 2012 03:50, Ian Romanick wrote: On 01/03/2012 06:06 PM, Mike Lothian wrote: On 3 January 2012 20:27, Ian Romanickwrote: On 01/03/2012 11:13 AM, Mike Lothian wrote: Hi Ever since these tests went in I get failures during configure: configure: creating ./config.status config.status: creating configs/autoconf config.status: error: cannot find input file: `tests/Makefile.in' Before I raise a bug am I doing something stupid? It's possible that I didn't get the automake magic right when gtest isn't installed. Is the program gtest-config in your path? I still get the issue even if I uninstall gtest I notice the log also contains: /bin/sh: /var/tmp/portage/media-libs/mesa-/work/Mesa-/bin/missing: No such file or directory configure: WARNING: `missing' script is too old or missing and I'm attaching the full build log too if that helps You should build from GIT, not from some tarball. I think Gaetan was correct. Some files aren't getting into the tarball. I'll have to fix that later, but I have much bigger fish to try in the mean time. I am building from git - I'm using the gentoo live ebuild. It pulls from git then builds the sources Okay, I looked back at your build output, and I think I see the problem: * econf: updating Mesa-/bin/config.sub with /usr/share/gnuconfig/config.sub * econf: updating Mesa-/bin/config.guess with /usr/share/gnuconfig/config.guess ./configure --prefix=/usr --build=x86_64-pc-linux-gnu --host=x86_64-pc-linux-gnu --mandir=/usr/share/man --infodir=/usr/share/info --datadir=/usr/share --sysconfdir=/etc --localstatedir=/var/lib --libdir=/usr/lib64 --disable-dependency-tracking --disable-option-checking --enable-dri --enable-glx --enable-xcb --enable-texture-float --disable-debug --enable-egl --enable-gbm --disable-gles1 --enable-gles2 --enable-glx-tls --disable-osmesa --enable-asm --enable-shared-dricore --enable-shared-glapi --with-dri-drivers=,swrast,i965 --with-gallium-drivers=,swrast,r600 --with-egl-platforms=x11,drm --enable-gallium-egl --disable-d3d1x --enable-gallium-g3dvl --enable-gallium-llvm --enable-openvg --disable-vdpau --enable-xvmc Since it's a raw GIT tree, this should be 'autogen.sh' instead of 'configure'. The Makefile.in files are generated by autoreconf (run by autogen.sh) and consumed by configure. Since they haven't been generated, configure can't find them and gets angry. The ebuild scripts need to either run ./autogen.sh or run 'autoreconf -v --install' before running configure. I bet that will fix it, and I bet that's why only Gentoo users are still having problems. Can you give that a try? ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
Re: [Mesa-dev] [PATCH 20/20] tests/glx: Add unit tests for GLX_ARB_create_context GLX protocol
Hi, On 4 January 2012 18:45, Ian Romanick wrote: > Okay, I looked back at your build output, and I think I see the problem: > > * econf: updating Mesa-/bin/config.sub with > /usr/share/gnuconfig/config.sub > * econf: updating Mesa-/bin/config.guess with > /usr/share/gnuconfig/config.guess > ./configure --prefix=/usr --build=x86_64-pc-linux-gnu > [...] > > Since it's a raw GIT tree, this should be 'autogen.sh' instead of > 'configure'. The Makefile.in files are generated by autoreconf (run by > autogen.sh) and consumed by configure. Since they haven't been generated, > configure can't find them and gets angry. The ebuild scripts need to either > run ./autogen.sh or run 'autoreconf -v --install' before running configure. > > I bet that will fix it, and I bet that's why only Gentoo users are still > having problems. Can you give that a try? See immediately before that: >>> Preparing source in /var/tmp/portage/media-libs/mesa-/work/Mesa- ... Running eautoreconf in '/var/tmp/portage/media-libs/mesa-/work/Mesa-' ... Running aclocal ... [ok] Running autoconf ... [ok] >>> Source prepared. Cheers, Daniel ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
Re: [Mesa-dev] [PATCH 20/20] tests/glx: Add unit tests for GLX_ARB_create_context GLX protocol
On 01/04/2012 10:55 AM, Daniel Stone wrote: Hi, On 4 January 2012 18:45, Ian Romanick wrote: Okay, I looked back at your build output, and I think I see the problem: * econf: updating Mesa-/bin/config.sub with /usr/share/gnuconfig/config.sub * econf: updating Mesa-/bin/config.guess with /usr/share/gnuconfig/config.guess ./configure --prefix=/usr --build=x86_64-pc-linux-gnu [...] Since it's a raw GIT tree, this should be 'autogen.sh' instead of 'configure'. The Makefile.in files are generated by autoreconf (run by autogen.sh) and consumed by configure. Since they haven't been generated, configure can't find them and gets angry. The ebuild scripts need to either run ./autogen.sh or run 'autoreconf -v --install' before running configure. I bet that will fix it, and I bet that's why only Gentoo users are still having problems. Can you give that a try? See immediately before that: Preparing source in /var/tmp/portage/media-libs/mesa-/work/Mesa- ... Running eautoreconf in '/var/tmp/portage/media-libs/mesa-/work/Mesa-' ... Running aclocal ... [ok] Running autoconf ... [ok] Source prepared. Okay. I give up. I have no clue why it's not working. Patches welcome. :( Cheers, Daniel ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
Re: [Mesa-dev] [PATCH 20/20] tests/glx: Add unit tests for GLX_ARB_create_context GLX protocol
On Mit, 2012-01-04 at 10:56 -0800, Ian Romanick wrote: > On 01/04/2012 10:55 AM, Daniel Stone wrote: > > Hi, > > > > On 4 January 2012 18:45, Ian Romanick wrote: > >> Okay, I looked back at your build output, and I think I see the problem: > >> > >> * econf: updating Mesa-/bin/config.sub with > >> /usr/share/gnuconfig/config.sub > >> * econf: updating Mesa-/bin/config.guess with > >> /usr/share/gnuconfig/config.guess > >> ./configure --prefix=/usr --build=x86_64-pc-linux-gnu > >> [...] > >> > >> Since it's a raw GIT tree, this should be 'autogen.sh' instead of > >> 'configure'. The Makefile.in files are generated by autoreconf (run by > >> autogen.sh) and consumed by configure. Since they haven't been generated, > >> configure can't find them and gets angry. The ebuild scripts need to > >> either > >> run ./autogen.sh or run 'autoreconf -v --install' before running configure. > >> > >> I bet that will fix it, and I bet that's why only Gentoo users are still > >> having problems. Can you give that a try? > > > > See immediately before that: > Preparing source in /var/tmp/portage/media-libs/mesa-/work/Mesa- > ... > > Running eautoreconf in > > '/var/tmp/portage/media-libs/mesa-/work/Mesa-' ... > > Running aclocal ... [ok] > > Running autoconf ... [ok] > Source prepared. > > Okay. I give up. I have no clue why it's not working. Patches welcome. :( It's not running automake (just like the Mesa toplevel Makefile isn't...). -- Earthling Michel Dänzer | http://www.amd.com Libre software enthusiast | Debian, X and DRI developer ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
Re: [Mesa-dev] [PATCH 20/20] tests/glx: Add unit tests for GLX_ARB_create_context GLX protocol
On 01/04/2012 11:05 AM, Michel Dänzer wrote: On Mit, 2012-01-04 at 10:56 -0800, Ian Romanick wrote: On 01/04/2012 10:55 AM, Daniel Stone wrote: Hi, On 4 January 2012 18:45, Ian Romanick wrote: Okay, I looked back at your build output, and I think I see the problem: * econf: updating Mesa-/bin/config.sub with /usr/share/gnuconfig/config.sub * econf: updating Mesa-/bin/config.guess with /usr/share/gnuconfig/config.guess ./configure --prefix=/usr --build=x86_64-pc-linux-gnu [...] Since it's a raw GIT tree, this should be 'autogen.sh' instead of 'configure'. The Makefile.in files are generated by autoreconf (run by autogen.sh) and consumed by configure. Since they haven't been generated, configure can't find them and gets angry. The ebuild scripts need to either run ./autogen.sh or run 'autoreconf -v --install' before running configure. I bet that will fix it, and I bet that's why only Gentoo users are still having problems. Can you give that a try? See immediately before that: Preparing source in /var/tmp/portage/media-libs/mesa-/work/Mesa- ... Running eautoreconf in '/var/tmp/portage/media-libs/mesa-/work/Mesa-' ... Running aclocal ... [ok] Running autoconf ... [ok] Source prepared. Okay. I give up. I have no clue why it's not working. Patches welcome. :( It's not running automake (just like the Mesa toplevel Makefile isn't...). Right... autoreconf does aclocal, autoconf, and automake all in one shot. That makes sense. About adding automake to the toplevel Makefile, where should that go? It seems like adding it to 'default' or similar will break the non-autotool builds. Doing that so close before a release seems mean. Since the automake business is only necessary for 'make check', would putting it in the 'check' target be sufficient? (I think my autotool ignorance is showing.) ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
Re: [Mesa-dev] [PATCH 20/20] tests/glx: Add unit tests for GLX_ARB_create_context GLX protocol
2012/1/4 Ian Romanick : > On 01/04/2012 11:05 AM, Michel Dänzer wrote: >> >> On Mit, 2012-01-04 at 10:56 -0800, Ian Romanick wrote: >>> >>> On 01/04/2012 10:55 AM, Daniel Stone wrote: Hi, On 4 January 2012 18:45, Ian Romanick wrote: > > Okay, I looked back at your build output, and I think I see the > problem: > > * econf: updating Mesa-/bin/config.sub with > /usr/share/gnuconfig/config.sub > * econf: updating Mesa-/bin/config.guess with > /usr/share/gnuconfig/config.guess > ./configure --prefix=/usr --build=x86_64-pc-linux-gnu > [...] > > Since it's a raw GIT tree, this should be 'autogen.sh' instead of > 'configure'. The Makefile.in files are generated by autoreconf (run by > autogen.sh) and consumed by configure. Since they haven't been > generated, > configure can't find them and gets angry. The ebuild scripts need to > either > run ./autogen.sh or run 'autoreconf -v --install' before running > configure. > > I bet that will fix it, and I bet that's why only Gentoo users are > still > having problems. Can you give that a try? See immediately before that: >>> >>> Preparing source in >>> /var/tmp/portage/media-libs/mesa-/work/Mesa- ... Running eautoreconf in '/var/tmp/portage/media-libs/mesa-/work/Mesa-' ... Running aclocal ... [ok] Running autoconf ... [ok] >>> >>> Source prepared. >>> >>> >>> Okay. I give up. I have no clue why it's not working. Patches welcome. >>> :( >> >> >> It's not running automake (just like the Mesa toplevel Makefile >> isn't...). > > > Right... autoreconf does aclocal, autoconf, and automake all in one shot. > That makes sense. > > About adding automake to the toplevel Makefile, where should that go? It > seems like adding it to 'default' or similar will break the non-autotool > builds. Doing that so close before a release seems mean. Since the automake > business is only necessary for 'make check', would putting it in the 'check' > target be sufficient? Hi Ian, I'm a little busy at the moment, but just wanted to mention that the automake integration looks OK on a first glance. The problems being faced here seems to be gentoo's "eautoreconf" script. I'm guessing that since the toplevel Makefile is not Makefile.am, it doesn't think it needs to run automake. That's lame and it's the whole reason the regular autoreconf script exists in the first place. It can tell that you added AM_INIT_AUTOMAKE to configure.ac and therefore it needs to run automake. There's no "automake" to add in the toplevel Makefile. autogen.sh/autoreconf will do the right thing. That said, you could definitely hack in these changes without pulling in automake. -- Dan ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev