[Mesa-dev] [PATCH 20/24] i965/cnl: Don't resolve single sampled color rb in case of sRGB formats
As sRGB now supports lossless compression, don't we also need to stop resolving single sampled color render buffers for sRGB formats in Gen 10. Signed-off-by: Anuj Phogat --- src/mesa/drivers/dri/i965/brw_context.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mesa/drivers/dri/i965/brw_context.c b/src/mesa/drivers/dri/i965/brw_context.c index 1247d03..9e19617 100644 --- a/src/mesa/drivers/dri/i965/brw_context.c +++ b/src/mesa/drivers/dri/i965/brw_context.c @@ -326,7 +326,7 @@ intel_update_state(struct gl_context * ctx, GLuint new_state) * enabled because otherwise the surface state will be programmed with the * linear equivalent format anyway. */ - if (brw->gen >= 9 && ctx->Color.sRGBEnabled) { + if (brw->gen == 9 && ctx->Color.sRGBEnabled) { struct gl_framebuffer *fb = ctx->DrawBuffer; for (int i = 0; i < fb->_NumColorDrawBuffers; i++) { struct gl_renderbuffer *rb = fb->_ColorDrawBuffers[i]; -- 2.9.3 ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
Re: [Mesa-dev] [PATCH 20/24] i965/cnl: Don't resolve single sampled color rb in case of sRGB formats
On Tue, May 16, 2017 at 3:41 PM, Anuj Phogat wrote: > On Fri, May 12, 2017 at 4:38 PM, Anuj Phogat > wrote: > > As sRGB now supports lossless compression, don't we also need to stop > > resolving single sampled color render buffers for sRGB formats in Gen 10. > > > s/don't we/we. Fixed locally. > > > Signed-off-by: Anuj Phogat > > --- > > src/mesa/drivers/dri/i965/brw_context.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/src/mesa/drivers/dri/i965/brw_context.c > b/src/mesa/drivers/dri/i965/brw_context.c > > index 1247d03..9e19617 100644 > > --- a/src/mesa/drivers/dri/i965/brw_context.c > > +++ b/src/mesa/drivers/dri/i965/brw_context.c > > @@ -326,7 +326,7 @@ intel_update_state(struct gl_context * ctx, GLuint > new_state) > > * enabled because otherwise the surface state will be programmed > with the > > * linear equivalent format anyway. > > */ > > - if (brw->gen >= 9 && ctx->Color.sRGBEnabled) { > > + if (brw->gen == 9 && ctx->Color.sRGBEnabled) { > I think I'd mildly prefer that we make this based on isl_format_supports_ccs_e at some point but that doesn't have to happen today. Reviewed-by: Jason Ekstrand > >struct gl_framebuffer *fb = ctx->DrawBuffer; > >for (int i = 0; i < fb->_NumColorDrawBuffers; i++) { > > struct gl_renderbuffer *rb = fb->_ColorDrawBuffers[i]; > > -- > > 2.9.3 > > > ___ > mesa-dev mailing list > mesa-dev@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/mesa-dev > ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
Re: [Mesa-dev] [PATCH 20/24] i965/cnl: Don't resolve single sampled color rb in case of sRGB formats
On Fri, May 12, 2017 at 4:38 PM, Anuj Phogat wrote: > As sRGB now supports lossless compression, don't we also need to stop > resolving single sampled color render buffers for sRGB formats in Gen 10. > s/don't we/we. Fixed locally. > Signed-off-by: Anuj Phogat > --- > src/mesa/drivers/dri/i965/brw_context.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/mesa/drivers/dri/i965/brw_context.c > b/src/mesa/drivers/dri/i965/brw_context.c > index 1247d03..9e19617 100644 > --- a/src/mesa/drivers/dri/i965/brw_context.c > +++ b/src/mesa/drivers/dri/i965/brw_context.c > @@ -326,7 +326,7 @@ intel_update_state(struct gl_context * ctx, GLuint > new_state) > * enabled because otherwise the surface state will be programmed with the > * linear equivalent format anyway. > */ > - if (brw->gen >= 9 && ctx->Color.sRGBEnabled) { > + if (brw->gen == 9 && ctx->Color.sRGBEnabled) { >struct gl_framebuffer *fb = ctx->DrawBuffer; >for (int i = 0; i < fb->_NumColorDrawBuffers; i++) { > struct gl_renderbuffer *rb = fb->_ColorDrawBuffers[i]; > -- > 2.9.3 > ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev