[Mesa-dev] [PATCH 25/26] mesa/es: Remove redundant glFramebufferTexture3D textarget validation

2012-08-17 Thread Ian Romanick
From: Ian Romanick 

Signed-off-by: Ian Romanick 
---
 src/mesa/main/APIspec.xml |4 
 1 files changed, 0 insertions(+), 4 deletions(-)

diff --git a/src/mesa/main/APIspec.xml b/src/mesa/main/APIspec.xml
index dd7bf90..63a2b35 100644
--- a/src/mesa/main/APIspec.xml
+++ b/src/mesa/main/APIspec.xml
@@ -2916,10 +2916,6 @@



-
-   
-   
-   
 
 
 
-- 
1.7.6.5

___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev


Re: [Mesa-dev] [PATCH 25/26] mesa/es: Remove redundant glFramebufferTexture3D textarget validation

2012-08-19 Thread Kenneth Graunke
On 08/17/2012 08:11 PM, Ian Romanick wrote:
> From: Ian Romanick 
> 
> Signed-off-by: Ian Romanick 
> ---
>  src/mesa/main/APIspec.xml |4 
>  1 files changed, 0 insertions(+), 4 deletions(-)
> 
> diff --git a/src/mesa/main/APIspec.xml b/src/mesa/main/APIspec.xml
> index dd7bf90..63a2b35 100644
> --- a/src/mesa/main/APIspec.xml
> +++ b/src/mesa/main/APIspec.xml
> @@ -2916,10 +2916,6 @@
>   
>   
>   
> -
> - 
> - 
> - 
>  
>  
>  
> 

Hmm.  I would've thought the category="OES_texture_3D" tag would cause
it to only accept this when the OES_texture_3D extension is advertised.
 But it doesn't seem to.

It looks like we happily process this function even without
OES/EXT_texture_3D support.  Probably wrong, but I doubt anyone is
likely to run into trouble because of it...

Reviewed-by: Kenneth Graunke 
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev


Re: [Mesa-dev] [PATCH 25/26] mesa/es: Remove redundant glFramebufferTexture3D textarget validation

2012-08-20 Thread Ian Romanick

On 08/19/2012 11:58 PM, Kenneth Graunke wrote:

On 08/17/2012 08:11 PM, Ian Romanick wrote:

From: Ian Romanick 

Signed-off-by: Ian Romanick 
---
  src/mesa/main/APIspec.xml |4 
  1 files changed, 0 insertions(+), 4 deletions(-)

diff --git a/src/mesa/main/APIspec.xml b/src/mesa/main/APIspec.xml
index dd7bf90..63a2b35 100644
--- a/src/mesa/main/APIspec.xml
+++ b/src/mesa/main/APIspec.xml
@@ -2916,10 +2916,6 @@



-
-   
-   
-   
  

  



Hmm.  I would've thought the category="OES_texture_3D" tag would cause
it to only accept this when the OES_texture_3D extension is advertised.
  But it doesn't seem to.


Mesa always advertises GL_EXT_texture3D (part of OpenGL 1.2) and, 
therefore, OES_texture_3D.  It doesn't check for support because it 
always is supported. :)



It looks like we happily process this function even without
OES/EXT_texture_3D support.  Probably wrong, but I doubt anyone is
likely to run into trouble because of it...

Reviewed-by: Kenneth Graunke 

___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev


Re: [Mesa-dev] [PATCH 25/26] mesa/es: Remove redundant glFramebufferTexture3D textarget validation

2012-08-20 Thread Kenneth Graunke
On 08/20/2012 09:46 AM, Ian Romanick wrote:
> Mesa always advertises GL_EXT_texture3D (part of OpenGL 1.2) and,
> therefore, OES_texture_3D.  It doesn't check for support because it
> always is supported. :)

Then why is it not &dummy_true in extensions.c?
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev